diff mbox series

spi: SPI_HISI_KUNPENG should depend on ARCH_HISI

Message ID d93934dfdbb4d35e35371517de3b64c144aeb5ef.1618316782.git.geert+renesas@glider.be (mailing list archive)
State New
Headers show
Series spi: SPI_HISI_KUNPENG should depend on ARCH_HISI | expand

Commit Message

Geert Uytterhoeven April 13, 2021, 12:27 p.m. UTC
The HiSilicon Kunpeng SPI controller is only present on HiSilicon
Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
the user about this driver when configuring a kernel without Hisilicon
platform support.

Fixes: c770d8631e1810d8 ("spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown April 13, 2021, 12:47 p.m. UTC | #1
On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
> the user about this driver when configuring a kernel without Hisilicon
> platform support.

Are you *sure* about this?  HiSilicon produce a wide range of SoCs with
very diverse target markets, this driver looks like it's for enterprise
stuff while most things guarded by that config option look like they're
for embedded applications.
Jay Fang April 13, 2021, 12:59 p.m. UTC | #2
On 2021/4/13 20:47, Mark Brown wrote:
> On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
>> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
>> Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
>> the user about this driver when configuring a kernel without Hisilicon
>> platform support.
> 
> Are you *sure* about this?  HiSilicon produce a wide range of SoCs with
> very diverse target markets, this driver looks like it's for enterprise
> stuff while most things guarded by that config option look like they're
> for embedded applications.
SPI_HISI_KUNPENG does not depend on ARCH_HISI.


Thanks,
Jay
Mark Brown April 13, 2021, 1:09 p.m. UTC | #3
On Tue, Apr 13, 2021 at 08:59:02PM +0800, Jay Fang wrote:
> On 2021/4/13 20:47, Mark Brown wrote:
> > On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:

> >> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> >> Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
> >> the user about this driver when configuring a kernel without Hisilicon
> >> platform support.

> > Are you *sure* about this?  HiSilicon produce a wide range of SoCs with
> > very diverse target markets, this driver looks like it's for enterprise
> > stuff while most things guarded by that config option look like they're
> > for embedded applications.

> SPI_HISI_KUNPENG does not depend on ARCH_HISI.

Right, but that's what Geert is proposing to change - the question is
does it make sense to do so or not?
diff mbox series

Patch

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1ffcad19c0562a39..7d438ad343598bb8 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -334,7 +334,7 @@  config SPI_FSL_QUADSPI
 
 config SPI_HISI_KUNPENG
 	tristate "HiSilicon SPI Controller for Kunpeng SoCs"
-	depends on (ARM64 && ACPI) || COMPILE_TEST
+	depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST
 	help
 	  This enables support for HiSilicon SPI controller found on
 	  Kunpeng SoCs.