From patchwork Tue Jan 7 03:42:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 13928168 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5536CE77197 for ; Tue, 7 Jan 2025 03:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p54xDpSMcpfpFU3zdQGXgiKs6ViJz/NPgxrzUcuVzcQ=; b=hNocnmk5ZCIfnY2cxk8JvzZKew J8OgKG+G934wouo2S75THT2dWvKkk1WqBg60u4U+UKExEISQpzgxe4nvCSYMmOAGl7ARxJhRV0BKn k65HXBZx3/j3WALRjlQh1rqNJqdIIe/cpL+RHivIUxqkLduhF7LuR5KuP6djr0N5u8fMIzQxehGmz ISXdpEr3GqCy6uM2RTlUQpzDw5GVRVEbuPUAIHYXkfGmZM/1R5y8ysPB4Al2EjXSFQz0rMXmpYWV9 WpEd38RVZE4o+/HjeD8dXwbHabbBtH60V8NT3JeiXpFF2K7jcHXs8EhCGmMsdMAQGdW9vMh9kM+dI Id9XNbug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tV0YQ-00000003MNJ-1kTc; Tue, 07 Jan 2025 03:46:54 +0000 Received: from mail-dm6nam11on20627.outbound.protection.outlook.com ([2a01:111:f403:2415::627] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tV0Us-00000003KWJ-2CQ7 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jan 2025 03:43:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PfZnwKpy394sqAKEs3ozlkbHrRv/FysXtzjPD2tgJTYcCCGhEiZb03C1DsMGsG15Hr7aIfNUD60WSvCwO84ZlteTMowLnGr8rJvhbcF8poDg2OA06SMJndcBHSmrt9/gNNBR5rxW4ZTYqmXiiBUjlcz7Gn8qIIdfmkU6PtdlpoOjgAkEcDDirNVKbkikKLVvw+1gBDY65bcPI2m8ty2Y2ZiG92HCf8BU1zhOlT7+pCuWg5a64cEBAFsUS74IaUJp0OnfjJPhNhWf0FOh9rSSNvqOx/kFPQoJu4qxpXktjw3bO4Ycjq53fwoTfbidjtWmvj/RVAzbhZjh4k4bAqKwQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p54xDpSMcpfpFU3zdQGXgiKs6ViJz/NPgxrzUcuVzcQ=; b=K6mcsk/i1gkWgA7lk6c7E/PPPixkYRiGaqNXq4N+3GB/VUx6NxvqQlAKdndcPvJABZYEKBT9YFpNzn+h0JCnIdmxegHTxww4uliOfJmBNyFzHKnqfOy/78PTkZoelKL4Ai2uMIZTCRVK+44uZU8X+kA4MgwIz3B721bGY4l9O/Dq/5+5qI1RN0Y399S4v5M6HDGvA1vJhdPke0X3kUoTNkKp/uetdK5cgArqbmMLZ7N4ra7I37LG7xHROobO2Us4tFfbwXlWAcYNaDZH5QE5PlakVK5nttpTtvdY+WSBlnlNSJSaLAHw+QRMz7WUGi8y70wYw+Zdh/D3atG6oyszfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p54xDpSMcpfpFU3zdQGXgiKs6ViJz/NPgxrzUcuVzcQ=; b=LfOrDeR2ogwBZrfEXmnayxqUeMPq9FlNboQEJ6Re7U4akOJ5Qd6hrJGMZ6ldbjP0oAbHEpbNjRarxWhIT55iJnCMX111opcLPvjaOfT6z6Lar54xfoUK29OZpzIXNeXJDNX+g/MF8wc8hakW9JnJc/jEQhpmnnVWSjQ0ludTECETwQn50yR78DG6WnXnWGo1HfTD8GSX6NJ2ds7CF1yoWw7vgaP001Icp+E3V4fkIITaj5jmkdGJx5yWI+faObemmTxrDHo4dJXf3jU/yM22VZCR/lPnMI3Dt/gIlOoMdoHh//v+E7obae+GOb57I7WFYbyIwe9kMOK8hPCXimffvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by CY5PR12MB6129.namprd12.prod.outlook.com (2603:10b6:930:27::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.15; Tue, 7 Jan 2025 03:43:07 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%6]) with mapi id 15.20.8314.015; Tue, 7 Jan 2025 03:43:07 +0000 From: Alistair Popple To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alistair Popple , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com Subject: [PATCH v5 02/25] fs/dax: Return unmapped busy pages from dax_layout_busy_page_range() Date: Tue, 7 Jan 2025 14:42:18 +1100 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: X-ClientProxiedBy: SY5PR01CA0106.ausprd01.prod.outlook.com (2603:10c6:10:246::24) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|CY5PR12MB6129:EE_ X-MS-Office365-Filtering-Correlation-Id: 50f3ef15-c25d-4e5e-f9f0-08dd2ecd662d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: Dp5gI0xRBOkG5n75skity/By/XlYbi2N42TXmQEnyrEkfH6ROwVD8N/X+0FaSVCMNv+WDEnDaRUEAZwizu7R3bAIsK3schXWg66ZJ0J1bQdEpW4KWNCyeAT3tim7LXQ9ZYa5spV2YTDf54P3mDxqhfJ0Tag0FEalZWjJvIQm8trp72Wzpf35F2GXXPy9+TW1j84CF9fRVdWPi4+TbGORD+Fjb1Zh3GUJsjmSmYMYnevA9m6Eg3PRlPysg2T3p3aY9ZV2012rksv1Pjtjr0Xni83G5EJV0hThTIZZESgtHwmjrXplu+WojGE3qpePA00m6RNcwOpW1MMNPwfZtYeIaYoEeuBXxCv83it2HuRRsGDtRrcS7rnRaAjgoT9GsFv+1IVU8fdFv6J1haygWnqJ13ahR2zIxLwWT2mNzPSQB28VkRVzQm/AIeg4yTtrqXxn21hgJ3qS7xV/pTVt/xVXABK9awYIxKxm6B3IdZsfJrc3WAey88rHSf7d9SSPal/ha9Ie2nk+s++xTr1jNFZ+zvdTYEsFkn16Bqs/7KNqPCcA/G4NyWAoPRlHd93gJGdfSj4DeOjd7qaWlftZaceYUsour6PC9ZyVAXNnTj8ljnUj1Hc89T/i4yR4A523U2JGx+XJO0XtctzMDjDxMx0L7hk4WQDS0bZxVeMsLqyr2NAQ50FStI4B0Q6TkccSUEGyCpRJQlRsAu4lUSMLDag1etqd1eqqhsLw3aqnWOfiaI2mTGbe0WA9dD/kZ0VADRmMipjYPeUScHEWkhcOvsi5O/SH1Tlb4vn2EPDX0tEq12kPFIQLvQfpmVsWor9eilDd1POkWgjOd2F4fkn0JBgAySXQ272aedjNbRHHeuxXTk0KQiCaaTkp1HXbU1MY/lqX8C1pUXK+fVJYPc7VaPkL8Pwq7vXGve+IlN2saQwOGTsti3s62PlRbKdX0tK5z5hoPJGeZrUHBI6BImZJm+0hUByFUvo0f4uc/dspV4rt9q9DBSwucbA5gFuQ2mXZ/Kr5Lar04VicZFfakLw3QRkFD173I39n/amKvLkB49XC8Y4hM8GVXcwMTCHkonWk6UOXDNa+5H0G9iuaja8rRv3xfhmIE46VAodNLg1goUkA2DGXk1KcpauA/ceWqKYOszr7VbZn5KwDoSx/FIxnWat6/Vaxsol4djvd4NlQyUEaZpZb8eNqP8SDo+Wvx8zG9p5c1dNFXNcIFzJbDecoGHvWq9sTMyvh+lZlc1zbgc7y4ooyf9TqrqCmM/P4o6LczIE5TCuUc4UoyykQE2BWonGKQ2xofCnJILUfPkfcKjtWwdeaHCN0U4Cq1QcAgNoIaPGUjvTg4zlPO+0DFLJRJwDUux/QU8aI0Fol8AhYFS44QdpW6hjnYay+p0wTaWSUs7pM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Qj/Nqim71hA8rQtPsVN4XktDUdnzHmje0EE4A7fwOeeQN/A1fqzD2SpZmIuKfsmSd3NLcWUd5iuak7gAIdDlnMucXgnXOi4GzEm5IrDM4MOXv2cA+osTYRDL88I5MUqAcRlQQ5xlggiruKgiPeqmElPKdhssbXjaPh6S5aJq5Wn5LQSbbzL357hmdnrXqbcf3xtELRJaqa0pqFCNomPEG+AavsFDDV+kli/M9Q1Jh4OJ3zPBz1D9YTCchQykK5seEGWXWM/wdKTNahemWL9ceaWl9jsPKovRPMTHqycs/4yXM3zYx5FmFFHvFMPVcxACjghxJq5TQM8QdzRISDxRWuor1YCI1NWWV7MzftmS/62zSIHav6MboC6ptmODSzzKP8lKL/NaGii9vJAU/V8SgTgeQRhlvHJMIh2bSVOKBBtl5+Q65JN7KjhxINvkSlCG0x9T6aP+roaZH51RlZO2lq7cKTbxT9Md5uUPe8ocgGEQ5dB4jaPuu38A4YyuUgW3iIr7CC2PcBH10fJjWpzqHcv8EOTZoTjnkYI8bc8SveDH7ZloaxyXOlo23flov11bh1pPjhsX4LSZFp71eVlH4qnuHY+285dTAN/fdeNp1MVtoSXP7Y6pUdzVUpdjBR61T1yIgBPzEDJcHVCxXlFQ8t2qbeLy7eQpx+1+RR9EjXgafFyJu8kQQ2nJeiwm4jl9zI9gAeVxKnodq/9Tw5JALDAJQqm7oquWnWymM3hSjdk/H2EWLSleYM3/l+KNpFHtKrIZEglMZ59jtkxqtrs4iCydulZSCH93e4xLVwLz6yr2odPAggISzUzqQ6qwmWShQ1KGJ94lO2o94xMkeSq6EqHg8erS6aI2SZoL3wniBNlgjnkyoEPjpNUejnsehN+hJrZZCxXeumFgxqxdQl4o7ecImC3sAWqaR0qy6fEaaZN20NH856hz3ywzTq2t1qpPtHP5un+JCsrRHBWqEWtysXIe2zeLeHLOY6Mx3TeiRpX2BTBA/upUC4gQmftSx/j8Hh0PVRUZvYTQytudokQO0bS9Bp1Wip/jRwfrpE3DbdVgzVwBmy/5KDIqLQHdSZsHZCErWnbVy+sZwk/4sIGsoRuMP7yDKyvsbUdfRDvlPCFQInhOQBA7G7+dOHRA6bPqqezZ6oAOZiIODYnMKazkgWTWMxvFV4F84R3lC4+dYWmxRDdTwb6Zalq0slEZ6lSTOGZOgQCV2oZyvw+s2gtH8HXVz01dqjHUMiMgbtTRRqiLsQBIFu7GkVYsYf7A5yJj89NGdYKy1JByHXVzCs3Kqc3PtOhjomqxXqOiFG3/hggx07ynUZfUJNbYeQXZhsIkADBNQs3yRqS+xyyNJ3sl7iGfMc+W8sUeEW1E6eq025/+79usp98EPbDeY0g7YE4QLZbF6Aym5fvoWYbvxpRJnN8pksbSUgmxztUp5lrcyg97DjdFDqo21XfMy3kLX7M86QcU+ep7fUEgMuwOEBdDq+lonwDKu4ROv+JpHnNJoRJIw2JbGk/ARewU2ymnk/07s2IOBk0uiJzzIY3/PyXVn8XPIjpY2eHxOYkmjB9kciVIZPjo15bu36u0gQNL12le X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50f3ef15-c25d-4e5e-f9f0-08dd2ecd662d X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2025 03:43:07.5453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nzGjNQ9z6uEiLtMx5xnxTlaT1ZZEMAa+aX+0BV2uepNtspnFNh3gR1vzfg77ty4Pz5JeFNED7qhrXUB1jzwelA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6129 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250106_194314_562164_8E2A34C5 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dax_layout_busy_page_range() is used by file systems to scan the DAX page-cache to unmap mapping pages from user-space and to determine if any pages in the given range are busy, either due to ongoing DMA or other get_user_pages() usage. Currently it checks to see the file mapping is mapped into user-space with mapping_mapped() and returns early if not, skipping the check for DMA busy pages. This is wrong as pages may still be undergoing DMA access even if they have subsequently been unmapped from user-space. Fix this by dropping the check for mapping_mapped(). Signed-off-by: Alistair Popple Suggested-by: Dan Williams Reviewed-by: Dan Williams --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index 21b4740..5133568 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -690,7 +690,7 @@ struct page *dax_layout_busy_page_range(struct address_space *mapping, if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) return NULL; - if (!dax_mapping(mapping) || !mapping_mapped(mapping)) + if (!dax_mapping(mapping)) return NULL; /* If end == LLONG_MAX, all pages from start to till end of file */