From patchwork Wed Oct 4 14:02:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Murphy X-Patchwork-Id: 9984785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6B6F760586 for ; Wed, 4 Oct 2017 14:03:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EF4928692 for ; Wed, 4 Oct 2017 14:03:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 52D6428770; Wed, 4 Oct 2017 14:03:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DF55328692 for ; Wed, 4 Oct 2017 14:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zkrUdKcYmZNRMvxJMmbGiQvWFo1PI84tkveNzSnJkpg=; b=T+2Nle9lfHP2It YLUE0AuPRUcpNI4i76z+AOpeGtv1dmIlqx01hNqFB/hEusQVn7XgE8o7JyyI8A7JrW6tgve/hTH/4 ri+jVcmHtJc7xkS5IP0VzU2Ewdru6b1wDVR26Ez6oFLXz39Nk3GFpkiZqduP5P7YHmZdTe/PFzDkJ hDuP33gkUE54E+8g/TxZLV6Gz04kdUmiEOPNat2+/D9l1cr9HenwX8wu9zU2RCkFEWzQw9J4tnpjX k2VHY1SZXfle82/5KNIn0F0QVG2+AMN1T3RkslVyrqkEqmNMVt0l0GpLpoNNn+n3sJ6kT0jTwYUgH r+3HgHtfKKMlsT20iMnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dzkGk-00082O-Pb; Wed, 04 Oct 2017 14:03:26 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dzkGf-0007zY-I2 for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2017 14:03:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64DF71435; Wed, 4 Oct 2017 07:03:01 -0700 (PDT) Received: from [10.1.210.88] (e110467-lin.cambridge.arm.com [10.1.210.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB6EF3F483; Wed, 4 Oct 2017 07:03:00 -0700 (PDT) Subject: Re: defconfig'ed v4.13 does not boot on ThunderX To: Mark Rutland References: <135495b6-e13e-5c90-6130-addb60d0fa5c@riken.jp> <20171004134414.GF23092@leverpostej> From: Robin Murphy Message-ID: Date: Wed, 4 Oct 2017 15:02:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004134414.GF23092@leverpostej> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171004_070321_616918_16B2C53C X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Itaru Kitayama , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 04/10/17 14:44, Mark Rutland wrote: > On Wed, Oct 04, 2017 at 02:38:58PM +0100, Robin Murphy wrote: >> On 04/10/17 08:25, Itaru Kitayama wrote: >>> Hi, >>> >>> defconfig'ed kernel v4.13 does not boot on ThunderX, leaving only >>> messages below: >>> >>> EFI stub: Booting Linux Kernel... >>> EFI stub: Using DTB from configuration table >>> EFI stub: Exiting boot services and installing virtual address map... >>> >>> Our HW is by GIGABYTE, the model is R150 T62 rev 100: >>> >>> http://b2b.gigabyte.com/ARM-Server/R150-T62-rev-100#ov >>> >>> The BIOS we're on is T43. Has anyone testing upstream kernels seen a >>> similar issue like this? >> >> FWIW defconfig does *not* enable most of the ThunderX drivers (most >> importantly, PCI and networking will be missing). > > .... it's a bit worrying if earlycon doesn't work without those, though. > It shouldn't be dependendent on either. :/ Well, my earlycon was fine too, but that was an a different board with different firmware, so who knows... >> I've just built the v4.13 tag with the appropriate drivers added and >> booted it on a different ThunderX box - the net core throws some >> warnings from __dev_xdp_attached() but it gets to userspace OK for me. > > Given these seem to exist out in the field, we should probably enable > those drivers in defconfig. True, I think the below ought to suffice - arm-soc take defconfig patches now, right? Robin. ----->8----- From: Robin Murphy Subject: [PATCH] arm64: Add ThunderX drivers to defconfig ThunderX needs its PCI host drivers to do anything useful, and it's probably helpful to have networking by default too. Signed-off-by: Robin Murphy --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 34480e9af2e7..1c8e0d77deee 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -76,6 +76,8 @@ CONFIG_PCIE_RCAR=y CONFIG_PCIE_ROCKCHIP=m CONFIG_PCI_HOST_GENERIC=y CONFIG_PCI_XGENE=y +CONFIG_PCI_HOST_THUNDER_PEM=y +CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_ARM64_VA_BITS_48=y CONFIG_SCHED_MC=y CONFIG_NUMA=y @@ -188,6 +190,7 @@ CONFIG_VIRTIO_NET=y CONFIG_AMD_XGBE=y CONFIG_NET_XGENE=y CONFIG_MACB=y +CONFIG_THUNDER_NIC_PF=y CONFIG_HNS_DSAF=y CONFIG_HNS_ENET=y CONFIG_E1000E=y