| Message ID | dfc15d59-7fa9-4f96-aacb-37c3df6d420d@stanley.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all() | expand |
On 3/10/2025 3:48 AM, Dan Carpenter wrote: > The next line checks if this regmap_write() failed, but it doesn't > work because the assignment was accidentally left out. Add the > assignment. > > Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 10.03.2025 11:48, Dan Carpenter wrote: > The next line checks if this regmap_write() failed, but it doesn't > work because the assignment was accidentally left out. Add the > assignment. > > Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Artur Weber <aweber.kernel@gmail.com> Best regards Artur
On Mon, Mar 10, 2025 at 11:48 AM Dan Carpenter <dan.carpenter@linaro.org> wrote: > The next line checks if this regmap_write() failed, but it doesn't > work because the assignment was accidentally left out. Add the > assignment. > > Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c index 7c8f8bd7da12..9ea20fde3a24 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c @@ -1498,8 +1498,8 @@ static int bcm21664_pinctrl_lock_all(struct bcm281xx_pinctrl_data *pdata) rc); return rc; } - regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i), - 0xffffffff); + rc = regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i), + 0xffffffff); if (rc) { dev_err(pdata->dev, "Failed to write access lock: %d\n", rc);
The next line checks if this regmap_write() failed, but it doesn't work because the assignment was accidentally left out. Add the assignment. Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)