| Message ID | e06e9f26-cf55-5596-c799-d698e9d7b409@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding | expand |
On 12.03.2023 22:29, Heiner Kallweit wrote: > Convert Amlogic Meson GPIO interrupt controller binding to yaml. > > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > - consider that more than one compatible may be set > - remove bus part from example > - remove minItem/maxItem properties for compatible > - reduce compatible fallback complexity > - add that 8 or 12 GIC interrupts can be used > - fix typo > --- > .../amlogic,meson-gpio-intc.txt | 38 ---------- > .../amlogic,meson-gpio-intc.yaml | 72 +++++++++++++++++++ > 2 files changed, 72 insertions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml > Who's going to take this patch?
Hi, On 12/03/2023 22:29, Heiner Kallweit wrote: > Convert Amlogic Meson GPIO interrupt controller binding to yaml. > > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > - consider that more than one compatible may be set > - remove bus part from example > - remove minItem/maxItem properties for compatible > - reduce compatible fallback complexity > - add that 8 or 12 GIC interrupts can be used > - fix typo > --- > .../amlogic,meson-gpio-intc.txt | 38 ---------- > .../amlogic,meson-gpio-intc.yaml | 72 +++++++++++++++++++ > 2 files changed, 72 insertions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml Gentle ping, this patch is fully reviewed and is lying on the list for the last 3 months. Thanks, Neil <snip>
On 20/06/2023 09:33, Neil Armstrong wrote: > Hi, > > On 12/03/2023 22:29, Heiner Kallweit wrote: >> Convert Amlogic Meson GPIO interrupt controller binding to yaml. >> >> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> - consider that more than one compatible may be set >> - remove bus part from example >> - remove minItem/maxItem properties for compatible >> - reduce compatible fallback complexity >> - add that 8 or 12 GIC interrupts can be used >> - fix typo >> --- >> .../amlogic,meson-gpio-intc.txt | 38 ---------- >> .../amlogic,meson-gpio-intc.yaml | 72 +++++++++++++++++++ >> 2 files changed, 72 insertions(+), 38 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml > > Gentle ping, this patch is fully reviewed and is lying on the list for the last 3 months. Maybe just take it through your Amlogic SoC tree in such case? It's less preferred than subsystem, but still what matters is to get this merged. Best regards, Krzysztof
On 20/06/2023 09:36, Krzysztof Kozlowski wrote: > On 20/06/2023 09:33, Neil Armstrong wrote: >> Hi, >> >> On 12/03/2023 22:29, Heiner Kallweit wrote: >>> Convert Amlogic Meson GPIO interrupt controller binding to yaml. >>> >>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> Reviewed-by: Rob Herring <robh@kernel.org> >>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >>> --- >>> - consider that more than one compatible may be set >>> - remove bus part from example >>> - remove minItem/maxItem properties for compatible >>> - reduce compatible fallback complexity >>> - add that 8 or 12 GIC interrupts can be used >>> - fix typo >>> --- >>> .../amlogic,meson-gpio-intc.txt | 38 ---------- >>> .../amlogic,meson-gpio-intc.yaml | 72 +++++++++++++++++++ >>> 2 files changed, 72 insertions(+), 38 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml >> >> Gentle ping, this patch is fully reviewed and is lying on the list for the last 3 months. > > Maybe just take it through your Amlogic SoC tree in such case? It's less > preferred than subsystem, but still what matters is to get this merged. Yep I'll send it via the amlogic tree this week if Marc or Thomas doesn't object, Neil > > Best regards, > Krzysztof >
Hi, On Sun, 12 Mar 2023 22:29:07 +0100, Heiner Kallweit wrote: > Convert Amlogic Meson GPIO interrupt controller binding to yaml. > > Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.5/drivers) [1/1] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding https://git.kernel.org/amlogic/c/6b0139b372d40bd5dafc140b6618b57d13211168 These changes has been applied on the intermediate git tree [1]. The v6.5/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt deleted file mode 100644 index bde63f8f0..000000000 --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt +++ /dev/null @@ -1,38 +0,0 @@ -Amlogic meson GPIO interrupt controller - -Meson SoCs contains an interrupt controller which is able to watch the SoC -pads and generate an interrupt on edge or level. The controller is essentially -a 256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge -or level and polarity. It does not expose all 256 mux inputs because the -documentation shows that the upper part is not mapped to any pad. The actual -number of interrupt exposed depends on the SoC. - -Required properties: - -- compatible : must have "amlogic,meson8-gpio-intc" and either - "amlogic,meson8-gpio-intc" for meson8 SoCs (S802) or - "amlogic,meson8b-gpio-intc" for meson8b SoCs (S805) or - "amlogic,meson-gxbb-gpio-intc" for GXBB SoCs (S905) or - "amlogic,meson-gxl-gpio-intc" for GXL SoCs (S905X, S912) - "amlogic,meson-axg-gpio-intc" for AXG SoCs (A113D, A113X) - "amlogic,meson-g12a-gpio-intc" for G12A SoCs (S905D2, S905X2, S905Y2) - "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3) - "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L) - "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2) -- reg : Specifies base physical address and size of the registers. -- interrupt-controller : Identifies the node as an interrupt controller. -- #interrupt-cells : Specifies the number of cells needed to encode an - interrupt source. The value must be 2. -- meson,channel-interrupts: Array with the 8 upstream hwirq numbers. These - are the hwirqs used on the parent interrupt controller. - -Example: - -gpio_interrupt: interrupt-controller@9880 { - compatible = "amlogic,meson-gxbb-gpio-intc", - "amlogic,meson-gpio-intc"; - reg = <0x0 0x9880 0x0 0x10>; - interrupt-controller; - #interrupt-cells = <2>; - meson,channel-interrupts = <64 65 66 67 68 69 70 71>; -}; diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml new file mode 100644 index 000000000..fe7ef1916 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml @@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/amlogic,meson-gpio-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Meson GPIO interrupt controller + +maintainers: + - Heiner Kallweit <hkallweit1@gmail.com> + +description: | + Meson SoCs contains an interrupt controller which is able to watch the SoC + pads and generate an interrupt on edge or level. The controller is essentially + a 256 pads to 8 or 12 GIC interrupt multiplexer, with a filter block to select + edge or level and polarity. It does not expose all 256 mux inputs because the + documentation shows that the upper part is not mapped to any pad. The actual + number of interrupts exposed depends on the SoC. + +allOf: + - $ref: /schemas/interrupt-controller.yaml# + +properties: + compatible: + oneOf: + - const: amlogic,meson-gpio-intc + - items: + - enum: + - amlogic,meson8-gpio-intc + - amlogic,meson8b-gpio-intc + - amlogic,meson-gxbb-gpio-intc + - amlogic,meson-gxl-gpio-intc + - amlogic,meson-axg-gpio-intc + - amlogic,meson-g12a-gpio-intc + - amlogic,meson-sm1-gpio-intc + - amlogic,meson-a1-gpio-intc + - amlogic,meson-s4-gpio-intc + - const: amlogic,meson-gpio-intc + + reg: + maxItems: 1 + + interrupt-controller: true + + "#interrupt-cells": + const: 2 + + amlogic,channel-interrupts: + description: Array with the upstream hwirq numbers + minItems: 8 + maxItems: 12 + $ref: /schemas/types.yaml#/definitions/uint32-array + +required: + - compatible + - reg + - interrupt-controller + - "#interrupt-cells" + - amlogic,channel-interrupts + +additionalProperties: false + +examples: + - | + interrupt-controller@9880 { + compatible = "amlogic,meson-gxbb-gpio-intc", + "amlogic,meson-gpio-intc"; + reg = <0x9880 0x10>; + interrupt-controller; + #interrupt-cells = <2>; + amlogic,channel-interrupts = <64 65 66 67 68 69 70 71>; + };