From patchwork Thu Jun 27 00:54:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 13713647 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E8C2C27C4F for ; Thu, 27 Jun 2024 00:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mK3Q7dledyN8DAN2X2wWxUAB8Y4QPRw76IMsraD1iJc=; b=DjmL7dWJ+Egt4BMw39FmuIhdqW zSMzysy8QKpUxRIf1QlA7mudlCweKJnHyCUWfCpaHIBnoSfhtz5Lkj5cEUMXls+EELLsSe/kjcg5k Ue4QaGSZjiCSkjJrrOtk8DK2cdRez9aoJRbzbJEmJscup9pzWaLsef65fJ/v/sFoTSeXg3ppLKqlM dfu9hVZ+FV3SaxpeampydqnhKLpXRPcGWlBJgFkYCUJYwENdnOoaMr3miWvruN2i++VCYAmoAGWQR +ctqfuSGAuskoJ6dLRkyJ2XzTEJ7Xvj6NOAWLuWoUtTEaasFKpLE9Z8LbX60NzqMd9okB6AnWhskv dR3ddlkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMdPm-00000008mr9-470g; Thu, 27 Jun 2024 00:55:06 +0000 Received: from mail-co1nam11on20600.outbound.protection.outlook.com ([2a01:111:f403:2416::600] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMdPZ-00000008meE-0mh5 for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 00:54:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k0ywJKm8tCOaxBYYLhd0QwDA160ctJ+GR0y2S96seU2joAQNBWsZ4m3R1TOsiGVk+QlwF+bnjuaQO4OsD/rX26k4SpAesrw+bFW+fdLkgXrKbGVpSEvGkHBQBeXe6Q0tUAUvqEYMljcyrFax578azMIAIQO36IaX1AnleTZ7JnHh3ATyiVdi6XkoHoijX79CkOkTzNXxOE5t3eZLuBDKOImDGlq8vb/lpv9ViZnQLYB/2toQ8gN98I/DZ+sRbwEZK8HzTSfx1xuNcvFvAH7Sr4wpIl9Sp//jZhJFkGfpeaVMbfpJtm319DetFCa4itVLrTloScdLOR4H8o0Y2kzt8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mK3Q7dledyN8DAN2X2wWxUAB8Y4QPRw76IMsraD1iJc=; b=C/14CJT/AAC8R4q5ui3bTeupnvA0go0rJXuPLyCXleArk+J8XkXxMMqcgIPnpQsv35gie4yM6wYR+9n5b1G2jyC/5hqHs2R0Dcq23DUbtcAaKaQ6OzsS0fI1EJaWTmfWwy5N7zsI65tJVVpcpas5RGzkTvUwdbDUX29F8UA1DuXWgVLbKFyvCKcTdbpj7dC2c9wre1zqbzZEgJaWseKUc36tVf3xBm4evzbwVxG7idBOSHiCFgr41t2p9u9WYL8YYqwX/gNIf5pYMcJ7OMnHSi6NZrJlJzR+3mpzdkcsBr2VePZU4dlRTeMyW6ShAifvKXgQfSk+k1QZHvpp7ypamg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mK3Q7dledyN8DAN2X2wWxUAB8Y4QPRw76IMsraD1iJc=; b=azdCAhwqDDVV+99DFwCGxQB2Mo9rQLlBSrhaqYBN7hlerPTasyXvR6CbhCH86ykFFXqtx3jUwSUo7fcPfXs9XP8r3B30cCEqWeuVyS2xjeX86ZSkqSv1ynVCGBHRHqWFepYLtfa2i7f7qNLmF0xlF0D19+LEJ6al0JAqHYAHgV95KVndqshDF5EGaEonMUBquiKq/dTF/A0FDF8HmDn27mO1YB2vVYdnDivmibEKwBPPZAz63HIZtsJ+X+SiI10gP/TTF4QuMCbsaRja3BC6DK8b62Pg6ABpUxd+S8Fb9Gvjv8omAHfgaCj/2eQ9OsxNCPo5J4gaVOY93PLsq+Tlew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by MW6PR12MB7071.namprd12.prod.outlook.com (2603:10b6:303:238::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.32; Thu, 27 Jun 2024 00:54:40 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%6]) with mapi id 15.20.7698.025; Thu, 27 Jun 2024 00:54:40 +0000 From: Alistair Popple To: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca Cc: catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, Alistair Popple , Jason Gunthorpe Subject: [PATCH 01/13] mm/gup.c: Remove redundant check for PCI P2PDMA page Date: Thu, 27 Jun 2024 10:54:16 +1000 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: X-ClientProxiedBy: SY6PR01CA0074.ausprd01.prod.outlook.com (2603:10c6:10:110::7) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|MW6PR12MB7071:EE_ X-MS-Office365-Filtering-Correlation-Id: 9df7d926-9ecb-4372-63bb-08dc9643b98b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: 6nNs6ILqUaKyZAxJsQmBL66HeVKyScdfhQi9T12cqftQM4kofG82Q87PnoUldyB4G18qa/cV7Pm50/9t3DhNYrpn4knN0bOIg4KhdQfrPoR00qM4h6N7iz2GVdorE8fHFv8S6jf05wSDgBfA++zUF44piHjFKcsW0Z9jor8TyYB7Trfua+ioZDQkYbyKzTTyx1Cwrq+7vvI0dfS2qndKQwgjBzgtdaZ7yw1vUAIxq9xGRLnilpCluRAcnpXg17dpXWfTC1p+kn2GtYfevsMRVxbT1K0UMzp4+pdO7KpFo63WgbSNxctI9p7trzrRmjrgDHRBSMNHaJY1tdV3UrCjXv5SESp/y7YbthYxsgyl8x8mdEJ//s5e8Glyend6IbPdmlKm9xGTNEwhuHqPMXf6qOEJIiYpDaF8QXUwr8jkHtEbzujIjIEH0Jg+nUftGFiyNFj/nSpmOje3bTSzDxIIU9gFD2B4J0bELtf/vTyhz+1/F9hm8JcjFHnyAHpKQNbLPPvGbvOlrivDIgfveVnccbfhexpbwahVKNeTwKlqww7mUMw1ewUd5HvNwz4N1yQlkidQztmcYqONiATCwZsOofGUtTsp46FYsV84FBjhf4avPKfczn7xHXtUXu4Ihw4A95LM8Doez2JHGEAAKDnezz4wNaTbQyeahHMg3caB9dCuhW8ChlySpArjGorE8qjJywA/gQtWChZOdZHndqCGAHnSItfIMb4b7X1WA77DJcpy/MiBRNI4AVfyb6dfUFE2JsTew+t5j6wI26xu+OepO0L+wEm1TAJVSAyHqjWIQFl6+CQk+jFfYd97kQWHqfdqN6JPuVfpR+sdD6tVK45JWPpIP0a4KXFs15yQYCxI9kY3VmMfk/QzAVa8oPRULT8HK7ipI6kolC5wcDjvf3TREYc6/xYyXSLF/1ysDf/KFiaLKpTTGe8DS3hR4ZbwH9cDGxeqrl1LCdkQnYzc+bQVBwHfHmdGKAm719TbSrd6B/cu4dpbzzbgtzqfNVLcTRJey3/76z+hVDWbthl6RBdSmURW3KJriCSXeW/tcP8wawmOZ2zS5fmV1gJhEg3j533vi2r7qaOF1R9G+5awf6pjdshpjiIYdVEdbeV3d8bMz/DR4OHf8fJm1B8qTyiakx7fb8+AapvNwdPHP+1UA9fB+J57dWR5ktnRagtkQA/+rzJhncEsgxrFniwcGDvhzGLspC3jqCsPP1lYuVHYvGFBEnUHOArD2WRfARluCe+VTcqGCXuaRVKAaHvMMmREn1Sb32g8pxqkzaFzo2zbBexcbAtAggb5sXbtUbiB5YVmgYHYJIxSVeE2bCgMWxFPXcHcROJxPFeKpAd31JBr5Ge7EA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UteYh4NOQXgbxGq7QLU3zclGd2B9yHd/Bp0zRVnUs/dkbCFoOMgK1uPwKtkhUz5De6d2xtBNxqawfvuCcm7dIDNRntKH2nfzn55WJKvgCjZs0WJ5Vzz1Pi5kgYi8Lsx4/es6Eq6jZkymJC8m+KDd1zZ3h4rFaCsF8y8MPhy9dVXaZfQEYcIUlb+sE3Jz+k9jeAYQNxm9/WLPlA0JvotXG877lMGDq9zUYx5n5ctCmHHLFzecIo62mmcL2AsmCIJpMg53IkhkYjmlFmC2qSw047opdOOz6ywZKmoeI6qvLSUmXzj1OoCphQbVxI4tSHuF6KvAq1+PjmEwjdxeAVf1qR4T5/OcrLzyDwprHBqINWN0YjL3rx7TFA00UAPrt4YF23koTUHVv66mIRpXf/++LRrjBKn51pj+5FYVdeXcHUtTxFcBZU1Uq7Sf50qWBO1NTURkS645kmXekLRJad7M13x2inpBGcHkjg6IN+G0Fkg4l8dLsrKjEhzjlI7opDAko9kTLSmpT97U8Td3Mmsg5gwEvS6OehJqTOSjY7AuilEgSF7T/VwOCE/fXDKifW5s3uBXtBw4/VY0keJ7cmvW2knAg9VSCakON/X7c8p3nM98VAKujzOVGoNCkHp02oG5Fu9K2J+1hveI4lb8MD73FolmAQAWAHO9SlcmOsdxQ1hly9COqxpaDzBITh0uumFLsnLWBIMEi/mD+6HIvOKHCkr9UP/CBNi45Z0ipgTZaB76K26A14U4eNwt8G1BNaPySvQyLniTpPUVWZg04Ewt2k1V5f9RonRVeDhLIoSMdgYlPsHgjCtKYRZNKkmXMZaneQffXiux36TuORthexa0Ss6BOiHIs5IKVFVINMOoI5NqUaoQQEfgJwBrS0eJ1IyQXpdMZBVJO3TUhppbfbm8SmcVF9t9c/1kY8U4ki1KQEvqn/5SDK4r6In//zo8ExkOREtbrPHRSm3POmW8TJONPep+jE2v0pBxp/+YLdYEZuiBrtrujgJ859BJIXmsgL+dbmtL/pPF6Oq4O1xEozOmZln7Ok6VHDWbZwnP6RXh8+Ku8LH+UHEt4jk72OK1k4E/W/O6sGf3BUoFAh+/NpQNWSJLDveE0sGzn6JrPbsZzX6oRm+tfM/T5BUWFKpseoZ8xl009E35Pbh0N5BiLoT1glQ3apxV7nbpxWZ0hAraMJR41JqcstSr73dcAlzyQWw9pjjGCMmXwTtVzzSjaAnnFb6uIOtLdgtEghv/ENXSrtS110NjH8T431MDqGcL6hYTa80YFoPwkiIj2Kn4j3uaSIOjtgqWOE/s4F1X5vzi/lJFWq+t0+K9jfl+GEQOYgU4jOK4QjaERLvcSzt0uUDg79UFWHHvZkGFT5SV4Ycg5UAThpvMzFp7ANOrKQ0/SWfGsKjegEiFDO5YxFbIAIyTGEYq3PoFcC9JIU7JMEEy0OGg2eFKWtd02YO2Q+7cRoFWBupIGUmw7yyy083EgtGFff94FM6RMHrhWs+eTpQLK2FqLhJ4X1iej/9/FFC7u+EOQGOTKvNKYgW0+HKiac0fEeVWZ4tNYneWP2MV+b3Q17fNvileuGIrlz1X+a59+RVO X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9df7d926-9ecb-4372-63bb-08dc9643b98b X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2024 00:54:40.0985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aC+gBnmSsXydmQ0/aha6IR2B9KAibucjgnN+D0mr2yfnfMML9YSULxSlGPCTecII+jL/L2aHa6trh1ADAovo6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7071 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_175453_330811_B17911A9 X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the check in __gup_device_huge() is redundant. Remove it Signed-off-by: Alistair Popple Reviewed-by: Jason Gunthorpe Acked-by: David Hildenbrand Acked-by: Dan Williams --- mm/gup.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index ca0f5ce..669583e 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -3044,11 +3044,6 @@ static int gup_fast_devmap_leaf(unsigned long pfn, unsigned long addr, break; } - if (!(flags & FOLL_PCI_P2PDMA) && is_pci_p2pdma_page(page)) { - gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages); - break; - } - folio = try_grab_folio(page, 1, flags); if (!folio) { gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages);