diff mbox

[v3,1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

Message ID e24c7d64dbce490fbeaa0f44b56027d0@rwthex-s1-b.rwth-ad.de (mailing list archive)
State New, archived
Headers show

Commit Message

christopher.spinrath@rwth-aachen.de June 12, 2016, 11:24 p.m. UTC 
From: Valentin Raevsky <valentin@compulab.co.il>

The current ldo settings of the cm-fx6 do not allow 1.2GHz cpu
frequency. At this frequency the module behaves unstable.

But the imx6q fuse indicates that 1.2GHz operation is possible.
Hence, remove the 1.2GHz operation point in the device tree.

Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
[christopher.spinrath@rwth-aachen.de: enhance commit message, adjust
 remaining operation points to match the ones in imx6q.dtsi and add
 a comment in the device tree]
Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
---

Notes:
    Changes since v2:
     - fix comment style
     - add Fabio's Reviewed-By
    
    Changes since v1:
     - Enhance commit message to explain that we cannot rely on the imx6q
       fuse to restrict the frequency
     - put the same information into a comment in the device tree
     - fix the remaining operation points to match the ones given in
       imx6q.dtsi

 arch/arm/boot/dts/imx6q-cm-fx6.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Shawn Guo June 16, 2016, 1:35 a.m. UTC | #1 
On Mon, Jun 13, 2016 at 01:24:55AM +0200, christopher.spinrath@rwth-aachen.de wrote:
> From: Valentin Raevsky <valentin@compulab.co.il>
> 
> The current ldo settings of the cm-fx6 do not allow 1.2GHz cpu
> frequency. At this frequency the module behaves unstable.
> 
> But the imx6q fuse indicates that 1.2GHz operation is possible.
> Hence, remove the 1.2GHz operation point in the device tree.
> 
> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
> [christopher.spinrath@rwth-aachen.de: enhance commit message, adjust
>  remaining operation points to match the ones in imx6q.dtsi and add
>  a comment in the device tree]
> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
index 6d8d5e9..b5de7e6 100644
--- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
+++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
@@ -91,6 +91,28 @@ 
 	};
 };
 
+&cpu0 {
+	/*
+	 * Although the imx6q fuse indicates that 1.2GHz operation is possible,
+	 * the module behaves unstable at this frequency. Hence, remove the
+	 * 1.2GHz operation point here.
+	 */
+	operating-points = <
+		/* kHz	uV */
+		996000	1250000
+		852000	1250000
+		792000	1175000
+		396000	975000
+	>;
+	fsl,soc-operating-points = <
+		/* ARM kHz	SOC-PU uV */
+		996000		1250000
+		852000		1250000
+		792000		1175000
+		396000		1175000
+	>;
+};
+
 &ecspi1 {
 	fsl,spi-num-chipselects = <2>;
 	cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio3 19 GPIO_ACTIVE_HIGH>;