diff mbox series

[-next,008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;

Message ID e26a22c41c72290be469229f578e80c9e6dae5ed.1583896348.git.joe@perches.com
State New, archived
Headers show
Series None | expand

Commit Message

Joe Perches March 11, 2020, 4:51 a.m. UTC
Convert the various uses of fallthrough comments to fallthrough;

Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/arm/mach-ep93xx/crunch.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alexander Sverdlin March 13, 2020, 7:26 p.m. UTC | #1
Hello Joe,

On Tue, 10 Mar 2020 21:51:22 -0700
Joe Perches <joe@perches.com> wrote:

> Convert the various uses of fallthrough comments to fallthrough;
> 
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/

I think the patch is OK, but the automatically-generated first
commit message line has a room for improvement.

But, as I understood, it has chances to be re-sent as one patch for
all files.

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/arm/mach-ep93xx/crunch.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-ep93xx/crunch.c b/arch/arm/mach-ep93xx/crunch.c
> index 1c05c5b..f02e978 100644
> --- a/arch/arm/mach-ep93xx/crunch.c
> +++ b/arch/arm/mach-ep93xx/crunch.c
> @@ -49,8 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
>  		 * FALLTHROUGH: Ensure we don't try to overwrite our newly
>  		 * initialised state information on the first fault.
>  		 */
> -		/* Fall through */
> -
> +		fallthrough;
>  	case THREAD_NOTIFY_EXIT:
>  		crunch_task_release(thread);
>  		break;
diff mbox series

Patch

diff --git a/arch/arm/mach-ep93xx/crunch.c b/arch/arm/mach-ep93xx/crunch.c
index 1c05c5b..f02e978 100644
--- a/arch/arm/mach-ep93xx/crunch.c
+++ b/arch/arm/mach-ep93xx/crunch.c
@@ -49,8 +49,7 @@  static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
 		 * FALLTHROUGH: Ensure we don't try to overwrite our newly
 		 * initialised state information on the first fault.
 		 */
-		/* Fall through */
-
+		fallthrough;
 	case THREAD_NOTIFY_EXIT:
 		crunch_task_release(thread);
 		break;