| Message ID | e479b745-f2da-b92e-02c3-f5ce27fc53ad@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 4 Jun 2017, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 4 Jun 2017 21:21:20 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > ERROR: do not use assignment in if condition > > Thus fix the affected source code place. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > arch/arm/xen/p2m.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c > index f5f74ac637b9..e71eefa2e427 100644 > --- a/arch/arm/xen/p2m.c > +++ b/arch/arm/xen/p2m.c > @@ -153,7 +153,8 @@ bool __set_phys_to_machine_multi(unsigned long pfn, > p2m_entry->mfn = mfn; > > write_lock_irqsave(&p2m_lock, irqflags); > - if ((rc = xen_add_phys_to_mach_entry(p2m_entry)) < 0) { > + rc = xen_add_phys_to_mach_entry(p2m_entry); > + if (rc < 0) { > write_unlock_irqrestore(&p2m_lock, irqflags); > return false; > } > -- > 2.13.0 >
diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c index f5f74ac637b9..e71eefa2e427 100644 --- a/arch/arm/xen/p2m.c +++ b/arch/arm/xen/p2m.c @@ -153,7 +153,8 @@ bool __set_phys_to_machine_multi(unsigned long pfn, p2m_entry->mfn = mfn; write_lock_irqsave(&p2m_lock, irqflags); - if ((rc = xen_add_phys_to_mach_entry(p2m_entry)) < 0) { + rc = xen_add_phys_to_mach_entry(p2m_entry); + if (rc < 0) { write_unlock_irqrestore(&p2m_lock, irqflags); return false; }