From patchwork Sat Feb 8 09:02:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 13966337 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A3A3C02198 for ; Sat, 8 Feb 2025 09:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=75j6z8d7awpg/9zZQerCAsdb2+7Bs9ccRLOecVKM6cY=; b=YG8eHctjIFljaL/AFA8Hiby5BD /d4kKU3Er22xLet67Lbx/7jURhObdcQ5kLfl+vK2Z5lunXDTinTClL6oEkuQLkrjhWnXJlEBE7aWO seYGHt3+Lp8ZyKPNqil1XVZhLYBqfJerrTVDWz6eUg/0pTsJt/v4duJJPhUOKarofinhctU3TEQlV EEt9T0E+0Kwgkg6xtz+bGTlNfwtffHQLbJMQnSs2tixCYZ7hXA+Shx5Q0uCMfypXAtpy+CgLSBLEi cacYuxLJy2o3lz2TkjxzDVjzbD3hD9UAp0vqF09uLPD8CoKu4usoKHv1xTAAwjlQTpwTeJr0HUIYS JsbDwp7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tgh24-0000000CbmO-0T4m; Sat, 08 Feb 2025 09:21:48 +0000 Received: from mail-dm6nam04on2062d.outbound.protection.outlook.com ([2a01:111:f403:2409::62d] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tggka-0000000CY1n-1yDL for linux-arm-kernel@lists.infradead.org; Sat, 08 Feb 2025 09:03:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wsyphMFMNuy9d2v8qsZBT7nIfMQAYJAWQVGTq/njq9XfgohuetDq3+jh1DoBPocwysuaH8CSb4ZaJac2/ZwYWXzG2YzykiHgRJMkb46514JOGrzSGBGqPQEtqwaJMRxvxvhUuIPXHN9K+y0fIGxXPw3DBdWp4nIayPp+yt4I6p8r10FSSxY1f+jT905Yij6N5vltri372WzeuIvcW8vmEmss4odICKyTe5IDzPJOnH86U1B8VZhj27s6BBxLugtpYJpBpmrTFPLLlD2N2FLGpzC7ZZakk13ZpofUIGIpf3tbobYJTq4bxN91ubDr5d/nJ1vpVSiWQjPVpjV+8L5gtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=75j6z8d7awpg/9zZQerCAsdb2+7Bs9ccRLOecVKM6cY=; b=uSvVENiw2Z00zc5IkDnDd/6Hc7vuD0jPEAo7HS4ZCU8x0pgfBeqxnAi+ed+woTxU7fwaNRubsm3+vsgHTsywC/n/uEUfzvLOaMpFdEcQ2uuurYwQ/VlwNWzs5C59lr41UkD3WoZc8jLHhv4smZ4+ToN5c9eqh4qUqmPStep0w9U3eASHa/05Rh271pxvgCbJU9FCP5UaOio8+YLp42+l+k+FcuqmrdGQmBOrTwXaD7Dn6FUWSwY0wD72pVE56JaHVhdki4pTgq++hB1cv2/t7dPzSqnGZpI/TeEPL9tRPpfZADf+m2k1M0vk4UJbzD0DKqVDIWueSufDoE4xtU5nMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=75j6z8d7awpg/9zZQerCAsdb2+7Bs9ccRLOecVKM6cY=; b=M3K2BLqWfZp3Tc6s2kMb3EFP4MZbsFCqupCa2Sd8IFp51K/WqwnFOeeGFndsDwk96PbhlY+JO04T+9EZkaazIb/uEcEy8J+1Sr1qEOHsRZKp8W0CI4kDNCF1YhJkW3mEx/pnij81U8qrVVKB3/Y7q3YTvd0+HsFKuHA+o37pKI/rMw/qKzUVwfNBndPpM5zjrp4irVgUxsAG9dAOz7YJ6E0xp0fzvH9waQMQ8UN6dk16nI5IXPWsv1m1ACdNtT2N2Sko+fRPKO03YrXp+JCfhjAfuag/Vt3MCHbHTj5HokN6mpKvOmGlKMnMkd9WNHVWzy7iVXOHEcGx+kla15PVEQ== Received: from MN2PR18CA0009.namprd18.prod.outlook.com (2603:10b6:208:23c::14) by DS7PR12MB8231.namprd12.prod.outlook.com (2603:10b6:8:db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.12; Sat, 8 Feb 2025 09:03:32 +0000 Received: from BN1PEPF0000468A.namprd05.prod.outlook.com (2603:10b6:208:23c:cafe::4e) by MN2PR18CA0009.outlook.office365.com (2603:10b6:208:23c::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.29 via Frontend Transport; Sat, 8 Feb 2025 09:03:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN1PEPF0000468A.mail.protection.outlook.com (10.167.243.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.14 via Frontend Transport; Sat, 8 Feb 2025 09:03:31 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 8 Feb 2025 01:03:17 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sat, 8 Feb 2025 01:03:17 -0800 Received: from Asurada-Nvidia.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sat, 8 Feb 2025 01:03:16 -0800 From: Nicolin Chen To: , , , CC: , , , , , , , , , , , , , Subject: [PATCH v1 09/13] iommufd: Pass in idev to iopt_table_enforce_dev_resv_regions Date: Sat, 8 Feb 2025 01:02:42 -0800 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF0000468A:EE_|DS7PR12MB8231:EE_ X-MS-Office365-Filtering-Correlation-Id: 023d1201-4c79-4ccd-4ab8-08dd481f75eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: PtKyFKWFV60Fgo8kZAaM1Qn08j4mjsrpde9xr9+bTrEXUDCon6UXLUZ8S6EjATqyGdOuIHPOLjdsW1AyRfZ0pgMiV9WJY57iKlrg/mqMdhiBTG1sxSLsilkvlWlVcAACFVOMmC9qHCAk1fCZl1NT2wpY3CkmgwYYQhEelQD7plgLsbKoZKJLY8ukXymfaU5deyuakLV1Z1fJ+v8RuBIGyDE0u1NRoRC79evSJX1JzBcfk5nqzKu7eQeXWNUKkVNQ6VP+yXtO4IgHR7b0MUhKRUc/GW4U+2MrtJbpVWzmtHWLevtbHUTxq/cfAp1v0ddevlhcnhV1UE+//AAkqa3i/fC11hGPJKEXEzuPjv6XKpm0wPftjYbrOCC2QzzdaLFLSxIojhAcTGaJKThKrrGHiM5C7Eby9F4LrUoiqIVxR3tPpdhm9usL9jGz+Wm2Q8E9SPe2eAV0KD7BSMJTRtyXpM07Do2myJSangch3JzmGg+bwGrq+7ktCqXaqFsR39xtENLmHT47K/I57OHXnudj5JOG6psxmIbe4NgLdSflYOMC4fdY1hyIOpuIW0KNYm/VKZaAZC1JCzD6c1cH0WxuN1xM0zti10l1pykG/cO51LIsvph2aeeComZ4gFyIkwKgwoYPCFyTgwtxhh1zXfK8wIzN+lJEn51ehlmCrIIMzenUxqNEkUA029gJnwTy98KvFy8i3xuGLO7nwzhbeUbjjg4OEyeQnfTWtGB0IBxp2g3F5NNWsq/6jD/bDYna3Nqc5jKNpcxRJ+PyiQia7fJUlNdVn46r2f6Ymi2LbCWLKlXY5tccOawSVXb2o5f4Dz5pGIVudvSV4RMUE/C/hLuJhsznwODoXLcUoNfZ25YflgxQXpg+mW+r/kUWMU8nCxeCSfAP+NGbJwIop2hcQ57B8g9NbSQIYRXr0PQ6hwOgR2YDRO+nRVvYFGqW46ZIEMVG2GfVLMzyce//jo6BXqokq5nhM72R7QKW/o73kqX0noPwrsCqDtufXmIVg5TYkWdFWCsr0w9qaicbpH4+V+Q33e8ZU73zfJYwyj4aWE+kExXXjomMJ5WYc2i5m5pfeDck1zeMM3EqsD0jAaGcKF+LEpvl22hq8Bh0puHr0syYDnw7x25M0Ftg9ujsBuLFVp23WY0qu73fgR/5IgpdWKkk/FbxiNYjoeJtyGFPLTaqwDO/tvJ8jO4PnXsHx7LYu7aJ3dTtfxzdqz7JFQc1N/bwnln8fozpKAQTsh2p3iwdFUsuAiqEUH2O8ngjF3U67sWSqgLcFm3soh/aVqN990Dz2yKhm1NCmG5ACezZViKYcAt2o9KdMYL/jfyEJ9at6DFNNpEr+ml6cRHXwckjlhBrbKH8CI08rc/PwhDz/aXs54qtrfQuVeZwHHbvOb0JFhUERmvsP/5MRkOeqrhHT7c+iLj88gK3nwMIz3FJKMNen402G3z/3/hoG4UOloKn9OTJ+3FiOa8q6f4iYdygFmGeCXNtYI2TqXI9L1XdnURT0aY= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2025 09:03:31.3831 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 023d1201-4c79-4ccd-4ab8-08dd481f75eb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF0000468A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8231 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250208_010344_512989_FB9F194D X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The iopt_table_enforce_dev_resv_regions needs to access the sw_msi_start and sw_msi_size stored in the idev, set by user space. So, pass in idev pointer instead. Signed-off-by: Nicolin Chen --- drivers/iommu/iommufd/iommufd_private.h | 2 +- drivers/iommu/iommufd/device.c | 5 ++--- drivers/iommu/iommufd/io_pagetable.c | 3 ++- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommufd/iommufd_private.h index c0df549c7d34..7a9cc6e61152 100644 --- a/drivers/iommu/iommufd/iommufd_private.h +++ b/drivers/iommu/iommufd/iommufd_private.h @@ -115,7 +115,7 @@ int iopt_table_add_domain(struct io_pagetable *iopt, void iopt_table_remove_domain(struct io_pagetable *iopt, struct iommu_domain *domain); int iopt_table_enforce_dev_resv_regions(struct io_pagetable *iopt, - struct device *dev, + struct iommufd_device *idev, phys_addr_t *sw_msi_start); int iopt_set_allow_iova(struct io_pagetable *iopt, struct rb_root_cached *allowed_iova); diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c index 882cc51a3feb..5ecd96c04e89 100644 --- a/drivers/iommu/iommufd/device.c +++ b/drivers/iommu/iommufd/device.c @@ -452,8 +452,7 @@ iommufd_device_attach_reserved_iova(struct iommufd_device *idev, lockdep_assert_held(&idev->igroup->lock); - rc = iopt_table_enforce_dev_resv_regions(&hwpt_paging->ioas->iopt, - idev->dev, + rc = iopt_table_enforce_dev_resv_regions(&hwpt_paging->ioas->iopt, idev, &idev->sw_msi_start); if (rc) return rc; @@ -664,7 +663,7 @@ iommufd_device_do_replace_reserved_iova(struct iommufd_device *idev, if (!old_hwpt_paging || hwpt_paging->ioas != old_hwpt_paging->ioas) { list_for_each_entry(cur, &igroup->device_list, group_item) { rc = iopt_table_enforce_dev_resv_regions( - &hwpt_paging->ioas->iopt, cur->dev, NULL); + &hwpt_paging->ioas->iopt, cur, NULL); if (rc) goto err_unresv; } diff --git a/drivers/iommu/iommufd/io_pagetable.c b/drivers/iommu/iommufd/io_pagetable.c index 8a790e597e12..441da0314a54 100644 --- a/drivers/iommu/iommufd/io_pagetable.c +++ b/drivers/iommu/iommufd/io_pagetable.c @@ -1423,9 +1423,10 @@ void iopt_remove_access(struct io_pagetable *iopt, /* Narrow the valid_iova_itree to include reserved ranges from a device. */ int iopt_table_enforce_dev_resv_regions(struct io_pagetable *iopt, - struct device *dev, + struct iommufd_device *idev, phys_addr_t *sw_msi_start) { + struct device *dev = idev->dev; struct iommu_resv_region *resv; LIST_HEAD(resv_regions); unsigned int num_hw_msi = 0;