| Message ID | f148d823acfb3326a115bd49a0eed60f2345f909.1731844995.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: samsung: Fix irq handling if an error occurs in exynos_irq_demux_eint16_31() | expand |
On Sun, 2024-11-17 at 13:03 +0100, Christophe JAILLET wrote: > chained_irq_enter(() should be paired with a corresponding > chained_irq_exit(). > > Here, if clk_enable() fails, a early return occurs and chained_irq_exit() > is not called. > > Add a new label and a goto for fix it. > > Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Compile tested only. > > Review with care, irq handling is sometimes tricky... Well spotted, thanks. It looks like there is a similar problem in exynos_irq_request_resources() in same file. It should likely call gpiochip_unlock_as_irq() if clk_enable() failed. Care to fix that as well? That said, Reviewed-by: André Draszik <andre.draszik@linaro.org> Cheers, Andre'
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index b79c211c0374..ac6dc22b37c9 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -636,7 +636,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc) if (clk_enable(b->drvdata->pclk)) { dev_err(b->gpio_chip.parent, "unable to enable clock for pending IRQs\n"); - return; + goto out; } } @@ -652,6 +652,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc) if (eintd->nr_banks) clk_disable(eintd->banks[0]->drvdata->pclk); +out: chained_irq_exit(chip, desc); }
chained_irq_enter(() should be paired with a corresponding chained_irq_exit(). Here, if clk_enable() fails, a early return occurs and chained_irq_exit() is not called. Add a new label and a goto for fix it. Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only. Review with care, irq handling is sometimes tricky... --- drivers/pinctrl/samsung/pinctrl-exynos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)