diff mbox series

irqchip: APPLE_AIC should depend on ARCH_APPLE

Message ID f37e8daea37d50651d2164b0b3dad90780188548.1618316398.git.geert+renesas@glider.be (mailing list archive)
State New
Headers show
Series irqchip: APPLE_AIC should depend on ARCH_APPLE | expand

Commit Message

Geert Uytterhoeven April 13, 2021, 12:21 p.m. UTC
The Apple Interrupt Controller is only present on Apple Silicon SoCs.
Hence add a dependency on ARCH_APPLE, to prevent asking the user about
this driver when configuring a kernel without Apple Silicon SoC support.

Drop the default, as ARCH_APPLE already selects APPLE_AIC.

Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple Interrupt Controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hector Martin April 27, 2021, 11:07 a.m. UTC | #1
On 13/04/2021 21.21, Geert Uytterhoeven wrote:
> The Apple Interrupt Controller is only present on Apple Silicon SoCs.
> Hence add a dependency on ARCH_APPLE, to prevent asking the user about
> this driver when configuring a kernel without Apple Silicon SoC support.
> 
> Drop the default, as ARCH_APPLE already selects APPLE_AIC.
> 
> Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple Interrupt Controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/irqchip/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Makes sense. Thanks!

Acked-by: Hector Martin <marcan@marcan.st>
Marc Zyngier April 27, 2021, 12:36 p.m. UTC | #2
On 2021-04-27 12:07, Hector Martin wrote:
> On 13/04/2021 21.21, Geert Uytterhoeven wrote:
>> The Apple Interrupt Controller is only present on Apple Silicon SoCs.
>> Hence add a dependency on ARCH_APPLE, to prevent asking the user about
>> this driver when configuring a kernel without Apple Silicon SoC 
>> support.
>> 
>> Drop the default, as ARCH_APPLE already selects APPLE_AIC.
>> 
>> Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple 
>> Interrupt Controller")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>>   drivers/irqchip/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
> 
> Makes sense. Thanks!
> 
> Acked-by: Hector Martin <marcan@marcan.st>

I'll pick this up post -rc1.

Thanks,

         M.
diff mbox series

Patch

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index d3a14f304ec80caa..b165b3285d9b0555 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -580,7 +580,7 @@  config MST_IRQ
 config APPLE_AIC
 	bool "Apple Interrupt Controller (AIC)"
 	depends on ARM64
-	default ARCH_APPLE
+	depends on ARCH_APPLE || COMPILE_TEST
 	help
 	  Support for the Apple Interrupt Controller found on Apple Silicon SoCs,
 	  such as the M1.