From patchwork Fri Mar 23 03:44:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryder Lee X-Patchwork-Id: 10302643 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9FF40600F6 for ; Fri, 23 Mar 2018 03:44:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E1F128B6B for ; Fri, 23 Mar 2018 03:44:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8117428B70; Fri, 23 Mar 2018 03:44:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3F40B28B6B for ; Fri, 23 Mar 2018 03:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KN4aBKrj4yXpFR7JNt2IhILzkeekOXC6WBoaLY8Nwdo=; b=f+ywh4ZBvCsA9e idsZ3P70KKnEVIJaTLvbqzP8dvdly+BShpdTWSAcC9tBFaWK4F7Ue6HUqthDYPDFkI8iIR9FXoHAY +9W4anv/tWpjKQ2nqzRpm3HuvBWSKDiDZfPkWl+2KeXwCyEF8PmDPaJEzyU4RPGJju8A/h0aoRwj2 HCWOBkLHZO83XoO8o1HQjZFigh3WvMCaX9oJ9Dvadmcddf5VuwLtnDljfu06P0N6ZZeWg325ckcsK 7i5Swe/aW5+xz9y9wLOLvrX/7k0en2lPoB809IjXpLLprIGs28+ihLFT91cuR/tya/gE4lRRxmnKH TZlMcn3+STWwZxDNiSRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezDdJ-0007k8-4B; Fri, 23 Mar 2018 03:44:49 +0000 Received: from [210.61.82.184] (helo=mailgw02.mediatek.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezDdC-0007hN-P5; Fri, 23 Mar 2018 03:44:44 +0000 X-UUID: 0b54a1ac820d4c9d8b1c652e693b4735-20180323 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1988292266; Fri, 23 Mar 2018 11:44:18 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 23 Mar 2018 11:44:15 +0800 Received: from mtkslt306.mediatek.inc (10.21.14.136) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 23 Mar 2018 11:44:15 +0800 From: Ryder Lee To: Mauro Carvalho Chehab , Hans Verkuil Subject: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() Date: Fri, 23 Mar 2018 11:44:13 +0800 Message-ID: X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.5042-8.2.9001-23736.003 X-TM-AS-Result: No-2.867500-8.000000-10 X-TMASE-MatchedRID: iyOaUzKo3m/MxeM2fhfB7kyQ5fRSh265H8fXhwPLN7GjxYyRBa/qJQJj 6WxgWJYb5MIx11wv+CPGVuWouVipcjQJ8LiNAx5aJT7qgeqiOg9523AyrCX8wnfLsXBEMK4+Z/I B5jAhZAVBBpB9i3UBwlkf0TYN3mgxzMo/u4o0CcFuB+4uIp4zDvDsnHBTQS9kyoRE4tv/7I7j/Q m+fSvAAma0vgPD7M1v1PYfTfPNTUk= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.867500-8.000000 X-TMASE-Version: SMEX-12.5.0.5042-8.2.9001-23736.003 X-TMASE-POSTMAN: 2-d; X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180322_204443_005147_7BFA59DF X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bin Liu , Ryder Lee , Rick Chang , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The error return value should be fixed as it may return EPROBE_DEFER. Cc: Rick Chang Cc: Bin Liu Signed-off-by: Ryder Lee Reviewed-by: Matthias Brugger Acked-by: Rick Chang --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c index 226f908..af17aaa 100644 --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg) jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec"); if (IS_ERR(jpeg->clk_jdec)) - return -EINVAL; + return PTR_ERR(jpeg->clk_jdec); jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi"); if (IS_ERR(jpeg->clk_jdec_smi)) - return -EINVAL; + return PTR_ERR(jpeg->clk_jdec_smi); return 0; }