| Message ID | fb0a22fd12f6a1d69e4e66aafba5b84859d4a60c.1606837822.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | firmware: xilinx: Clean up series | expand |
On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote: > Fix parameters alignment reported by checkpatch --strict. Please use a newer checkpatch as the 80 column warning isn't enforced quite the same way. > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h [] > @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) > } > > > static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset, > - const enum zynqmp_pm_reset_action assert_flag) > + const enum zynqmp_pm_reset_action > + assert_flag) I think these changes aren't very good as it separates the type from the variable name. > @@ -490,9 +491,10 @@ static inline int zynqmp_pm_release_node(const u32 node) > } > > > static inline int zynqmp_pm_set_requirement(const u32 node, > - const u32 capabilities, > - const u32 qos, > - const enum zynqmp_pm_request_ack ack) > + const u32 capabilities, > + const u32 qos, > + const enum zynqmp_pm_request_ack > + ack)
On 01. 12. 20 20:42, Joe Perches wrote: > On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote: >> Fix parameters alignment reported by checkpatch --strict. > > Please use a newer checkpatch as the 80 column warning > isn't enforced quite the same way. I was using it but saw 80 lines breakage in editor that's why I put it there. > >> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > [] >> @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) >> } >> >> >> static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset, >> - const enum zynqmp_pm_reset_action assert_flag) >> + const enum zynqmp_pm_reset_action >> + assert_flag) > > I think these changes aren't very good as it separates > the type from the variable name. I have retest it and I can't see any warning when they are on the same line. Will send v2 with fixing this. Thanks, Michal
diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 0e7e72650ed3..c5cdc68e431f 100644 --- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) } static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset, - const enum zynqmp_pm_reset_action assert_flag) + const enum zynqmp_pm_reset_action + assert_flag) { return -ENODEV; } @@ -490,9 +491,10 @@ static inline int zynqmp_pm_release_node(const u32 node) } static inline int zynqmp_pm_set_requirement(const u32 node, - const u32 capabilities, - const u32 qos, - const enum zynqmp_pm_request_ack ack) + const u32 capabilities, + const u32 qos, + const enum zynqmp_pm_request_ack + ack) { return -ENODEV; }
Fix parameters alignment reported by checkpatch --strict. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- include/linux/firmware/xlnx-zynqmp.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)