From patchwork Tue Apr 23 08:06:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639584 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9820EC4345F for ; Tue, 23 Apr 2024 08:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0XkqIKYgGnOYNETG1arMRaDF3x/A71a7C9/2AVTLjw0=; b=mR0svEeIgFa8wM zLgApGvkr/6TqJHM+YZp8zJfppSnTkqvARY90KP0JakLPKAf0091Fu9T/tvGSGwwMEG10QBvB1psM ZTbUzsv0PhD+SOqu8VH+JyOa/iezDDWiPEgDzDZNiDnWMC6+CL0yoo6EfMKV3CqbUjuoehPqu7QK/ aKyHVKe8STsC7HoC1LJ64ki8qUhQvVWHKYRTtJKXdPRwuIq1S5JHTyppIMtKgk8jZPETqs0fcGTE3 uSzpft7hI6vKKSyq7GGrcoCKI4kMSr/jdAdIGxuQPPe5zRiNv6p68+VlhNBQavbnkOnhL9pwyt0Zg +Grey4oBWjyqU7UILmJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBZ-0000000GOyU-05A9; Tue, 23 Apr 2024 08:07:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBS-0000000GOwL-07ru for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-000357-H1; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBK-00Dq1V-BW; Tue, 23 Apr 2024 10:07:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBK-006nfr-0r; Tue, 23 Apr 2024 10:07:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Sudeep Holla , Anshuman Khandual Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 2/5] coresight: debug: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:06:59 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2147; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=W9VKAaqsnaq3Vzg1avi1vxx/uhnYRc+z2zJhxctEk/s=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wnOch0b5DoBlz9fvHM0eRISM3BWq6ssrFEe e8fktKx6EOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsJwAKCRCPgPtYfRL+ Thn3CACNiWaz06CUaJB8dBBmMRIcMsRDvNH8Mwuj3zmBlR01fInJWdtcQqUqv5uWkFWNwIXsA8x ihxjnCHw18dNuPuq96HWP9dAOzMoS4rWeF01kW4OdKi+fBIzrxZwZDarMwUmB6k27tO8+uLTtsV 0p8bUyd5cN7Ex+fG64GLj9LRF+3J7fmunPRdRyFPoXeOOJh1k4VcYxDqnKRwa7QUr/fsQeL7sUf 3VMbasoA2PF1iC6DaabCiu48IOFUEr8uiYq78qlPSYi0g1aGPC0iU2YqI21NMd1K1yfcxfxBYnM bjWakwnecWKtm4AmLfxLXpxkHDFwHDVEopmJhZx633Z04vQP X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010722_147884_FEFA4E35 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 965edae4e6a2 ("coresight: debug: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-cpu-debug.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c index 3263fc86cb66..75962dae9aa1 100644 --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c @@ -716,18 +716,17 @@ static int debug_platform_probe(struct platform_device *pdev) return ret; } -static int debug_platform_remove(struct platform_device *pdev) +static void debug_platform_remove(struct platform_device *pdev) { struct debug_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __debug_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_ACPI @@ -764,7 +763,7 @@ static const struct dev_pm_ops debug_dev_pm_ops = { static struct platform_driver debug_platform_driver = { .probe = debug_platform_probe, - .remove = debug_platform_remove, + .remove_new = debug_platform_remove, .driver = { .name = "coresight-debug-platform", .acpi_match_table = ACPI_PTR(debug_platform_ids),