| Message ID | fbe464e8bd8039463c4984835286b19060509f82.1511065797.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19/11/2017 at 10:04:01 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid. > changes in v3: > Return -ENODEV instead of ssc->irq. The patch is not doing what you claim here. > > drivers/misc/atmel-ssc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c > index b2a0340..2ec0f9e 100644 > --- a/drivers/misc/atmel-ssc.c > +++ b/drivers/misc/atmel-ssc.c > @@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev) > clk_disable_unprepare(ssc->clk); > > ssc->irq = platform_get_irq(pdev, 0); > - if (!ssc->irq) { > + if (ssc->irq <= 0) { > dev_dbg(&pdev->dev, "could not get irq\n"); > return -ENXIO; > } > -- > 2.7.4 >
On 19/11/2017 at 05:34, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid. > changes in v3: > Return -ENODEV instead of ssc->irq. Okay, I didn't see this v3 before commenting on v2... > > drivers/misc/atmel-ssc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c > index b2a0340..2ec0f9e 100644 > --- a/drivers/misc/atmel-ssc.c > +++ b/drivers/misc/atmel-ssc.c > @@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev) > clk_disable_unprepare(ssc->clk); > > ssc->irq = platform_get_irq(pdev, 0); > - if (!ssc->irq) { > + if (ssc->irq <= 0) { > dev_dbg(&pdev->dev, "could not get irq\n"); > return -ENXIO; > } >
diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index b2a0340..2ec0f9e 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev) clk_disable_unprepare(ssc->clk); ssc->irq = platform_get_irq(pdev, 0); - if (!ssc->irq) { + if (ssc->irq <= 0) { dev_dbg(&pdev->dev, "could not get irq\n"); return -ENXIO; }
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid. changes in v3: Return -ENODEV instead of ssc->irq. drivers/misc/atmel-ssc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)