From patchwork Mon Oct 15 13:27:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 10641883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8429115E2 for ; Mon, 15 Oct 2018 13:48:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54B7C291F0 for ; Mon, 15 Oct 2018 13:48:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4622C29202; Mon, 15 Oct 2018 13:48:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D7EF2291F0 for ; Mon, 15 Oct 2018 13:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uOTlYWWS6LeziqLmFMvZwHRX8GlNxIEJlpdXN09+X7I=; b=d9dN3hlUjlA/SX pN7Cj+IyVGQpblaCSypiXNhcZUPNzgaLv5iQ2Ghl0dViuT7cxAIeAzugo4kY0WK42pm36VWeFLQdQ HBKxv6U6XG0k7w7l6ZLuZhGpdeXsYWEbrY5HJJbC9TXggjLouuKyCUAQppeREoQZwhF2TPihWbVUn Z59Xd8wsIKNjNj/CYhFUKeNMEEIA3CETYXbF0Iw9IhiJOmyYFG9ZwqMgzbxfxn3XUJAEmzMeHreB+ oCgIalMjgZ5ZPAT72+7jVAgfys+cJ3RfiFoWE/WBJw+NOjvT1GsWqbrhqZtfC7ZqKtWYwt8BmhiTC cCgU51maqyjoj+Ws2mMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC3EB-0003UK-Nj; Mon, 15 Oct 2018 13:48:11 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC3D2-0002wi-DM for linux-arm-kernel@bombadil.infradead.org; Mon, 15 Oct 2018 13:47:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=MIME-Version:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NQBRp7vsJTa6ayPyk3B/Z980+orKSk7Ted81mJ1JQd0=; b=VVcVh4QufCCKK+3z6mSG5GwJqw pH4XubJvPeNYia4CQFk88aiUxb4cyLSSgCLMoP1yCYU3hazKZhKp9EjRMXT6Nq1OEp4sqSJ1C7UQ/ LfJZHfhbypjtD5scokB7JmSPuyvHW9IVAwMmUlRSMkWcRsVa7f8YFz44svqytmm2I6YjWFFUwoI0a XqXvQ/dMVR55dy9abrdXjGLalS7t1kRDj9+zFjcUndxMHPdcbe3tSsg/w5X9NgBPJTpVR0SlnXDEG 8MZDEBvRPVp7r7Mar23roYLmKIK2yryfzQvwBi05v+c+cZZ9ig3+6jp2v9BaVURg+AyueWffyumf0 /bjz2xzQ==; Received: from mail-he1eur01on0068.outbound.protection.outlook.com ([104.47.0.68] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC2uX-0008Lw-Gn for linux-arm-kernel@lists.infradead.org; Mon, 15 Oct 2018 13:27:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQBRp7vsJTa6ayPyk3B/Z980+orKSk7Ted81mJ1JQd0=; b=OJYoaT3zeEMYMOScRNsdegWl24kQhxwxxNvhSE+1OmgYKIln2yGn/223v1kTHezKDhp7Ue7jhdtC5MwpSij1jd5TrfDcGCHZKnU923p0Ux+M5cEEpthDNA6HkF2s2kchme7St9dOqwztse919ZUk1yPhliOLFKasinqt5/A/7KA= Received: from AM0PR04MB4290.eurprd04.prod.outlook.com (52.134.126.145) by AM0PR04MB4948.eurprd04.prod.outlook.com (20.176.215.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.26; Mon, 15 Oct 2018 13:27:37 +0000 Received: from AM0PR04MB4290.eurprd04.prod.outlook.com ([fe80::3836:6416:4ebd:34ef]) by AM0PR04MB4290.eurprd04.prod.outlook.com ([fe80::3836:6416:4ebd:34ef%3]) with mapi id 15.20.1228.027; Mon, 15 Oct 2018 13:27:37 +0000 From: Leonard Crestez To: Shawn Guo , Fabio Estevam Subject: [PATCH v2 2/4] crypto: mxs-dcp - Add support for dcp clk Thread-Topic: [PATCH v2 2/4] crypto: mxs-dcp - Add support for dcp clk Thread-Index: AQHUZIrWKQehjSTCMkafThAO20dZjw== Date: Mon, 15 Oct 2018 13:27:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [95.76.156.53] x-mailer: git-send-email 2.17.1 x-clientproxiedby: AM6PR0502CA0071.eurprd05.prod.outlook.com (2603:10a6:20b:56::48) To AM0PR04MB4290.eurprd04.prod.outlook.com (2603:10a6:208:67::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR04MB4948; 6:BCOhHOBenUV5CrQln/ymC6W9imo1hLm046bGJtvz2jq22kKdRk7qspUfn6AFsaOlH2x1swhs/VrS9G/OwYPzpBJ9pWvkf782O1uQLPlqSWMVOMGK+JBj9r2P/xdc/Wz2kuqAN3aI4Utmw0RYCgk41PYlHW01ZGt27ZEgFqv0giEzo2quY0p862dbjhCoUSMd8zoWIzSJpudySfgoGjblpZvjXqqBECj2DFyLarxinDRkvFueS+V+QoKxpLfff4o/mYS7UCObkZSxaZFA9AsoPwqTBkOQTz+ryjZvem4bLfayiwm+85wIHIVkFGVuIDMbXRpxx4T5LLGLN7YLoyumgY0Lp2/wqo4E3RsZ4hFZlM+DtpHiICkbPefSx72IqA/ScbbFW8Cs6ZQrlVGovhLHgLQNqvFndyZqrYRSFo/8UFJxvDCLX21Te5dQphUoaFhQSYPDJoJbDDrSfY0LD5T42g==; 5:NiG0pDtRqCjbaWBeVf3TzrZ+0HQO3Y6ZyOCB3hYR/X/dHG99IBxTLWaoCAh+bhfdmN0krXlYiFjTxuatG6Cnk9ag++dMLq7M7E/tFJ/UKAt1XWNfYRxTARybgiopGEiVIlFMq2CTE8zXpsCmwdXSLO6mkcRvg6dexYlwTcj4Eok=; 7:VA2Q7V5TusniGHKdarCg4LJd6RpWGS+gSDceQj+XaE4qnbxJY8gdaIbWHn31g0KoS5J0Hl+kLeQQYCEjDpOdfo0706/fth/kg6+6BWcMv2gMmo8Z9shDuMma2tiiJuhNpnNfS60vif3zjEHlHe00mUHjXILsOVFJSwYRsKEA9trF1eHKPS3dvY7yM0oyHNgjZfnTx7HLvICwnK11kJ7EZX2AZ3zCgMzLci8QPFUnbK1l1W+t307St5TC4iW2cV7n x-ms-office365-filtering-correlation-id: 59d56bcf-daaf-471b-5ebf-08d632a1f941 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4948; x-ms-traffictypediagnostic: AM0PR04MB4948: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(201708071742011)(7699051); SRVR:AM0PR04MB4948; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4948; x-forefront-prvs: 0826B2F01B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(136003)(396003)(39860400002)(189003)(199004)(97736004)(105586002)(256004)(2906002)(106356001)(53936002)(102836004)(52116002)(6116002)(3846002)(118296001)(36756003)(14444005)(5250100002)(6506007)(386003)(76176011)(66066001)(81156014)(81166006)(305945005)(486006)(8676002)(71200400001)(110136005)(54906003)(99286004)(44832011)(71190400001)(7736002)(478600001)(39060400002)(68736007)(4326008)(6436002)(25786009)(6486002)(446003)(11346002)(5660300001)(316002)(6636002)(7416002)(2616005)(186003)(26005)(8936002)(86362001)(575784001)(14454004)(50226002)(6512007)(2900100001)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4948; H:AM0PR04MB4290.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: XsQsU/+Um/j3yLaxZv20qyJaWewuYvD0U4727DRkuaT+V3Ev4ImpdxJJ7jdDdfQv8iCHStTxstbwVZxva13DnEDwwszYPUStX7SxPMhP0cPJdctFRzpaSAeQBxKdTRo3G43mSZn920NwdlBq/PiUujRwVMotZQJjvzFtdYhAwWVuKZjuQ7Tyqu+5hcQnkDegOGNuvlA0nc13LC1WpKgr/HNuCJHAk64oi2y6WVJf4g4RUn8/vptyUUnGQo/SgqH8Vrk8vf6eo/gqvhRXpqbdFbTzSz6HGtL7yV/6U9+u7TZ9QweVe4wFck1tOY6bUpf1M7x/AezNToReGe6Lhykmup6MsqPFN9tlIWu8Xs93v60= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59d56bcf-daaf-471b-5ebf-08d632a1f941 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2018 13:27:37.5380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4948 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181015_092753_571600_CDCA19BE X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Aymen Sghaier , Herbert Xu , Horia Geanta , "linux-kernel@vger.kernel.org" , Franck Lenormand , Marek Vasut , Rob Herring , "linux-crypto@vger.kernel.org" , "kernel@pengutronix.de" , "David S . Miller " , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 6ull and 6sll the DCP block has a clock which needs to be explicitly enabled. Add minimal handling for this at probe/remove time. Signed-off-by: Leonard Crestez --- drivers/crypto/mxs-dcp.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c index 849a81ece079..fd13787a2a0e 100644 --- a/drivers/crypto/mxs-dcp.c +++ b/drivers/crypto/mxs-dcp.c @@ -18,10 +18,11 @@ #include #include #include #include #include +#include #include #include #include #include @@ -80,10 +81,11 @@ struct dcp { struct completion completion[DCP_MAX_CHANS]; spinlock_t lock[DCP_MAX_CHANS]; struct task_struct *thread[DCP_MAX_CHANS]; struct crypto_queue queue[DCP_MAX_CHANS]; + struct clk *dcp_clk; }; enum dcp_chan { DCP_CHAN_HASH_SHA = 0, DCP_CHAN_CRYPTO = 2, @@ -1027,10 +1029,24 @@ static int mxs_dcp_probe(struct platform_device *pdev) sdcp->dev = dev; sdcp->base = devm_ioremap_resource(dev, iores); if (IS_ERR(sdcp->base)) return PTR_ERR(sdcp->base); + /* DCP clock is optional, only used on some SOCs */ + sdcp->dcp_clk = devm_clk_get(dev, "dcp"); + if (IS_ERR(sdcp->dcp_clk)) { + if (sdcp->dcp_clk != ERR_PTR(-ENOENT)) + return PTR_ERR(sdcp->dcp_clk); + sdcp->dcp_clk = NULL; + } + + ret = clk_prepare(sdcp->dcp_clk); + if (ret) + return ret; + ret = clk_enable(sdcp->dcp_clk); + if (ret) + return ret; ret = devm_request_irq(dev, dcp_vmi_irq, mxs_dcp_irq, 0, "dcp-vmi-irq", sdcp); if (ret) { dev_err(dev, "Failed to claim DCP VMI IRQ!\n"); @@ -1168,10 +1184,12 @@ static int mxs_dcp_remove(struct platform_device *pdev) crypto_unregister_algs(dcp_aes_algs, ARRAY_SIZE(dcp_aes_algs)); kthread_stop(sdcp->thread[DCP_CHAN_HASH_SHA]); kthread_stop(sdcp->thread[DCP_CHAN_CRYPTO]); + clk_disable(sdcp->dcp_clk); + platform_set_drvdata(pdev, NULL); global_sdcp = NULL; return 0;