From patchwork Thu Jul 7 07:36:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Imre Kaloz X-Patchwork-Id: 952262 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p677aOF6009582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 7 Jul 2011 07:36:45 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qej8B-00025U-5Q; Thu, 07 Jul 2011 07:36:15 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qej8A-0006Hf-RR; Thu, 07 Jul 2011 07:36:14 +0000 Received: from arrakis.dune.hu ([78.24.191.176]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qej87-0006HL-Oc for linux-arm-kernel@lists.infradead.org; Thu, 07 Jul 2011 07:36:12 +0000 Received: from localhost (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 49F0123C00E7; Thu, 7 Jul 2011 09:36:07 +0200 (CEST) X-Virus-Scanned: at arrakis.dune.hu X-Spam-Flag: NO X-Spam-Score: -2.527 X-Spam-Level: X-Spam-Status: No, score=-2.527 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.742, BAYES_00=-2.599, DNS_FROM_OPENWHOIS=1.13] autolearn=no Received: from arrakis.dune.hu ([127.0.0.1]) by localhost (arrakis.dune.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GQzBRGidas7j; Thu, 7 Jul 2011 09:36:05 +0200 (CEST) Received: from ecaz (firewall.ahiv.hu [195.228.168.220]) by arrakis.dune.hu (Postfix) with ESMTPSA id 7ED8223C00E2; Thu, 7 Jul 2011 09:36:05 +0200 (CEST) To: "Anton Vorontsov" , "Lin Mac" Subject: Re: [PATCH] ARM: cns3xxx: Add support for L2 Cache Controller References: <20110706140832.GA15946@oksana.dev.rtsoft.ru> Date: Thu, 07 Jul 2011 09:36:05 +0200 MIME-Version: 1.0 From: "Imre Kaloz" Organization: OpenWrt - Wireless Freedom Message-ID: In-Reply-To: X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110707_033611_951361_06AFC4D2 X-CRM114-Status: GOOD ( 11.94 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- Cc: linux-arm-kernel@lists.infradead.org, Tommy Lin , Russell King , mac.lin@caviumnetworks.com, Arnd Bergmann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 07 Jul 2011 07:36:45 +0000 (UTC) On Thu, 07 Jul 2011 01:57:11 +0200, Lin Mac wrote: > CNS3xxx have PL310. Would you mind to enable CONFIG_CACHE_PL310 by > default as well? It is default disabled by !CPU_V6 of CACHE_PL310. > > @@ -795,6 +795,7 @@ config CACHE_L2X0 > default y > select OUTER_CACHE > select OUTER_CACHE_SYNC > + select CACHE_PL310 if ARCH_CNS3XXX > help > This option enables the L2x0 PrimeCell. Correct me if I'm wrong, but isn't cns3xxx V6K? So..... Imre --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -322,7 +322,7 @@ config ARCH_CLPS711X config ARCH_CNS3XXX bool "Cavium Networks CNS3XXX family" - select CPU_V6 + select CPU_V6K select GENERIC_CLOCKEVENTS select ARM_GIC select MIGHT_HAVE_PCI