| Message ID | 1595413915-17867-1-git-send-email-rohitkr@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: qcom: Add support for SC7180 lpass variant | expand |
On 22/07/2020 11:31, Rohit kumar wrote: > This patch chain add audio support for SC7180 soc by doing the required > modification in existing common lpass-cpu/lpass-platform driver. > This also fixes some concurrency issue. > > Changes since v3: > - Fixed yaml documentation comments and make dt_binding_check issues. > - Moved general fixes out of sc7180 specific patches as suggested by Srinivas. > - Update clock-names to make it same as existing platforms. > > Ajit Pandey (4): > ASoC: qcom: Add common array to initialize soc based core clocks > ASoC: qcom: lpass-platform: Replace card->dev with component->dev > include: dt-bindings: sound: Add sc7180-lpass bindings header > ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio > > Rohit kumar (8): > ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function > ASoC: qcom: lpass-platform: fix memory leak > ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers > ASoC: qcom: lpass-cpu: fix concurrency issue > dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node > ASoC: qcom: lpass-cpu: Use platform_get_resource > ASoC: qcom: lpass-platform: Use platform_get_irq > dt-bindings: sound: lpass-cpu: Move to yaml format Tested this on Dragon Board 410c! Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --srini > > .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 79 -------- > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 ++++++++++++++++++ > include/dt-bindings/sound/sc7180-lpass.h | 10 + > sound/soc/qcom/Kconfig | 5 + > sound/soc/qcom/Makefile | 2 + > sound/soc/qcom/lpass-apq8016.c | 86 ++++++-- > sound/soc/qcom/lpass-cpu.c | 204 ++++++++++--------- > sound/soc/qcom/lpass-ipq806x.c | 67 +++++++ > sound/soc/qcom/lpass-lpaif-reg.h | 157 ++++++++------- > sound/soc/qcom/lpass-platform.c | 155 +++++++++++---- > sound/soc/qcom/lpass-sc7180.c | 216 +++++++++++++++++++++ > sound/soc/qcom/lpass.h | 63 +++++- > 12 files changed, 930 insertions(+), 299 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt > create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > create mode 100644 include/dt-bindings/sound/sc7180-lpass.h > create mode 100644 sound/soc/qcom/lpass-sc7180.c >
On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: > > > On 22/07/2020 11:31, Rohit kumar wrote: >> This patch chain add audio support for SC7180 soc by doing the required >> modification in existing common lpass-cpu/lpass-platform driver. >> This also fixes some concurrency issue. >> >> Changes since v3: >> - Fixed yaml documentation comments and make dt_binding_check >> issues. >> - Moved general fixes out of sc7180 specific patches as suggested >> by Srinivas. >> - Update clock-names to make it same as existing platforms. >> >> Ajit Pandey (4): >> ASoC: qcom: Add common array to initialize soc based core clocks >> ASoC: qcom: lpass-platform: Replace card->dev with component->dev >> include: dt-bindings: sound: Add sc7180-lpass bindings header >> ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio >> >> Rohit kumar (8): >> ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function >> ASoC: qcom: lpass-platform: fix memory leak >> ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers >> ASoC: qcom: lpass-cpu: fix concurrency issue >> dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node >> ASoC: qcom: lpass-cpu: Use platform_get_resource >> ASoC: qcom: lpass-platform: Use platform_get_irq >> dt-bindings: sound: lpass-cpu: Move to yaml format > > Thanks Srini for review and testing. Mark, I am planning to repost patch07 onwards to address comments by Rob as there are no comments till patch06 and they are just fixes. > Tested this on Dragon Board 410c! > > Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > --srini >> >> .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 79 -------- >> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 >> ++++++++++++++++++ >> include/dt-bindings/sound/sc7180-lpass.h | 10 + >> sound/soc/qcom/Kconfig | 5 + >> sound/soc/qcom/Makefile | 2 + >> sound/soc/qcom/lpass-apq8016.c | 86 ++++++-- >> sound/soc/qcom/lpass-cpu.c | 204 >> ++++++++++--------- >> sound/soc/qcom/lpass-ipq806x.c | 67 +++++++ >> sound/soc/qcom/lpass-lpaif-reg.h | 157 >> ++++++++------- >> sound/soc/qcom/lpass-platform.c | 155 >> +++++++++++---- >> sound/soc/qcom/lpass-sc7180.c | 216 >> +++++++++++++++++++++ >> sound/soc/qcom/lpass.h | 63 +++++- >> 12 files changed, 930 insertions(+), 299 deletions(-) >> delete mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >> create mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> create mode 100644 include/dt-bindings/sound/sc7180-lpass.h >> create mode 100644 sound/soc/qcom/lpass-sc7180.c >>
On 7/27/2020 3:20 PM, Rohit Kumar wrote: > > On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: >> >> >> On 22/07/2020 11:31, Rohit kumar wrote: >>> This patch chain add audio support for SC7180 soc by doing the required >>> modification in existing common lpass-cpu/lpass-platform driver. >>> This also fixes some concurrency issue. >>> >>> Changes since v3: >>> - Fixed yaml documentation comments and make dt_binding_check >>> issues. >>> - Moved general fixes out of sc7180 specific patches as >>> suggested by Srinivas. >>> - Update clock-names to make it same as existing platforms. >>> >>> Ajit Pandey (4): >>> ASoC: qcom: Add common array to initialize soc based core clocks >>> ASoC: qcom: lpass-platform: Replace card->dev with component->dev >>> include: dt-bindings: sound: Add sc7180-lpass bindings header >>> ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio >>> >>> Rohit kumar (8): >>> ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function >>> ASoC: qcom: lpass-platform: fix memory leak >>> ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers >>> ASoC: qcom: lpass-cpu: fix concurrency issue >>> dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node >>> ASoC: qcom: lpass-cpu: Use platform_get_resource >>> ASoC: qcom: lpass-platform: Use platform_get_irq >>> dt-bindings: sound: lpass-cpu: Move to yaml format >> >> > Thanks Srini for review and testing. > > Mark, I am planning to repost patch07 onwards to address comments by > Rob as > > there are no comments till patch06 and they are just fixes. Hello Mark, Are you planning to review/merge the changes till patch06. If not, I will resend those patches along with comments addressed on patch07 onwards. Thanks, Rohit > >> Tested this on Dragon Board 410c! >> >> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> >> --srini >>> >>> .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 79 -------- >>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 >>> ++++++++++++++++++ >>> include/dt-bindings/sound/sc7180-lpass.h | 10 + >>> sound/soc/qcom/Kconfig | 5 + >>> sound/soc/qcom/Makefile | 2 + >>> sound/soc/qcom/lpass-apq8016.c | 86 ++++++-- >>> sound/soc/qcom/lpass-cpu.c | 204 >>> ++++++++++--------- >>> sound/soc/qcom/lpass-ipq806x.c | 67 +++++++ >>> sound/soc/qcom/lpass-lpaif-reg.h | 157 >>> ++++++++------- >>> sound/soc/qcom/lpass-platform.c | 155 >>> +++++++++++---- >>> sound/soc/qcom/lpass-sc7180.c | 216 >>> +++++++++++++++++++++ >>> sound/soc/qcom/lpass.h | 63 +++++- >>> 12 files changed, 930 insertions(+), 299 deletions(-) >>> delete mode 100644 >>> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>> create mode 100644 >>> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >>> create mode 100644 include/dt-bindings/sound/sc7180-lpass.h >>> create mode 100644 sound/soc/qcom/lpass-sc7180.c >>>