| Message ID | 1641749107-31979-1-git-send-email-quic_mkshah@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add APSS RSC to Cluster power domain | expand |
On Sun, 9 Jan 2022 22:54:57 +0530, Maulik Shah wrote: > This series patches 1 to 4 adds/corrects the cpuidle states/ > apps_rsc TCS configuration to make it same as downstream kernel. > > The patches 5, 6 and 7 adds apps_rsc device to cluster power domain such > that when cluster is going to power down the cluster pre off notification > will program the 'sleep' and 'wake' votes in SLEEP TCS and WAKE TCSes. > > [...] Applied, thanks! [01/10] arm64: dts: qcom: sm8150: Correct TCS configuration for apps rsc commit: 17ac8af678b6da6a8f1df7da8ebf2c5198741827 [02/10] arm64: dts: qcom: sm8250: Add cpuidle states commit: 32bc936d732171d48c9c8f96c4fa25ac3ed7e1c7 [03/10] arm64: dts: qcom: sm8350: Correct TCS configuration for apps rsc commit: a131255e4ad1ef8d4873ecba21561ba272b2547a [04/10] arm64: dts: qcom: sm8450: Update cpuidle states parameters commit: 6574702b0d394d2acc9ff808c4a79df8b9999173 Best regards,
On Tue, 1 Feb 2022 at 10:52, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Sun, 9 Jan 2022 22:54:57 +0530, Maulik Shah wrote: > > This series patches 1 to 4 adds/corrects the cpuidle states/ > > apps_rsc TCS configuration to make it same as downstream kernel. > > > > The patches 5, 6 and 7 adds apps_rsc device to cluster power domain such > > that when cluster is going to power down the cluster pre off notification > > will program the 'sleep' and 'wake' votes in SLEEP TCS and WAKE TCSes. > > > > [...] > > Applied, thanks! > > [01/10] arm64: dts: qcom: sm8150: Correct TCS configuration for apps rsc > commit: 17ac8af678b6da6a8f1df7da8ebf2c5198741827 > [02/10] arm64: dts: qcom: sm8250: Add cpuidle states > commit: 32bc936d732171d48c9c8f96c4fa25ac3ed7e1c7 Hi, These patches landed upstream and I see a boot regression on RB5 with this sm8250 patch: [ T1] vreg_l11c_3p3: failed to enable: -ETIMEDOUT [ T1] qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110 [ T1] qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110 Doesn't regress everytime but It is fairly reproducible. RB5 fails to boot on every alternate reboot or so. But the device boots everytime if I revert this patch. > [03/10] arm64: dts: qcom: sm8350: Correct TCS configuration for apps rsc > commit: a131255e4ad1ef8d4873ecba21561ba272b2547a > [04/10] arm64: dts: qcom: sm8450: Update cpuidle states parameters > commit: 6574702b0d394d2acc9ff808c4a79df8b9999173 > > Best regards, > -- > Bjorn Andersson <bjorn.andersson@linaro.org>
On Tue, 29 Mar 2022 at 15:25, Amit Pundir <amit.pundir@linaro.org> wrote: > > On Tue, 1 Feb 2022 at 10:52, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > > > On Sun, 9 Jan 2022 22:54:57 +0530, Maulik Shah wrote: > > > This series patches 1 to 4 adds/corrects the cpuidle states/ > > > apps_rsc TCS configuration to make it same as downstream kernel. > > > > > > The patches 5, 6 and 7 adds apps_rsc device to cluster power domain such > > > that when cluster is going to power down the cluster pre off notification > > > will program the 'sleep' and 'wake' votes in SLEEP TCS and WAKE TCSes. > > > > > > [...] > > > > Applied, thanks! > > > > [01/10] arm64: dts: qcom: sm8150: Correct TCS configuration for apps rsc > > commit: 17ac8af678b6da6a8f1df7da8ebf2c5198741827 > > [02/10] arm64: dts: qcom: sm8250: Add cpuidle states > > commit: 32bc936d732171d48c9c8f96c4fa25ac3ed7e1c7 > > Hi, These patches landed upstream and I see a boot regression on RB5 > with this sm8250 patch: > > [ T1] vreg_l11c_3p3: failed to enable: -ETIMEDOUT > [ T1] qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: > ldo11: devm_regulator_register() failed, ret=-110 > [ T1] qcom-rpmh-regulator: probe of > 18200000.rsc:pm8150l-rpmh-regulators failed with error -110 > > Doesn't regress everytime but It is fairly reproducible. RB5 fails to > boot on every alternate reboot or so. But the device boots everytime > if I revert this patch. Hi, I'm still waiting on a resolution/fix for this. I'm happy to test or run any debug patches, if it would help narrow the issue down. Fwiw, this is the defconfig I'm using https://git.linaro.org/people/amit.pundir/linux.git/plain/arch/arm64/configs/rbX_aosp_defconfig?h=rb5-rpmh-regression Regards, Amit Pundir > > > [03/10] arm64: dts: qcom: sm8350: Correct TCS configuration for apps rsc > > commit: a131255e4ad1ef8d4873ecba21561ba272b2547a > > [04/10] arm64: dts: qcom: sm8450: Update cpuidle states parameters > > commit: 6574702b0d394d2acc9ff808c4a79df8b9999173 > > > > Best regards, > > -- > > Bjorn Andersson <bjorn.andersson@linaro.org>
This series patches 1 to 4 adds/corrects the cpuidle states/ apps_rsc TCS configuration to make it same as downstream kernel. The patches 5, 6 and 7 adds apps_rsc device to cluster power domain such that when cluster is going to power down the cluster pre off notification will program the 'sleep' and 'wake' votes in SLEEP TCS and WAKE TCSes. The patches 8, 9 and 10 are to program the next wakeup in CONTROL_TCS. [1], [2] was older way of programming CONTROL_TCS (exporting an API and calling when last CPU was entering deeper low power mode). Now with patch number 5,6 and 7 the apps RSC is added to to cluster power domain and hence these patches are no longer needed with this series. The series is tested on SM8250 with latest linux-next tag next-20220107. [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/20190218140210.14631-3-rplsssn@codeaurora.org/ [2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=59613 Lina Iyer (1): soc: qcom: rpmh-rsc: Attach RSC to cluster PM domain Maulik Shah (9): arm64: dts: qcom: sm8150: Correct TCS configuration for apps rsc arm64: dts: qcom: sm8250: Add cpuidle states arm64: dts: qcom: sm8350: Correct TCS configuration for apps rsc arm64: dts: qcom: sm8450: Update cpuidle states parameters dt-bindings: soc: qcom: Update devicetree binding document for rpmh-rsc arm64: dts: qcom: Add power-domains property for apps_rsc PM: domains: Store the closest hrtimer event of the domain CPUs soc: qcom: rpmh-rsc: Save base address of drv soc: qcom: rpmh-rsc: Write CONTROL_TCS with next timer wakeup .../devicetree/bindings/soc/qcom/rpmh-rsc.txt | 6 + arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 106 ++++++++++++++++ arch/arm64/boot/dts/qcom/sm8350.dtsi | 3 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 29 ++--- drivers/base/power/domain_governor.c | 1 + drivers/soc/qcom/rpmh-internal.h | 9 +- drivers/soc/qcom/rpmh-rsc.c | 138 +++++++++++++++++++-- drivers/soc/qcom/rpmh.c | 4 +- include/linux/pm_domain.h | 1 + 10 files changed, 271 insertions(+), 33 deletions(-)