mbox series

[v2,0/3] Refactor xhci quirks and plat private data

Message ID 1646130507-26796-1-git-send-email-quic_c_sanm@quicinc.com (mailing list archive)
Headers show
Series Refactor xhci quirks and plat private data | expand

Message

Sandeep Maheswaram March 1, 2022, 10:28 a.m. UTC
changes in v2:
Added a PATCH 2/3 to remove unwanted header inclusion.
Fixed minor nitpicks in PATCH 3/3.

Pavankumar Kondeti (1):
  usb: xhci: refactor quirks and plat private data

Sandeep Maheswaram (2):
  usb: xhci: Remove unwanted header inclusion
  usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT

 drivers/usb/cdns3/host.c        |  2 +-
 drivers/usb/dwc3/host.c         | 13 ++++++++
 drivers/usb/host/xhci-plat.c    |  3 +-
 drivers/usb/host/xhci-plat.h    | 24 ---------------
 drivers/usb/host/xhci-rcar.c    |  3 +-
 drivers/usb/host/xhci.h         | 60 ++++--------------------------------
 include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
 include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
 8 files changed, 115 insertions(+), 81 deletions(-)
 delete mode 100644 drivers/usb/host/xhci-plat.h
 create mode 100644 include/linux/usb/xhci-plat.h
 create mode 100644 include/linux/usb/xhci-quirks.h

Comments

Sandeep Maheswaram March 17, 2022, 5:47 a.m. UTC | #1
Hi Greg,

On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
> changes in v2:
> Added a PATCH 2/3 to remove unwanted header inclusion.
> Fixed minor nitpicks in PATCH 3/3.
>
> Pavankumar Kondeti (1):
>    usb: xhci: refactor quirks and plat private data
>
> Sandeep Maheswaram (2):
>    usb: xhci: Remove unwanted header inclusion
>    usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
>
>   drivers/usb/cdns3/host.c        |  2 +-
>   drivers/usb/dwc3/host.c         | 13 ++++++++
>   drivers/usb/host/xhci-plat.c    |  3 +-
>   drivers/usb/host/xhci-plat.h    | 24 ---------------
>   drivers/usb/host/xhci-rcar.c    |  3 +-
>   drivers/usb/host/xhci.h         | 60 ++++--------------------------------
>   include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
>   include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
>   8 files changed, 115 insertions(+), 81 deletions(-)
>   delete mode 100644 drivers/usb/host/xhci-plat.h
>   create mode 100644 include/linux/usb/xhci-plat.h
>   create mode 100644 include/linux/usb/xhci-quirks.h

Please let me know your opinion about this patch series.

Regards

Sandeep
Greg KH March 18, 2022, 11:59 a.m. UTC | #2
On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
> Hi Greg,
> 
> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
> > changes in v2:
> > Added a PATCH 2/3 to remove unwanted header inclusion.
> > Fixed minor nitpicks in PATCH 3/3.
> > 
> > Pavankumar Kondeti (1):
> >    usb: xhci: refactor quirks and plat private data
> > 
> > Sandeep Maheswaram (2):
> >    usb: xhci: Remove unwanted header inclusion
> >    usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
> > 
> >   drivers/usb/cdns3/host.c        |  2 +-
> >   drivers/usb/dwc3/host.c         | 13 ++++++++
> >   drivers/usb/host/xhci-plat.c    |  3 +-
> >   drivers/usb/host/xhci-plat.h    | 24 ---------------
> >   drivers/usb/host/xhci-rcar.c    |  3 +-
> >   drivers/usb/host/xhci.h         | 60 ++++--------------------------------
> >   include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
> >   include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
> >   8 files changed, 115 insertions(+), 81 deletions(-)
> >   delete mode 100644 drivers/usb/host/xhci-plat.h
> >   create mode 100644 include/linux/usb/xhci-plat.h
> >   create mode 100644 include/linux/usb/xhci-quirks.h
> 
> Please let me know your opinion about this patch series.

I need the xhci maintainer to review it...

thanks,

greg k-h
Sandeep Maheswaram March 21, 2022, 6:21 a.m. UTC | #3
Hi Mathias,

On 3/18/2022 5:29 PM, Greg Kroah-Hartman wrote:
> On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
>> Hi Greg,
>>
>> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
>>> changes in v2:
>>> Added a PATCH 2/3 to remove unwanted header inclusion.
>>> Fixed minor nitpicks in PATCH 3/3.
>>>
>>> Pavankumar Kondeti (1):
>>>     usb: xhci: refactor quirks and plat private data
>>>
>>> Sandeep Maheswaram (2):
>>>     usb: xhci: Remove unwanted header inclusion
>>>     usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
>>>
>>>    drivers/usb/cdns3/host.c        |  2 +-
>>>    drivers/usb/dwc3/host.c         | 13 ++++++++
>>>    drivers/usb/host/xhci-plat.c    |  3 +-
>>>    drivers/usb/host/xhci-plat.h    | 24 ---------------
>>>    drivers/usb/host/xhci-rcar.c    |  3 +-
>>>    drivers/usb/host/xhci.h         | 60 ++++--------------------------------
>>>    include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
>>>    include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
>>>    8 files changed, 115 insertions(+), 81 deletions(-)
>>>    delete mode 100644 drivers/usb/host/xhci-plat.h
>>>    create mode 100644 include/linux/usb/xhci-plat.h
>>>    create mode 100644 include/linux/usb/xhci-quirks.h
>> Please let me know your opinion about this patch series.
> I need the xhci maintainer to review it...
>
> thanks,
>
> greg k-h


Can you please review this patch series.

Regards

Sandeep
Mathias Nyman March 22, 2022, 3:53 p.m. UTC | #4
On 21.3.2022 8.21, Sandeep Maheswaram (Temp) wrote:
> Hi Mathias,
> 
> On 3/18/2022 5:29 PM, Greg Kroah-Hartman wrote:
>> On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
>>> Hi Greg,
>>>
>>> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
>>>> changes in v2:
>>>> Added a PATCH 2/3 to remove unwanted header inclusion.
>>>> Fixed minor nitpicks in PATCH 3/3.
>>>>
>>>> Pavankumar Kondeti (1):
>>>>     usb: xhci: refactor quirks and plat private data
>>>>
>>>> Sandeep Maheswaram (2):
>>>>     usb: xhci: Remove unwanted header inclusion
>>>>     usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
>>>>
>>>>    drivers/usb/cdns3/host.c        |  2 +-
>>>>    drivers/usb/dwc3/host.c         | 13 ++++++++
>>>>    drivers/usb/host/xhci-plat.c    |  3 +-
>>>>    drivers/usb/host/xhci-plat.h    | 24 ---------------
>>>>    drivers/usb/host/xhci-rcar.c    |  3 +-
>>>>    drivers/usb/host/xhci.h         | 60 ++++--------------------------------
>>>>    include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
>>>>    include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
>>>>    8 files changed, 115 insertions(+), 81 deletions(-)
>>>>    delete mode 100644 drivers/usb/host/xhci-plat.h
>>>>    create mode 100644 include/linux/usb/xhci-plat.h
>>>>    create mode 100644 include/linux/usb/xhci-quirks.h
>>> Please let me know your opinion about this patch series.
>> I need the xhci maintainer to review it...
>>
>> thanks,
>>
>> greg k-h
> 
> 
> Can you please review this patch series.
> 

I don't have a better solution than this.

So neither devicetree or ACPI entries exists for the xHC part of this dwc3 controller?

A pure platform device is created, and it matches and binds to xhci-plat driver by "xhci-hcd" name.
I guess we have no way to identify this dwc3 xhci controller in xhci-plat.c, and set quirks there,
like all those devicetree xhci devices that we set quirks based on .compatibility. 

Thanks
Mathias
Pavan Kondeti March 23, 2022, 3:07 a.m. UTC | #5
Hi Mathias,

On Tue, Mar 22, 2022 at 05:53:42PM +0200, Mathias Nyman wrote:
> On 21.3.2022 8.21, Sandeep Maheswaram (Temp) wrote:
> > Hi Mathias,
> > 
> > On 3/18/2022 5:29 PM, Greg Kroah-Hartman wrote:
> >> On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
> >>> Hi Greg,
> >>>
> >>> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
> >>>> changes in v2:
> >>>> Added a PATCH 2/3 to remove unwanted header inclusion.
> >>>> Fixed minor nitpicks in PATCH 3/3.
> >>>>
> >>>> Pavankumar Kondeti (1):
> >>>>     usb: xhci: refactor quirks and plat private data
> >>>>
> >>>> Sandeep Maheswaram (2):
> >>>>     usb: xhci: Remove unwanted header inclusion
> >>>>     usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
> >>>>
> >>>>    drivers/usb/cdns3/host.c        |  2 +-
> >>>>    drivers/usb/dwc3/host.c         | 13 ++++++++
> >>>>    drivers/usb/host/xhci-plat.c    |  3 +-
> >>>>    drivers/usb/host/xhci-plat.h    | 24 ---------------
> >>>>    drivers/usb/host/xhci-rcar.c    |  3 +-
> >>>>    drivers/usb/host/xhci.h         | 60 ++++--------------------------------
> >>>>    include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
> >>>>    include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
> >>>>    8 files changed, 115 insertions(+), 81 deletions(-)
> >>>>    delete mode 100644 drivers/usb/host/xhci-plat.h
> >>>>    create mode 100644 include/linux/usb/xhci-plat.h
> >>>>    create mode 100644 include/linux/usb/xhci-quirks.h
> >>> Please let me know your opinion about this patch series.
> >> I need the xhci maintainer to review it...
> >>
> >> thanks,
> >>
> >> greg k-h
> > 
> > 
> > Can you please review this patch series.
> > 
> 
> I don't have a better solution than this.
> 
> So neither devicetree or ACPI entries exists for the xHC part of this dwc3 controller?
> 
> A pure platform device is created, and it matches and binds to xhci-plat driver by "xhci-hcd" name.
> I guess we have no way to identify this dwc3 xhci controller in xhci-plat.c, and set quirks there,
> like all those devicetree xhci devices that we set quirks based on .compatibility. 
> 
Thanks for the review. Yes, xhci-plat platform device is created by the DWC3
driver for the controllers that needs to be operated in the host.

Thanks,
Pavan