[RFC,0/3] Add interconnect support to the SCM interface

Message

Sibi Sankar May 23, 2022, 7 a.m. UTC

Some of the SMC calls required by remoteproc PAS driver on SM8450 SoCs
get a performance benefit from having a max vote to the crypto->ddr path.
Add support for bandwidth (bw) voting for those SMC calls when the
interconnects property is specified. Marking this as an RFC since the path
could either be specified in the individual remoteprocs or directly in the
scm interface.

Sibi Sankar (3):
  dt-bindings: firmware: qcom-scm: Add interconnects property
  firmware: qcom_scm: Add bw voting support to the SCM interface
  arm64: dts: qcom: sm8450: Add interconnect requirements for SCM

 .../devicetree/bindings/firmware/qcom,scm.txt      |  1 +
 arch/arm64/boot/dts/qcom/sm8450.dtsi               |  1 +
 drivers/firmware/qcom_scm.c                        | 69 ++++++++++++++++++++++
 3 files changed, 71 insertions(+)

Comments

Bjorn Andersson June 30, 2022, 2:47 a.m. UTC | #1

On Mon 23 May 02:00 CDT 2022, Sibi Sankar wrote:

> Some of the SMC calls required by remoteproc PAS driver on SM8450 SoCs
> get a performance benefit from having a max vote to the crypto->ddr path.
> Add support for bandwidth (bw) voting for those SMC calls when the
> interconnects property is specified. Marking this as an RFC since the path
> could either be specified in the individual remoteprocs or directly in the
> scm interface.
> 

I find it reasonable to state that the clocking needs for the CE relates
to the SCM and not the remoteproc, and it's in line with the management
of CE clocks from the SCM driver.

Regards,
Bjorn

> Sibi Sankar (3):
>   dt-bindings: firmware: qcom-scm: Add interconnects property
>   firmware: qcom_scm: Add bw voting support to the SCM interface
>   arm64: dts: qcom: sm8450: Add interconnect requirements for SCM
> 
>  .../devicetree/bindings/firmware/qcom,scm.txt      |  1 +
>  arch/arm64/boot/dts/qcom/sm8450.dtsi               |  1 +
>  drivers/firmware/qcom_scm.c                        | 69 ++++++++++++++++++++++
>  3 files changed, 71 insertions(+)
> 
> -- 
> 2.7.4
>

Bjorn Andersson July 3, 2022, 3:56 a.m. UTC | #2

On Mon, 23 May 2022 12:30:55 +0530, Sibi Sankar wrote:
> Some of the SMC calls required by remoteproc PAS driver on SM8450 SoCs
> get a performance benefit from having a max vote to the crypto->ddr path.
> Add support for bandwidth (bw) voting for those SMC calls when the
> interconnects property is specified. Marking this as an RFC since the path
> could either be specified in the individual remoteprocs or directly in the
> scm interface.
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: qcom: sm8450: Add interconnect requirements for SCM
      commit: 4c9fb8e89849db0f12fbfd4ad6a6ce036251a200

Best regards,