[net-next,0/2] net: qrtr: Few qrtr fixes

Message

Sricharan Ramabadhran Sept. 1, 2023, 10:20 a.m. UTC

Patch #1 fixes a race condition between qrtr driver and ns opening and
sending data to a control port.

Patch #2 address the issue with legacy targets sending the SSR
notifications using DEL_PROC control message.

Sricharan Ramabadhran (1):
  net: qrtr: Add support for processing DEL_PROC type control message

Vignesh Viswanathan (1):
  net: qrtr: Prevent stale ports from sending

 include/uapi/linux/qrtr.h |  1 +
 net/qrtr/af_qrtr.c        | 75 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+)

Comments

Simon Horman Sept. 1, 2023, 2:19 p.m. UTC | #1

On Fri, Sep 01, 2023 at 03:50:19PM +0530, Sricharan Ramabadhran wrote:
> Patch #1 fixes a race condition between qrtr driver and ns opening and
> sending data to a control port.
> 
> Patch #2 address the issue with legacy targets sending the SSR
> notifications using DEL_PROC control message.

Hi Sricharan,

if these are fixes then they should be targeted at 'net' rather than
'net-next', and consideration should be given to supplying Fixes tags.

If these are not fixes, then please don't describe them as such.
In this case targeting net-next is correct, but it is currently closed,
as per the form letter below.

In either case please consider:

* Arranging local variables for new Networking code in
  reverse xmas tree order - longest line to shortest

* Avoiding introducing new Sparse warnings


## Form letter - net-next-closed

The merge window for v6.6 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Sept 11th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer

Sricharan Ramabadhran Sept. 3, 2023, 12:26 p.m. UTC | #2

Hi Simon,

On 9/1/2023 7:49 PM, Simon Horman wrote:
> On Fri, Sep 01, 2023 at 03:50:19PM +0530, Sricharan Ramabadhran wrote:
>> Patch #1 fixes a race condition between qrtr driver and ns opening and
>> sending data to a control port.
>>
>> Patch #2 address the issue with legacy targets sending the SSR
>> notifications using DEL_PROC control message.
> 
> Hi Sricharan,
> 
> if these are fixes then they should be targeted at 'net' rather than
> 'net-next', and consideration should be given to supplying Fixes tags.
> 
  There is as such no existing feature broken without these 2 patches
  today. Then they might qualify as preparatory patches for adding
  some features.

> If these are not fixes, then please don't describe them as such.
> In this case targeting net-next is correct, but it is currently closed,
> as per the form letter below.
> 
   Sure, then in that case looks like it belongs to 'net-next' and will
   post V2 once the net-next is opened again.

> In either case please consider:
> 
> * Arranging local variables for new Networking code in
>    reverse xmas tree order - longest line to shortest
> 
> * Avoiding introducing new Sparse warnings
> 
>   ok.

> ## Form letter - net-next-closed
> 
> The merge window for v6.6 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.
> 
> Please repost when net-next reopens after Sept 11th.
> 

  ok, sure.

Regards,
  Sricharan