[v1,0/3] Add fixes for FastRPC driver

Message

Ekansh Gupta Sept. 29, 2023, 7:42 a.m. UTC

This patchset carries the following fixes.
- Reset metadata buffer to avoid incorrect fd getting freed
- Free DMA handles for remote calls with no arguments
- Clean buffers on remote call failures

Ekansh Gupta (3):
  misc: fastrpc: Reset metadata buffer to avoid incorrect free
  misc: fastrpc: Free DMA handles for RPC calls with no arguments
  misc: fastrpc: Clean buffers on remote invocation failures

 drivers/misc/fastrpc.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

Comments

Caleb Connolly Oct. 1, 2023, 2:40 p.m. UTC | #1

On 29/09/2023 08:42, Ekansh Gupta wrote:
> This patchset carries the following fixes.
> - Reset metadata buffer to avoid incorrect fd getting freed
> - Free DMA handles for remote calls with no arguments
> - Clean buffers on remote call failures

Bit of a nit pick here, but you should try and use the cover letter to 
explain the necessary context and justification for your series. An 
overview of the commits is already included below by b4 or git-send-email.

It would be good to establish if these fixes are all related in some way 
(ie to enable a specific usecase), or if it's just a few random things 
that folks have discovered. Although it's almost always useful for 
maintainers to know how these issues where discovered as it could expose 
a gap in testing.

Regards,

> 
> Ekansh Gupta (3):
>    misc: fastrpc: Reset metadata buffer to avoid incorrect free
>    misc: fastrpc: Free DMA handles for RPC calls with no arguments
>    misc: fastrpc: Clean buffers on remote invocation failures
> 
>   drivers/misc/fastrpc.c | 26 ++++++++++++--------------
>   1 file changed, 12 insertions(+), 14 deletions(-)
>

Srinivas Kandagatla Oct. 9, 2023, 6:04 a.m. UTC | #2

On Fri, 29 Sep 2023 13:12:37 +0530, Ekansh Gupta wrote:
> This patchset carries the following fixes.
> - Reset metadata buffer to avoid incorrect fd getting freed
> - Free DMA handles for remote calls with no arguments
> - Clean buffers on remote call failures
> 
> Ekansh Gupta (3):
>   misc: fastrpc: Reset metadata buffer to avoid incorrect free
>   misc: fastrpc: Free DMA handles for RPC calls with no arguments
>   misc: fastrpc: Clean buffers on remote invocation failures
> 
> [...]

Applied, thanks!

[1/3] misc: fastrpc: Reset metadata buffer to avoid incorrect free
      commit: c44e396924d307ba11974b5f131e956b789a6844
[2/3] misc: fastrpc: Free DMA handles for RPC calls with no arguments
      commit: 3f01aaeb9fd387108c04c4803b949b8cd84d43ff
[3/3] misc: fastrpc: Clean buffers on remote invocation failures
      commit: 9fffb8240581927a71ed0ae46a5e269dbc0f3e3f

Best regards,