From patchwork Thu Dec 20 14:46:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balakrishna Godavarthi X-Patchwork-Id: 10739011 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A1D013AD for ; Thu, 20 Dec 2018 14:47:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2766E289B8 for ; Thu, 20 Dec 2018 14:47:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2571128AA1; Thu, 20 Dec 2018 14:47:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1CCB289B8 for ; Thu, 20 Dec 2018 14:46:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732721AbeLTOqv (ORCPT ); Thu, 20 Dec 2018 09:46:51 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53606 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730470AbeLTOqu (ORCPT ); Thu, 20 Dec 2018 09:46:50 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4FD52600E2; Thu, 20 Dec 2018 14:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1545317209; bh=+5JcqqY9KLQBPk9N8ttnos656n3P+frkzI0/tq446Ec=; h=From:To:Cc:Subject:Date:From; b=atse4HyqfrPpUxjV84G5Z8kmdg7eQX0X2ZEj01yS9cRy5jaUIZPOvHZSYwX5IhzPa supuYhFIoFqOwKrKeoAb+eaUad/TrApwcgI6s8q+BN5qh/rfcqnS59FU+Ywz6m4tKa IfZC/2pudfBgWr9DXJ1oQ0uBSAtdYa+xd8eNqRik= Received: from bgodavar-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bgodavar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1050E600E2; Thu, 20 Dec 2018 14:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1545317208; bh=+5JcqqY9KLQBPk9N8ttnos656n3P+frkzI0/tq446Ec=; h=From:To:Cc:Subject:Date:From; b=X+PiM9pnvM4tF8m46PYhvZ2JHjeVkuprzjD+54brMv0Hua6xPtFt1t1uVzg17Ttey k79HyJaYlpOwPbkrAiHJljVP2MTgAd82UMzHWMWrCqU9hh2VQ3ChfR+8r6kks880p5 tpdcjs698W5Fbi9VXEyoV3jXrfMcc5hzOFMTFibg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1050E600E2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=bgodavar@codeaurora.org From: Balakrishna Godavarthi To: marcel@holtmann.org, johan.hedberg@gmail.com, johan@kernel.org Cc: mka@chromium.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, Balakrishna Godavarthi Subject: [PATCH v5 0/5] Bug fixes for Qualcomm BT chip wcn3990 Date: Thu, 20 Dec 2018 20:16:34 +0530 Message-Id: <20181220144639.15928-1-bgodavar@codeaurora.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The below issues are found in the recent testing. 1. Observed device is not going into off state or not responding. As wcn3990 require a power pulses to turn on the irrespctive of igniting regulators, it was observed that power on or power off pulses are not in sync with respective to chip. The below patch will help us to wait until byte is pushed on to wires. * Bluetooth: hci_qca: use wait_until_sent() for power pulses 2. Observed Chip responding when we are in sleep. This is due to turn on flow control during change baudrate request. The below patch will only pull the RTS line high instead of turning off the flow. * Bluetooth: hci_qca: Pull RTS line high for baudrate change command. 3. Frame reassembly errors splashing on console. wcn3990 requires will use multiple baudrates during booting stage. i.e. 2400 bps while sending power off pulse 115200 bps while sending power on pulse port close port open set baudrate to 115200 request the chip version. during above process, we are seeing some stray bytes coming up on the UART Rx FIFO it could be due to frequent baudrate change. This patch will stop the frame reassembly errors. * Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 4. Disable IBS state machine and flush Tx buffer We are disabling IBS and flushing the Tx buffer before turning off the chip. This is due to IBS state machine is active when we turn off the chip. This will stop queuing IBS protocol bytes. * Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer 5. btqca: inject command complete event during fw download Qualcomm latest chip will not send an command complete event for last packet of the fw dump sent, so here we are inject an command complete event. * Bluetooth: btqca: inject command complete event during fw download Changes in V5: * added serdev_device_wrute_flush before sending the power off pulse during shutdown. Changes in v4: * used serdev_device_write_buf() instead of serdev_device_write(). * added new patch to stop logging of 0xfc00 timeout on console. Changes in v3: * moved IBS & qca_flush to different patch * updated comments in code fo Deassert RTS patch Balakrishna Godavarthi (5): Bluetooth: hci_qca: use wait_until_sent() for power pulses Bluetooth: hci_qca: Deassert RTS while baudrate change command Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Bluetooth: btqca: inject command complete event during fw download drivers/bluetooth/btqca.c | 39 ++++++++++++++++++- drivers/bluetooth/btqca.h | 3 ++ drivers/bluetooth/hci_qca.c | 78 +++++++++++++++++++++---------------- 3 files changed, 85 insertions(+), 35 deletions(-)