| Message ID | 20190219061800.31025-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: phy: at803x: Update delays for RGMII modes | expand |
Hi Vinod, On 19/02/2019 8.17, Vinod Koul wrote: > Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable > phy delay for RGMII mode") caused regression on am335x-evmsk board. > This board expects the Phy delay to be enabled but specified RGMII mode > which refers to delays being disabled. So fix this by disabling delay only > for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. > > While at it, as pointed by Dave, don't inline the helpers. > > [1]: https://www.spinics.net/lists/netdev/msg550749.html Not sure what was changed since v2, but with https://patchwork.ozlabs.org/project/netdev/list/?series=92672 ethernet is working on am335x-evmsk. thank you: Tested-by: Peter Ujfalusi <peter.ujflausi@ti.com> > Vinod Koul (2): > net: phy: at803x: don't inline helpers > net: phy: at803x: disable delay only for RGMII mode > > drivers/net/phy/at803x.c | 51 ++++++++++++++++++++++++++++++---------- > 1 file changed, 38 insertions(+), 13 deletions(-) > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") caused regression on am335x-evmsk board. This board expects the Phy delay to be enabled but specified RGMII mode which refers to delays being disabled. So fix this by disabling delay only for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. While at it, as pointed by Dave, don't inline the helpers. [1]: https://www.spinics.net/lists/netdev/msg550749.html Vinod Koul (2): net: phy: at803x: don't inline helpers net: phy: at803x: disable delay only for RGMII mode drivers/net/phy/at803x.c | 51 ++++++++++++++++++++++++++++++---------- 1 file changed, 38 insertions(+), 13 deletions(-)