mbox series

[00/10] Convert MSM8916 boards to use labels, reduce duplication

Message ID 20200720085406.6716-1-stephan@gerhold.net (mailing list archive)
Headers show
Series Convert MSM8916 boards to use labels, reduce duplication | expand

Message

Stephan Gerhold July 20, 2020, 8:53 a.m. UTC
Board device trees for newer SoCs reference labels to override properties
for components of the SoC. This patch series converts all MSM8916 boards to
use the same style.

Additionally, in the second part of the series I attempt to reduce duplication
within the MSM8916 board device trees a bit. If we keep copying a large number
of properties to each and every board of a SoC then (in my opinion)
it makes sense to consider if those can be shared in some include.

This will make it easier to add new boards in the future.

Stephan Gerhold (10):
  arm64: dts: qcom: apq8016-sbc: Remove properties that are already
    default
  arm64: dts: qcom: msm8916: Declare sound node in msm8916.dtsi
  arm64: dts: qcom: apq8016-sbc: Define leds outside of soc node
  arm64: dts: qcom: msm8916: Add more labels
  arm64: dts: qcom: msm8916: Use labels in board device trees
  arm64: dts: qcom: pm8916: Add resin node
  arm64: dts: qcom: msm8916: Move PM8916-specific parts to
    msm8916-pm8916.dtsi
  arm64: dts: qcom: msm8916: Move more supplies to msm8916-pm8916.dtsi
  arm64: dts: qcom: msm8916: Set default pinctrl for blsp1_uart1/2
  arm64: dts: qcom: msm8916: Move common USB properties to msm8916.dtsi

 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi     | 900 ++++++++----------
 .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 108 +--
 arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi     |  14 +-
 arch/arm64/boot/dts/qcom/msm8916-pm8916.dtsi  |  79 ++
 .../qcom/msm8916-samsung-a2015-common.dtsi    | 130 +--
 arch/arm64/boot/dts/qcom/msm8916.dtsi         |  99 +-
 arch/arm64/boot/dts/qcom/pm8916.dtsi          |   8 +
 7 files changed, 625 insertions(+), 713 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-pm8916.dtsi

--
2.27.0

Comments

Stephan Gerhold Sept. 14, 2020, 9:43 a.m. UTC | #1
Hi Bjorn,

On Mon, Jul 20, 2020 at 10:53:56AM +0200, Stephan Gerhold wrote:
> Board device trees for newer SoCs reference labels to override properties
> for components of the SoC. This patch series converts all MSM8916 boards to
> use the same style.
> 
> Additionally, in the second part of the series I attempt to reduce duplication
> within the MSM8916 board device trees a bit. If we keep copying a large number
> of properties to each and every board of a SoC then (in my opinion)
> it makes sense to consider if those can be shared in some include.
> 
> This will make it easier to add new boards in the future.
> 
> Stephan Gerhold (10):
>   arm64: dts: qcom: apq8016-sbc: Remove properties that are already
>     default
>   arm64: dts: qcom: msm8916: Declare sound node in msm8916.dtsi
>   arm64: dts: qcom: apq8016-sbc: Define leds outside of soc node
>   arm64: dts: qcom: msm8916: Add more labels
>   arm64: dts: qcom: msm8916: Use labels in board device trees
>   arm64: dts: qcom: pm8916: Add resin node
>   arm64: dts: qcom: msm8916: Move PM8916-specific parts to
>     msm8916-pm8916.dtsi
>   arm64: dts: qcom: msm8916: Move more supplies to msm8916-pm8916.dtsi
>   arm64: dts: qcom: msm8916: Set default pinctrl for blsp1_uart1/2
>   arm64: dts: qcom: msm8916: Move common USB properties to msm8916.dtsi
> 

It's been two months since I sent this series - are there any changes
I should make? Maybe you just overlooked it :)

Would be great to make some progress since I have a few more patch
series ready to send out that build on top of this one (some more
cleanup for MSM8916, converting MSM8916 to use rpmpd power domains, ...)

Thanks!
Stephan
Bjorn Andersson Sept. 15, 2020, 4:56 a.m. UTC | #2
On Mon 14 Sep 04:43 CDT 2020, Stephan Gerhold wrote:

> Hi Bjorn,
> 
> On Mon, Jul 20, 2020 at 10:53:56AM +0200, Stephan Gerhold wrote:
> > Board device trees for newer SoCs reference labels to override properties
> > for components of the SoC. This patch series converts all MSM8916 boards to
> > use the same style.
> > 
> > Additionally, in the second part of the series I attempt to reduce duplication
> > within the MSM8916 board device trees a bit. If we keep copying a large number
> > of properties to each and every board of a SoC then (in my opinion)
> > it makes sense to consider if those can be shared in some include.
> > 
> > This will make it easier to add new boards in the future.
> > 
> > Stephan Gerhold (10):
> >   arm64: dts: qcom: apq8016-sbc: Remove properties that are already
> >     default
> >   arm64: dts: qcom: msm8916: Declare sound node in msm8916.dtsi
> >   arm64: dts: qcom: apq8016-sbc: Define leds outside of soc node
> >   arm64: dts: qcom: msm8916: Add more labels
> >   arm64: dts: qcom: msm8916: Use labels in board device trees
> >   arm64: dts: qcom: pm8916: Add resin node
> >   arm64: dts: qcom: msm8916: Move PM8916-specific parts to
> >     msm8916-pm8916.dtsi
> >   arm64: dts: qcom: msm8916: Move more supplies to msm8916-pm8916.dtsi
> >   arm64: dts: qcom: msm8916: Set default pinctrl for blsp1_uart1/2
> >   arm64: dts: qcom: msm8916: Move common USB properties to msm8916.dtsi
> > 
> 
> It's been two months since I sent this series - are there any changes
> I should make? Maybe you just overlooked it :)
> 

It seems to have been overlooked as we approached the v5.9 merge window.
I don't have any complaints and have merge the series now.

Thanks,
Bjorn

> Would be great to make some progress since I have a few more patch
> series ready to send out that build on top of this one (some more
> cleanup for MSM8916, converting MSM8916 to use rpmpd power domains, ...)
> 
> Thanks!
> Stephan
Stephan Gerhold Sept. 15, 2020, 7:16 a.m. UTC | #3
On Mon, Sep 14, 2020 at 11:56:05PM -0500, Bjorn Andersson wrote:
> On Mon 14 Sep 04:43 CDT 2020, Stephan Gerhold wrote:
> > 
> > It's been two months since I sent this series - are there any changes
> > I should make? Maybe you just overlooked it :)
> > 
> 
> It seems to have been overlooked as we approached the v5.9 merge window.
> I don't have any complaints and have merge the series now.
> 

Great, I used the chance and sent out the next series :)

Thank you!
Stephan