From patchwork Wed Jul 28 16:45:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12406373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6BDC4320A for ; Wed, 28 Jul 2021 16:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 567CD60F01 for ; Wed, 28 Jul 2021 16:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbhG1Qq0 (ORCPT ); Wed, 28 Jul 2021 12:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbhG1Qq0 (ORCPT ); Wed, 28 Jul 2021 12:46:26 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A008FC061757 for ; Wed, 28 Jul 2021 09:46:24 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id a4-20020a17090aa504b0290176a0d2b67aso10983162pjq.2 for ; Wed, 28 Jul 2021 09:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3Wf14gG5Rla0NCThAzrC4jotbBpcH9EXwPpxX3uNRjo=; b=EtlAYDaEc0TpuNyXhqKi50L3nKK4in1bT8Phheri8gREf7P5NrxJ2A29bcz9tTkNV4 KMxG0EH+veKm8iIIsYG68Hmklfn+DxuQp9m7Kv3Wqy4kOtalb2dvdpSOmUM0aFyN6p9x 8aa2qd57b8OCOv02Ru/xKrV2Y1aghXj14dmi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3Wf14gG5Rla0NCThAzrC4jotbBpcH9EXwPpxX3uNRjo=; b=UaavDQVfTW+5gGiyk8ilz8nJ22cu8mQaYg+OrY8nhyZdrn9fPc2gTRep1J8rlcpxIk ntnpBSzGts6fZe3nOqw69pLRDok8BMC2U/yN8UmVNB1H/0kMNmk++TEGdXtpMOL/AkaV LlQkuGANvok5IsvgzMPUKxk7Rasu/vCa1zNTBtrKMtXHNw6fswnA5/bz/5MR9XLQYgp+ PnheLbmfe/er+sdNGW1DjFsVSH71AnTIgAoX7fSATdoOV18CzelwakPd6eEM1rm8lC1H whYr+IaI2vQMVdRx5yKvqEMDFrXs4l0ATGtaGnFl8gvbwGcgWApUpqGIB9eCxe7WAA/M T+0A== X-Gm-Message-State: AOAM533azyn7kX2vUDa8TYQ+hW3qD0TZqicxy8Pw4PnA5HLGdS0cE+6y y4EQ2KsJZopfxPDruZkuNciW3g== X-Google-Smtp-Source: ABdhPJzfO4KkJpCh98jEoXUePNoIZEGk1qRg4kKFgs4O1HX2oxNwF0DCb/etyqdvMdxChckiCrP56g== X-Received: by 2002:a65:4382:: with SMTP id m2mr656852pgp.205.1627490784259; Wed, 28 Jul 2021 09:46:24 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:9f1e:e713:1a5e:89dc]) by smtp.gmail.com with ESMTPSA id l12sm474075pff.182.2021.07.28.09.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 09:46:23 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org Cc: tzimmermann@suse.de, linux-arm-msm@vger.kernel.org, a.hajda@samsung.com, sam@ravnborg.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, devicetree@vger.kernel.org, rodrigo.vivi@intel.com, jonas@kwiboo.se, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, robert.foss@linaro.org, jernej.skrabec@gmail.com, mripard@kernel.org, linus.walleij@linaro.org, maarten.lankhorst@linux.intel.com, rajeevny@codeaurora.org, lyude@redhat.com, thierry.reding@gmail.com, steev@kali.org, Douglas Anderson , Sandeep Panda , linux-kernel@vger.kernel.org Subject: [PATCH 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel Date: Wed, 28 Jul 2021 09:45:51 -0700 Message-Id: <20210728164557.1882787-1-dianders@chromium.org> X-Mailer: git-send-email 2.32.0.432.gabb21c7263-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The overall goal of this series is to make the Samsung ATNA33XC20 panel work more properly. As part of this, we have: * A bugfix for the recently abstracted DP AUX backlight code. * A bugfix for the sequencing of the ti-sn65dsi86 bridge driver. * Removal of the panel from panel-simple and moving it to its own driver. If the bugfixes look good but the rest of the series needs work then those could land early on their own. There's no real compile time dependency on the bugfixes, things are just glitchier without them. NOTE: this series will (slightly) conflict with my other recent series making eDP panels probable [1]. The conflict is easy to resolve and I'm happy to repost either once the other lands. It should be noted that the fact that the Samsung ATNA33XC20 needs its own panel driver means that it _can't_ handled as a probed driver. I think this is fine, at least for now. I don't think it would be easy to make a unified design with this panel and other panels given that it's an AMOLED panel and has a whole bunch of different components on board. [1] https://lore.kernel.org/r/20210723002146.1962910-1-dianders@chromium.org/ Douglas Anderson (6): drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not specified drm/bridge: ti-sn65dsi86: Fix power off sequence drm/bridge: ti-sn65dsi86: Add some 100 us delays Revert "drm/panel-simple: Add Samsung ATNA33XC20" Revert "drm/panel-simple: Support for delays between GPIO & regulator" drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel drivers/gpu/drm/bridge/ti-sn65dsi86.c | 17 +- drivers/gpu/drm/drm_dp_helper.c | 10 +- drivers/gpu/drm/panel/Kconfig | 12 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-samsung-atna33xc20.c | 366 ++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 61 --- 6 files changed, 398 insertions(+), 69 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-samsung-atna33xc20.c Reviewed-by: Sean Paul