mbox series

[v2,0/11] interconnect: merge AP-owned support into icc-rpm

Message ID 20210903232421.1384199-1-dmitry.baryshkov@linaro.org (mailing list archive)
Headers show
Series interconnect: merge AP-owned support into icc-rpm | expand

Message

Dmitry Baryshkov Sept. 3, 2021, 11:24 p.m. UTC
This patch series merges support for AP-owned and bus QoS from SDM660
into common code (icc-rpm.c). MSM8916 and MSM8939 support code is
extended to support these features. As I was touching these drivers, per
Bjorn's suggestion expand DEFINE_QNODE macros (which makes adding
QoS support much easier to review).

Dependencies:
 - https://lore.kernel.org/linux-arm-msm/20210902054915.28689-1-shawn.guo@linaro.org/
 - https://lore.kernel.org/linux-arm-msm/20210823014003.31391-1-shawn.guo@linaro.org/
 - https://lore.kernel.org/linux-arm-msm/20210824043435.23190-1-shawn.guo@linaro.org/

Changes since v1:
 - Rebase on top a2noc clocks support patch.
 - Expand DEFINE_QNODE
 - Simplify struct qcom_icc_node by moving links to separate array

----------------------------------------------------------------
Dmitry Baryshkov (11):
      interconnect: icc-rpm: move bus clocks handling into qnoc_probe
      interconnect: sdm660: expand DEFINE_QNODE macros
      interconnect: sdm660: drop default/unused values
      interconnect: sdm660: merge common code into icc-rpm
      interconnect: icc-rpm: add support for QoS reg offset
      interconnect: msm8916: expand DEFINE_QNODE macros
      interconnect: msm8916: add support for AP-owned nodes
      interconnect: msm8939: expand DEFINE_QNODE macros
      interconnect: msm8939: add support for AP-owned nodes
      interconnect: qcs404: expand DEFINE_QNODE macros
      interconnect: qcom: drop DEFINE_QNODE macro

 drivers/interconnect/qcom/icc-rpm.c |  263 ++++-
 drivers/interconnect/qcom/icc-rpm.h |   56 +-
 drivers/interconnect/qcom/msm8916.c | 1214 ++++++++++++++++++++--
 drivers/interconnect/qcom/msm8939.c | 1283 +++++++++++++++++++++--
 drivers/interconnect/qcom/qcs404.c  |  967 +++++++++++++++--
 drivers/interconnect/qcom/sdm660.c  | 1940 ++++++++++++++++++++++++-----------
 6 files changed, 4815 insertions(+), 908 deletions(-)

Comments

Shawn Guo Sept. 6, 2021, 5:42 a.m. UTC | #1
On Sat, Sep 04, 2021 at 02:24:10AM +0300, Dmitry Baryshkov wrote:
> This patch series merges support for AP-owned and bus QoS from SDM660
> into common code (icc-rpm.c). MSM8916 and MSM8939 support code is
> extended to support these features. As I was touching these drivers, per
> Bjorn's suggestion expand DEFINE_QNODE macros (which makes adding
> QoS support much easier to review).
> 
> Dependencies:
>  - https://lore.kernel.org/linux-arm-msm/20210902054915.28689-1-shawn.guo@linaro.org/
>  - https://lore.kernel.org/linux-arm-msm/20210823014003.31391-1-shawn.guo@linaro.org/
>  - https://lore.kernel.org/linux-arm-msm/20210824043435.23190-1-shawn.guo@linaro.org/
> 
> Changes since v1:
>  - Rebase on top a2noc clocks support patch.
>  - Expand DEFINE_QNODE
>  - Simplify struct qcom_icc_node by moving links to separate array
> 
> ----------------------------------------------------------------
> Dmitry Baryshkov (11):
>       interconnect: icc-rpm: move bus clocks handling into qnoc_probe
>       interconnect: sdm660: expand DEFINE_QNODE macros
>       interconnect: sdm660: drop default/unused values
>       interconnect: sdm660: merge common code into icc-rpm
>       interconnect: icc-rpm: add support for QoS reg offset
>       interconnect: msm8916: expand DEFINE_QNODE macros
>       interconnect: msm8916: add support for AP-owned nodes
>       interconnect: msm8939: expand DEFINE_QNODE macros
>       interconnect: msm8939: add support for AP-owned nodes
>       interconnect: qcs404: expand DEFINE_QNODE macros
>       interconnect: qcom: drop DEFINE_QNODE macro

On MSM8939 and SDM660:

Tested-by: Shawn Guo <shawn.guo@linaro.org>
Dmitry Baryshkov Sept. 25, 2021, 7:40 p.m. UTC | #2
On 04/09/2021 02:24, Dmitry Baryshkov wrote:
> This patch series merges support for AP-owned and bus QoS from SDM660
> into common code (icc-rpm.c). MSM8916 and MSM8939 support code is
> extended to support these features. As I was touching these drivers, per
> Bjorn's suggestion expand DEFINE_QNODE macros (which makes adding
> QoS support much easier to review).
> 
> Dependencies:
>   - https://lore.kernel.org/linux-arm-msm/20210902054915.28689-1-shawn.guo@linaro.org/
>   - https://lore.kernel.org/linux-arm-msm/20210823014003.31391-1-shawn.guo@linaro.org/
>   - https://lore.kernel.org/linux-arm-msm/20210824043435.23190-1-shawn.guo@linaro.org/
> 
> Changes since v1:
>   - Rebase on top a2noc clocks support patch.
>   - Expand DEFINE_QNODE
>   - Simplify struct qcom_icc_node by moving links to separate array

Georgi, since all dependencies were pulled in by you, I wanted to 
remind/ask: do you intend to pull this patchset for 5.16?

> 
> ----------------------------------------------------------------
> Dmitry Baryshkov (11):
>        interconnect: icc-rpm: move bus clocks handling into qnoc_probe
>        interconnect: sdm660: expand DEFINE_QNODE macros
>        interconnect: sdm660: drop default/unused values
>        interconnect: sdm660: merge common code into icc-rpm
>        interconnect: icc-rpm: add support for QoS reg offset
>        interconnect: msm8916: expand DEFINE_QNODE macros
>        interconnect: msm8916: add support for AP-owned nodes
>        interconnect: msm8939: expand DEFINE_QNODE macros
>        interconnect: msm8939: add support for AP-owned nodes
>        interconnect: qcs404: expand DEFINE_QNODE macros
>        interconnect: qcom: drop DEFINE_QNODE macro
> 
>   drivers/interconnect/qcom/icc-rpm.c |  263 ++++-
>   drivers/interconnect/qcom/icc-rpm.h |   56 +-
>   drivers/interconnect/qcom/msm8916.c | 1214 ++++++++++++++++++++--
>   drivers/interconnect/qcom/msm8939.c | 1283 +++++++++++++++++++++--
>   drivers/interconnect/qcom/qcs404.c  |  967 +++++++++++++++--
>   drivers/interconnect/qcom/sdm660.c  | 1940 ++++++++++++++++++++++++-----------
>   6 files changed, 4815 insertions(+), 908 deletions(-)
> 
>
Georgi Djakov Oct. 4, 2021, 11:56 a.m. UTC | #3
On 25.09.21 22:40, Dmitry Baryshkov wrote:
> On 04/09/2021 02:24, Dmitry Baryshkov wrote:
>> This patch series merges support for AP-owned and bus QoS from SDM660
>> into common code (icc-rpm.c). MSM8916 and MSM8939 support code is
>> extended to support these features. As I was touching these drivers, per
>> Bjorn's suggestion expand DEFINE_QNODE macros (which makes adding
>> QoS support much easier to review).
>>
>> Dependencies:
>>   - 
>> https://lore.kernel.org/linux-arm-msm/20210902054915.28689-1-shawn.guo@linaro.org/ 
>>
>>   - 
>> https://lore.kernel.org/linux-arm-msm/20210823014003.31391-1-shawn.guo@linaro.org/ 
>>
>>   - 
>> https://lore.kernel.org/linux-arm-msm/20210824043435.23190-1-shawn.guo@linaro.org/ 
>>
>>
>> Changes since v1:
>>   - Rebase on top a2noc clocks support patch.
>>   - Expand DEFINE_QNODE
>>   - Simplify struct qcom_icc_node by moving links to separate array
> 
> Georgi, since all dependencies were pulled in by you, I wanted to 
> remind/ask: do you intend to pull this patchset for 5.16?

Hi Dmitry,
Yes, that's the plan. I just responded with a few minor comments/fixes
to some of the patches. I can just fix them before applying, if you are
fine with these.

Thanks again to all the people involved with this patchset!

Thanks,
Georgi

> 
>>
>> ----------------------------------------------------------------
>> Dmitry Baryshkov (11):
>>        interconnect: icc-rpm: move bus clocks handling into qnoc_probe
>>        interconnect: sdm660: expand DEFINE_QNODE macros
>>        interconnect: sdm660: drop default/unused values
>>        interconnect: sdm660: merge common code into icc-rpm
>>        interconnect: icc-rpm: add support for QoS reg offset
>>        interconnect: msm8916: expand DEFINE_QNODE macros
>>        interconnect: msm8916: add support for AP-owned nodes
>>        interconnect: msm8939: expand DEFINE_QNODE macros
>>        interconnect: msm8939: add support for AP-owned nodes
>>        interconnect: qcs404: expand DEFINE_QNODE macros
>>        interconnect: qcom: drop DEFINE_QNODE macro
>>
>>   drivers/interconnect/qcom/icc-rpm.c |  263 ++++-
>>   drivers/interconnect/qcom/icc-rpm.h |   56 +-
>>   drivers/interconnect/qcom/msm8916.c | 1214 ++++++++++++++++++++--
>>   drivers/interconnect/qcom/msm8939.c | 1283 +++++++++++++++++++++--
>>   drivers/interconnect/qcom/qcs404.c  |  967 +++++++++++++++--
>>   drivers/interconnect/qcom/sdm660.c  | 1940 
>> ++++++++++++++++++++++++-----------
>>   6 files changed, 4815 insertions(+), 908 deletions(-)
>>
>>
> 
>
Dmitry Baryshkov Oct. 4, 2021, 12:37 p.m. UTC | #4
On Mon, 4 Oct 2021 at 14:56, Georgi Djakov <djakov@kernel.org> wrote:
>
> On 25.09.21 22:40, Dmitry Baryshkov wrote:
> > On 04/09/2021 02:24, Dmitry Baryshkov wrote:
> >> This patch series merges support for AP-owned and bus QoS from SDM660
> >> into common code (icc-rpm.c). MSM8916 and MSM8939 support code is
> >> extended to support these features. As I was touching these drivers, per
> >> Bjorn's suggestion expand DEFINE_QNODE macros (which makes adding
> >> QoS support much easier to review).
> >>
> >> Dependencies:
> >>   -
> >> https://lore.kernel.org/linux-arm-msm/20210902054915.28689-1-shawn.guo@linaro.org/
> >>
> >>   -
> >> https://lore.kernel.org/linux-arm-msm/20210823014003.31391-1-shawn.guo@linaro.org/
> >>
> >>   -
> >> https://lore.kernel.org/linux-arm-msm/20210824043435.23190-1-shawn.guo@linaro.org/
> >>
> >>
> >> Changes since v1:
> >>   - Rebase on top a2noc clocks support patch.
> >>   - Expand DEFINE_QNODE
> >>   - Simplify struct qcom_icc_node by moving links to separate array
> >
> > Georgi, since all dependencies were pulled in by you, I wanted to
> > remind/ask: do you intend to pull this patchset for 5.16?
>
> Hi Dmitry,
> Yes, that's the plan. I just responded with a few minor comments/fixes
> to some of the patches. I can just fix them before applying, if you are
> fine with these.

Yes, I'm fine with your fixes. Please use them and apply the patchset.
Thank you!

>
> Thanks again to all the people involved with this patchset!
>
> Thanks,
> Georgi
>
> >
> >>
> >> ----------------------------------------------------------------
> >> Dmitry Baryshkov (11):
> >>        interconnect: icc-rpm: move bus clocks handling into qnoc_probe
> >>        interconnect: sdm660: expand DEFINE_QNODE macros
> >>        interconnect: sdm660: drop default/unused values
> >>        interconnect: sdm660: merge common code into icc-rpm
> >>        interconnect: icc-rpm: add support for QoS reg offset
> >>        interconnect: msm8916: expand DEFINE_QNODE macros
> >>        interconnect: msm8916: add support for AP-owned nodes
> >>        interconnect: msm8939: expand DEFINE_QNODE macros
> >>        interconnect: msm8939: add support for AP-owned nodes
> >>        interconnect: qcs404: expand DEFINE_QNODE macros
> >>        interconnect: qcom: drop DEFINE_QNODE macro
> >>
> >>   drivers/interconnect/qcom/icc-rpm.c |  263 ++++-
> >>   drivers/interconnect/qcom/icc-rpm.h |   56 +-
> >>   drivers/interconnect/qcom/msm8916.c | 1214 ++++++++++++++++++++--
> >>   drivers/interconnect/qcom/msm8939.c | 1283 +++++++++++++++++++++--
> >>   drivers/interconnect/qcom/qcs404.c  |  967 +++++++++++++++--
> >>   drivers/interconnect/qcom/sdm660.c  | 1940
> >> ++++++++++++++++++++++++-----------
> >>   6 files changed, 4815 insertions(+), 908 deletions(-)
> >>
> >>
> >
> >
>