From patchwork Mon Feb 21 22:07:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 12754189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B827BC433FE for ; Mon, 21 Feb 2022 22:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235145AbiBUWIW (ORCPT ); Mon, 21 Feb 2022 17:08:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbiBUWIW (ORCPT ); Mon, 21 Feb 2022 17:08:22 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 085DDE5A for ; Mon, 21 Feb 2022 14:07:58 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id j22so3274260wrb.13 for ; Mon, 21 Feb 2022 14:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F7fyemQ2BVzVv41p1XxqDVmDovrL3PRCBOTj4zsaHkI=; b=jPuFIvNP3oEPjlk+ozwqERct0a6ZHwgEeaxp9Rp8RsevW7kIYpU3RQAJUAdha/pyWN lbRw8DQX9Q0uZHg/Ozwe6HGOumcSqITEFVxBBNRSnMiLI5awFIHGCctUxDZ3mY2P7qqF f0mBEJKOZu+X+BolUGX+Fj/uXrDlzjzdGpLqp+b13ANlrMLc9ppVWIxOr/a7PMGXjEp0 ej1MrSLuJJZbo/RdFRpMtozH1T+ObLf8RhpwD9p7GKPEqKDs8Bi5ZJABwvXCDH6BWEvC 5cfVC4D77mtbLoOQmoT64GAxLc6+owW04lNH5pYvIgxl2EHUpuYGEdQvKWnNxs5TedWN tTYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F7fyemQ2BVzVv41p1XxqDVmDovrL3PRCBOTj4zsaHkI=; b=DJsO+vx5VqaLeu9Hf0rI3dHLLECATrIkPupWa8V4eH/ERw5dtBNy0UBv1D6Y2+f26j I2mY95fJ8oOtdstlxk+ykZtKGW29/xNRcacRVZ2AmTrKFd2jaDKWJyUbM0L8nB4IacEV Xt+q83aQWIJcb8YPvlBo+hmTf9pC8MUPAoZc5+/hLezhebuWMh/yUUOkoucu/cyrSYN+ MxrOF+KeVIkh4UnqoN8iM8USLSZic5+c2HHM4vTNYRXSxF5hrdzTPORc+nCmpf81X/pn Ifrv65hCt6icJgDv4wGH6N9ntIk/2pwwUf5sMedyi8ysYmdWPuICZNn6IFSpsdZw9GES fwgQ== X-Gm-Message-State: AOAM533B/iPbYOq2mDQ3haVqu15qkVnKyJWCJgokoFus2T+/xaMReOWa +SBGMEcRt/znaLfKcsgzVgJ0Zg== X-Google-Smtp-Source: ABdhPJxbQ9D0pYm7tUrTIY4lc6P/XR1X8/t6g8N1Or3yqE6+dSSYYIgO6VvqxjVkMzkqor7nA/EJYA== X-Received: by 2002:a5d:6a0f:0:b0:1e5:53db:4ddd with SMTP id m15-20020a5d6a0f000000b001e553db4dddmr17231260wru.614.1645481276612; Mon, 21 Feb 2022 14:07:56 -0800 (PST) Received: from localhost.localdomain (cpc78119-cwma10-2-0-cust590.7-3.cable.virginm.net. [81.96.50.79]) by smtp.gmail.com with ESMTPSA id w8sm51626093wre.83.2022.02.21.14.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 14:07:56 -0800 (PST) From: Caleb Connolly To: caleb.connolly@linaro.org, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Lee Jones , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: sumit.semwal@linaro.org, amit.pundir@linaro.org, john.stultz@linaro.org Subject: [PATCH v8 0/9] iio: adc: introduce Qualcomm SPMI Round Robin ADC Date: Mon, 21 Feb 2022 22:07:34 +0000 Message-Id: <20220221220743.541704-1-caleb.connolly@linaro.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The RRADC is responsible for reading data about the current and voltage from the USB or DC in jacks, it can also read the battery ID (resistence) and some temperatures. It is found on the PMI8998 and PM660 Qualcomm PMICs. The RRADC has to calibrate some ADC values based on which chip fab the PMIC was produced in, to facilitate this the patches ("mfd: qcom-spmi-pmic: expose the PMIC revid information to clients") and ("mfd: qcom-spmi-pmic: read fab id on supported PMICs") expose the PMIC revision information and fab_id as a struct and register them as driver data in the Qualcomm SPMI PMIC driver so that it can be read by the RRADC. The first 3 patches add support for looking up an SPMI device from a struct device_node, as well as introducing support for looking up the base USID of a Qcom PMIC, see patch comments for more details. These Address Bjorns comments on v2. Changes since v7: * Addressed Jonathans comments * Fixed bug reported by LKP Changes since v6: * Fix printf format warning in rradc Changes since v5: * Add missing EXPORT_SYMBOL_GPL() to ("spmi: add a helper to look up an SPMI device from a device node") Changes since v4: * Addressed Jonathan's comments on v4 * Reworked the qcom-spmi-pmic patches to properly walk the devicetree to find the base USID. I've tested this on SDM845 which has two PMICs (pm8998 and pmi8998) and I'm able to look up the PMIC revid from all 4 USIDs. Changes since v3: * Split PMIC patch in two, rework to support function drivers on a sibling USID * Completely rework RRADC driver to make use of the modern IIO framework. This required re-arranging a lot of the equations and results in some lost precision, where relevant I've left comments to explain this. I don't think any of it is significant enough to justify doing post-processing in driver. Thanks a lot Jonathan and John Stultz for helping me out with this Changes since v2: * Add missing include (thanks kernel test robot :D) * Rework some confusing function return values, specifically rradc_read_status_in_cont_mode and rradc_prepare_batt_id_conversion both of which didn't correctly handle "ret". This also bought up an issue as the previous implementation didn't actually wait for the channel to be ready. It doesn't seem like that's strictly necessary (same data is reported if I wait for the status to be good or not) but I've included it anyway for good measure. Changes since v1: * Rework the RRADC driver based on Jonathan's feedback * Pick up Rob's reviewed by for the dt-binding patch. -- Caleb Connolly (9): spmi: add a helper to look up an SPMI device from a device node mfd: qcom-spmi-pmic: expose the PMIC revid information to clients mfd: qcom-spmi-pmic: read fab id on supported PMICs dt-bindings: iio: adc: document qcom-spmi-rradc iio: adc: qcom-spmi-rradc: introduce round robin adc arm64: dts: qcom: pmi8998: add rradc node arm64: dts: qcom: sdm845-oneplus: enable rradc arm64: dts: qcom: sdm845-db845c: enable rradc arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc .../bindings/iio/adc/qcom,spmi-rradc.yaml | 54 + arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 + arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 + .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 + .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 4 + drivers/iio/adc/Kconfig | 12 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/qcom-spmi-rradc.c | 1011 +++++++++++++++++ drivers/mfd/qcom-spmi-pmic.c | 181 ++- drivers/spmi/spmi.c | 17 + include/linux/spmi.h | 2 + include/soc/qcom/qcom-spmi-pmic.h | 61 + 12 files changed, 1303 insertions(+), 56 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml create mode 100644 drivers/iio/adc/qcom-spmi-rradc.c create mode 100644 include/soc/qcom/qcom-spmi-pmic.h