From patchwork Wed Mar 30 20:47:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 12796342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F7EC433FE for ; Wed, 30 Mar 2022 20:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351102AbiC3Uth (ORCPT ); Wed, 30 Mar 2022 16:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232265AbiC3Utg (ORCPT ); Wed, 30 Mar 2022 16:49:36 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 400E146B23; Wed, 30 Mar 2022 13:47:50 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id t2so19921071pfj.10; Wed, 30 Mar 2022 13:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yfjnQPsWSYFHa6/IEHWm+/2wuddS77YFSoX6K2k8WAs=; b=qC4uOR8IOWShCZwjgvJri6DARkuzz2I9SZJDZ4AvTXi1tq3hxOQJsE5l+kifQk5SWn u40vr1x2VFiEtk3vBCqTVqmO0p/2YSgtbYUP2g3+DyGI7yF6Pcv9GYZ8TPiMjcwBL90B gPHyEtrZstP5e410DG2KyJ4MSyFaYsXCQy676NuLB9m2dsG5YKSI0+UkCp2tPFMgv0n7 u65aV4R7tkt+uRyuMygRTiS54EViRC/Fn2lir4czlzavyzwfI4JPjdtUI7Q+j8BDpEl1 Xb2spl5hCkconGmuduSGN3E2H08Az6ON3hZPlRGUwWJaMcao369mKCR4msi7uWgQ03KN OovQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yfjnQPsWSYFHa6/IEHWm+/2wuddS77YFSoX6K2k8WAs=; b=aSnZn04+ydPKTlo5nXxcNuY0w+34iQsihnZrKwSFjGMZ1uJ0ma1oyt4vE52ShZ1e3V XONfJG29SO+uM9cSoyJzE8Ii+ejNAV9QUcTn2Y65i2AiWs0h9TV6WqXOW4ZVqgn0S58V poXNeRXbITKTPzohD8JN4PO2LJd6qG/ijhkCX48tK7jyp1iTOV09y9ECPCPcpf5zlrD4 L9ADgj5Gzxp58j7YRpaE4FctO21OBxZAGi0vlKbQCSSLk0R3a9jHUt4/lXzK2qpKf74h gZkqsPj/DZBiOMaC0malZWuAz25P0EFdTIsgJJu6hW7pDe1KSPXs6mO1sMRzHmEC+GVR 63JQ== X-Gm-Message-State: AOAM531zv5Abc0nRzyI/rjH04JNUNHQQ4I9vaRiaEBG0DS4gQsbbLIUj IAqjPc68f+VNiRCBxv6G78d9d/tpkq8= X-Google-Smtp-Source: ABdhPJxdLzVjn+t+OSFNxjZRQ67GvD+fwncEqPMil8nBUspK/F9AqvVDwI9XWwz2gknTpciSuqo5oQ== X-Received: by 2002:a63:ea0e:0:b0:37d:f227:ec57 with SMTP id c14-20020a63ea0e000000b0037df227ec57mr7536833pgi.441.1648673269692; Wed, 30 Mar 2022 13:47:49 -0700 (PDT) Received: from localhost ([2a00:79e1:abd:4a00:2703:3c72:eb1a:cffd]) by smtp.gmail.com with ESMTPSA id a7-20020aa79707000000b004fb17ad3aefsm19836938pfg.108.2022.03.30.13.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 13:47:48 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Dmitry Osipenko , Rob Clark , Abhinav Kumar , Akhil P Oommen , Bjorn Andersson , =?utf-8?q?Christian_K=C3=B6ni?= =?utf-8?q?g?= , Dan Carpenter , Jonathan Marek , Jordan Crouse , linux-kernel@vger.kernel.org (open list), Vladimir Lypak , Yangtao Li Subject: [PATCH v2 00/10] drm/msm: Userspace allocated GPU addresses Date: Wed, 30 Mar 2022 13:47:45 -0700 Message-Id: <20220330204804.660819-1-robdclark@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Rob Clark The first six paches are various cleanups and simplifications. The next two get rid of redundant vma lookups in the submit and retire paths. Following that, fenced vma lets us indicate a fence value following which the vma is no longer used, which is needed because otherwise userspace could observe the signaled fence prior to retire_submits() finishing. (With userspace allocated GPU addresses userspace is tracking when a buffer is no longer used and it's vma can be deleted.) And finally the last patch adds the new uabi for user- space allocated iova. v2: Fix inuse check in last patch, split GEM_WARN_ON() conversion to separate patch, and nits Rob Clark (10): drm/msm/gem: Move prototypes drm/msm/gpu: Drop duplicate fence counter drm/msm/gem: Convert some missed GEM_WARN_ON()s drm/msm/gem: Split out inuse helper drm/msm/gem: Drop PAGE_SHIFT for address space mm drm/msm: Drop msm_gem_iova() drm/msm/gem: Rework vma lookup and pin drm/msm/gem: Split vma lookup and pin drm/msm/gem: Add fenced vma unpin drm/msm: Add a way for userspace to allocate GPU iova drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 ++- drivers/gpu/drm/msm/msm_drv.c | 21 ++++ drivers/gpu/drm/msm/msm_drv.h | 23 ---- drivers/gpu/drm/msm/msm_fb.c | 16 ++- drivers/gpu/drm/msm/msm_fence.c | 6 +- drivers/gpu/drm/msm/msm_fence.h | 3 + drivers/gpu/drm/msm/msm_gem.c | 151 ++++++++++++++---------- drivers/gpu/drm/msm/msm_gem.h | 47 +++++++- drivers/gpu/drm/msm/msm_gem_submit.c | 17 ++- drivers/gpu/drm/msm/msm_gem_vma.c | 59 ++++++--- drivers/gpu/drm/msm/msm_gpu.c | 8 +- drivers/gpu/drm/msm/msm_gpu.h | 2 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 12 +- drivers/gpu/drm/msm/msm_ringbuffer.h | 1 - include/uapi/drm/msm_drm.h | 3 + 18 files changed, 258 insertions(+), 131 deletions(-)