mbox series

[v3,0/5] CAMSS updates for rb3 and rb5

Message ID 20220606132029.2221257-1-bryan.odonoghue@linaro.org (mailing list archive)
Headers show
Series CAMSS updates for rb3 and rb5 | expand

Message

Bryan O'Donoghue June 6, 2022, 1:20 p.m. UTC
V3:
This series takes in some changes to core CAMSS/CCI and to the RB3 taking
feedback from others on the list so, I've renamed from the previous "Switch
on IMX577 on RB5 with a new CCI fix" to the new title above.

- Changes pm_runtime_put() - Vladimir
- Adds Reviewed-by as indicated - Vladimir
- Adds cc-stable for the CCI bugfix - Bryan
- Splits rb3 and rb5 into "navigation-mezzanine.dts" and
  "vision-mezzanine.dts" respecitvely - Dmitry / Bjorn

I didn't add new compatible strings for the mezzanines since it doesn't
make much sense to me how that would work concatonating two mezzaines
together but, maybe there's another better argument I haven't thought of.

Again to make verification easier I've provided a buidable and bootable
tree for rb3 and rb5 containing defconfig - you can just zap the last
commit to test with modules on rb5.

Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-03-06-22%2bimx577-rb5

V2:

- Adds fix for bug identified by Vladimir
  The CCI i2c_adapter_add() and pm_runtime_enable() are racy.
  This is a generic problem not related to the rb5/imx577 but, for the sake
  of our conversation/review's context I'll add it into this series.
- Include Vladimir's camcc patch
  I've also opted to include Vladimir's disable of camcc to make the enable
  of it in my patchset logical.
- Move address/size cells Konrad
- Remove newline in pin definitions - Konrad
- Remove sensor 'status = "okay"' - Konrad
- Add comment to qrb5165-rb5.dts re: imx412 and imx577 difference - Konrad
- Move pin definitions to 8250 dtsi - Vladimir
- Drop power domain from sensor definition - Vladimir
- Correct to "add to cam2" not "cam1" in commit log - bod

To make verification of the CCI race eaiser I've provided a defconfig both
with and without modules enabled.

Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-24-05-22%2bimx577-rb5
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-24-05-22%2bimx577-rb5-compiled-in

git diff linaro/linux-next-22-05-22+imx577-rb5 linaro/linux-next-24-05-22+imx577-rb5

V1:
Linux-next now has everything we need to switch on this sensor both in the
qcom DTS and in the imx412 driver.

After this, no further dts or driver work is required to capture images on
the RB5.

Here's a bootable linux-next with a kernel config. I added Vladimir's
power-domain changes on-top to verify nothing breaks for me.

https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-18-05-22%2bimx577-rb5

Bryan O'Donoghue (4):
  i2c: qcom-cci: Fix ordering of pm_runtime_xx and i2c_add_adapter
  arm64: dts: qcom: sm8250: camss: Define ports address/size cells
  arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine
  arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation
    mezzanine dts

Vladimir Zapolskiy (1):
  arm64: dts: qcom: sm8250: Disable camcc by default

 arch/arm64/boot/dts/qcom/Makefile             |   2 +
 .../dts/qcom/qrb5165-rb5-vision-mezzanine.dts |  68 +++++++++++
 .../sdm845-db845c-navigation-mezzanine.dts    | 115 ++++++++++++++++++
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    | 106 ----------------
 arch/arm64/boot/dts/qcom/sm8250.dtsi          |  39 ++++++
 drivers/i2c/busses/i2c-qcom-cci.c             |  13 +-
 6 files changed, 232 insertions(+), 111 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts