From patchwork Tue Jul 12 01:59:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12914435 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01972C43334 for ; Tue, 12 Jul 2022 02:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbiGLCAA (ORCPT ); Mon, 11 Jul 2022 22:00:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbiGLB77 (ORCPT ); Mon, 11 Jul 2022 21:59:59 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36B122F037 for ; Mon, 11 Jul 2022 18:59:58 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id o18so6281683pgu.9 for ; Mon, 11 Jul 2022 18:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nuPaTFh2Jga2agTt76o8SxVao6/hBHeRLv1L+lXtpKc=; b=A6Vl3aAo29Lrw7iukb8BVzlEBUgyaaS37tchXpXISf6ejKGXczbIM76hB5D2ZCe29/ akqxL2Xxf832noIPekRGPzj1/BHh31Ft989cR3kQo10bNrvx8rQ7c0XsFKbGVNMLS/OV IBWbwVHvYPKVT5cx2L0ksdbk07yxayfq1jv7eCPMY7advvkypA0wvGr/ZsT1rUSplBH0 LAHdXtNmeGvPk73OFmWdm4kaBpqyp+Q/aPeOYxwuQ4aXEOGp0SmYkUZSA4D2FUaUQspW yGkclTVvtq6vpBdcEl1C+AlhiRBm9XYSED/OD3BVKDjxYHOiotP41Hlyxs/azqQJ2VpS hvPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nuPaTFh2Jga2agTt76o8SxVao6/hBHeRLv1L+lXtpKc=; b=MLqx7UV998GiemfuJk4+gcDpbbv/U7LJZw5J+DL+SdApATYLT9lKVWHUqLsSaCkA7a 479s+d3KEgTU6sKXQQLX2s7z9Q0Fwvv5m4t2aNuJa0qJYuyp1gXm199E0nR2hUhefqDU nxXgHbYvskOWdWW2l8pv0Q69Y70j17qX5KXWqTqQthvkneEBF5EDYCR16esg+f5KuWhE 1rFQ7itzQS2sR0p2t6wAEltvb9Sf+66kumTnjDbERFDfBRNL9OBAVg3N54fnPX+XZ2Ve XZrJ3wWn1Hjo9nZR00P/UoCIlhjjh5ldi+Noze43NcurwdDjOviwzSjLfgu4nI1xZnuU 3ANQ== X-Gm-Message-State: AJIora/Ilb9b0wxHbQ0orOcehF/Z74KAx8gBdDUNOep3LK/mixTNj/SC BHCLqAFmPDPVs/ZDx4oG6L7V9g== X-Google-Smtp-Source: AGRyM1tdOwL20X8SEOTykDxB0KxybM4JcZmj2jVohgfsBKX2aVF8ZzZRARsY2B62DXSSRdy5asBBhw== X-Received: by 2002:a63:fb12:0:b0:412:b113:f537 with SMTP id o18-20020a63fb12000000b00412b113f537mr18786804pgh.256.1657591197553; Mon, 11 Jul 2022 18:59:57 -0700 (PDT) Received: from leo-build-box.lan (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id x5-20020a17090a6b4500b001ef76dbae28sm5425821pjl.36.2022.07.11.18.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 18:59:56 -0700 (PDT) From: Leo Yan To: Georgi Djakov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v6 0/5] interconnect: qcom: icc-rpm: Support bucket Date: Tue, 12 Jul 2022 09:59:24 +0800 Message-Id: <20220712015929.2789881-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This patch set is to support bucket in icc-rpm driver, so it implements the similar mechanism in the icc-rpmh driver. It uses interconnect path tag to indicate the bandwidth voting is for which buckets, and there have three kinds of buckets: AWC, WAKE and SLEEP, finally the wake and sleep bucket values are used to set the corresponding clock (active and sleep clocks). So far, we keep the AWC bucket but doesn't really use it. Note, this patch set is dependent on an out of tree patch "interconnect: icc-rpm: Set destination bandwidth as well as source bandwidth" [1]. With the dependent patch, this patch set can be cleanly applied on the Linux kernel master branch with the latest commit 32346491ddf2 ("Linux 5.19-rc6"). [1] https://lore.kernel.org/linux-pm/20220707093823.1691870-1-bryan.odonoghue@linaro.org/T/#r304f7b103c806e1570d555a0f5aaf83ae3990ac0 Changes from v5: - Removed unsed local variable 'max_agg_peak' in qcom_icc_set() (Georgi). Changes from v4: - Added Krzysztof's Acked tag for DT binding document patch; - Fixed the unalignment between function qcom_icc_pre_bw_aggregate() and its comment (Georgi); - Simplified qcom_icc_bus_aggregate() with removing unused parameter 'max_agg_peak'; - Removed unsed local variable 'max_peak_bw' in qcom_icc_set() (Georgi). Changes from v3: - Removed $ref and redundant sentence in DT binding document for '#interconnect-cells' (Krzysztof Kozlowski). Changes from v2: - Fixed for DT checker error for command ''make DT_CHECKER_FLAGS=-m dt_binding_check' (Rob Herring). Changes from v1: - Added description for property "#interconnect-cells" (Rob Herring); - Added Dimtry's reviewed tags for patches 02 and 03 (Dmitry Baryshkov); - Rebased on the latest mainline kernel and resolved conflict. Leo Yan (5): dt-bindings: interconnect: Update property for icc-rpm path tag interconnect: qcom: Move qcom_icc_xlate_extended() to a common file interconnect: qcom: icc-rpm: Change to use qcom_icc_xlate_extended() interconnect: qcom: icc-rpm: Support multiple buckets interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values .../bindings/interconnect/qcom,rpm.yaml | 6 +- drivers/interconnect/qcom/Makefile | 3 + drivers/interconnect/qcom/icc-common.c | 34 +++++ drivers/interconnect/qcom/icc-common.h | 13 ++ drivers/interconnect/qcom/icc-rpm.c | 129 +++++++++++++++--- drivers/interconnect/qcom/icc-rpm.h | 6 + drivers/interconnect/qcom/icc-rpmh.c | 26 +--- drivers/interconnect/qcom/icc-rpmh.h | 1 - drivers/interconnect/qcom/sm8450.c | 1 + 9 files changed, 176 insertions(+), 43 deletions(-) create mode 100644 drivers/interconnect/qcom/icc-common.c create mode 100644 drivers/interconnect/qcom/icc-common.h