| Message ID | 20221209171240.1614904-1-dianders@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sc7180: Make pazquel360's touchscreen work | expand |
On Fri, 9 Dec 2022 09:12:36 -0800, Douglas Anderson wrote: > This series of patches adds / fixes problems with pazquel360's > touchscreen. A few notes here: > > 1. Originally the touchscreen was supposed to be added as part of the > first landing of the pazquel360 device tree. ...but the fact that > Yunlong changed email addresses seems to have messed up Bjorn's > scripts. What landed was v3 [1] instead of v5 [2]. The pazquel360 part > of this series is that diff (minus the incorrect 'hid-descr-addr' property). > > [...] Applied, thanks! [1/4] arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength commit: 9506a3661258d07a60b186f667b391708ddf63ac [2/4] arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time commit: f5b4811e8758fed76da4f54f6efa1452bc878595 [3/4] arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on commit: 23ff866987de2910de4a1060e9b0e112376c0dd0 [4/4] arm64: dts: qcom: sc7180: Add pazquel360 touschreen commit: 335fe4b79838a7c722d21c15784f7ed1172a6c81 Best regards,
This series of patches adds / fixes problems with pazquel360's touchscreen. A few notes here: 1. Originally the touchscreen was supposed to be added as part of the first landing of the pazquel360 device tree. ...but the fact that Yunlong changed email addresses seems to have messed up Bjorn's scripts. What landed was v3 [1] instead of v5 [2]. The pazquel360 part of this series is that diff (minus the incorrect 'hid-descr-addr' property). 2. We delayed sending the fixup till now because soon after the series landed upstream we found that some laptops were having trouble initting the touchscreen in cases where the eDP/touchscreen regulator was left on by the bootloader. We've been struggling to make sense of all of this. As part of this investigation we landed a85fbd649844 ("Input: elants_i2c - properly handle the reset GPIO when power is off") but that wasn't enough. That fix, together with the fixes in this series, is enough though. 3. In v1 and v2, this series included an elan driver patch too. That's landed, so v3 is just device tree stuff. It turns out that with _just_ the device tree changes things are actually working OK but the timing is tight, so getting a little extra breathing room from the Linux driver was nice. 4. Despite the fact that we did debugging here on pazquel360, many of the changes here are made in general for trogdor devices. I believe that this will make the timing more correct on those devices even if we weren't actually seeing problems. [1] https://lore.kernel.org/r/20220901024827.v3.2.Iea2d2918adfff2825b87d428b5732717425c196f@changeid [2] https://lore.kernel.org/r/20220923083657.v5.3.Iea2d2918adfff2825b87d428b5732717425c196f@changeid Changes in v3: - Removed hid-descr-addr Changes in v2: - Fix typo in commit message (Matthias) Douglas Anderson (4): arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on arm64: dts: qcom: sc7180: Add pazquel360 touschreen .../dts/qcom/sc7180-trogdor-homestar.dtsi | 18 +++++++++++++++++ .../qcom/sc7180-trogdor-parade-ps8640.dtsi | 20 +++++++++++++++++++ .../dts/qcom/sc7180-trogdor-pazquel360.dtsi | 19 ++++++++++++++++++ .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 20 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 10 +++++++++- 5 files changed, 86 insertions(+), 1 deletion(-)