From patchwork Sun Jan 1 19:40:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13086451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE3FC46467 for ; Sun, 1 Jan 2023 19:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbjAATkk (ORCPT ); Sun, 1 Jan 2023 14:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjAATkj (ORCPT ); Sun, 1 Jan 2023 14:40:39 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56B421010 for ; Sun, 1 Jan 2023 11:40:37 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id cf42so38888159lfb.1 for ; Sun, 01 Jan 2023 11:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=txLcTOabfjsVIcqNg+Q9wYp4D/25zCWx0eIqQlqtqE4=; b=LlshXnvI9irzRhM/b3ClTcKBbuTDXoXbSj9m0MEpOmxU3FbAZTUluTRm5Nd1jDRo/q 6PDn7jNjFyIJwcS4vK3FX1NZBJPflpRrT1XTrkRvPl05fQbbuAt1K+umz2gMkw7AIjAm c0zl1qqFb2gx757D/WFsE/Mfv9+e8oNovTfZ4hC4ixhncWBuZ553mqEM+yabpVzeNpzY m2yt1grSYcNXvbKtv0f09wfxGsqbtsv3tLZw0tLZlwodcsX07VikbExxA+RF4jk/lH6o UGxF6wK/w+ydD63aLYzk+bf8HnnoZku5rQKJh6G2paDCut8U3BwKbLGp/nSkhDgkehhS mkqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=txLcTOabfjsVIcqNg+Q9wYp4D/25zCWx0eIqQlqtqE4=; b=ygpD/umvCp/LPjl/XZprz3rZBgCGZEKK6L4+NmBb51dEUNPWMwkNQt84Vh5licPedD 4Lmyn8bUSVd9+YxIaLnwyOaZ2iG2DKhkLpUW8NZwqhbEq9GCShaQuSjm58wJy8NgkCr4 7XD6VzWUQTPVC+B9xCNa9iLJSxtBBGfPMFhjeYLrx4zamYjD4q31HigH6GgjE6pjywn2 vCcwo70MutCsgw6+nqresPa9NW9UG99J2kTWvr/uRQYGZXolq2Z9wn4jsQHr9lia2ng1 5aaDzAxk1/d2zU0a3m3Zo1KbySBrl43fkW4EfBmtpX0XTd1nOpWPtR+wxC4e7cryAc12 gCVw== X-Gm-Message-State: AFqh2krYrD1aNjQhLCz7XZxs56O9CNcS/3uVmYGiNQCI7h1Ra1gZ34wu saNzplSQOh+X5CsREGlzq+hqzw== X-Google-Smtp-Source: AMrXdXvpn9wMY5tAaFrT6KG9vaQq/SSKy1W6E69BVJxWjMVzuzhlOsSOwxAyNxVAtc+pAS6ygG8unA== X-Received: by 2002:a05:6512:308f:b0:4cb:1189:2862 with SMTP id z15-20020a056512308f00b004cb11892862mr5898585lfd.13.1672602035614; Sun, 01 Jan 2023 11:40:35 -0800 (PST) Received: from eriador.lan (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id w11-20020a056512098b00b004a100c21eaesm4228013lft.97.2023.01.01.11.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Jan 2023 11:40:34 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: "Bryan O'Donoghue" , Shawn Guo , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v6 00/20] thermal/drivers/tsens: specify nvmem cells in DT rather than parsing them manually Date: Sun, 1 Jan 2023 21:40:14 +0200 Message-Id: <20230101194034.831222-1-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Historically the tsens driver fetches the calibration data as a blob and then parses the blob on its own. This results in semi-duplicated code spreading over the platform-specific functions. This patch series changes tsens calibration code to per-value nvmem cells rather than parsing the blob in the driver. For backwards compatibility the old code is left in place for msm8916, msm8974 and qcs404, the platforms which have in-tree DT files. For all other affected platforms the old parsing code has been dropped as a part of this series. The code was tested on msm8916 and qcs404 only. Note: the DTs changes depend on driver changes. Tsens driver will not work if DT patches are merged, but the driver bits are not. As the thermal sense is critical for device safety, I'kindly ask to have an immutable branch with the driver changes that can be merged into the msm-dts tree. Note2: I still have included patches to drop legacy support for 8939 (msm8939.dtsi is on the list, patch to convert it to the proposed bindings is available at [1]) and 8976 (msm8976.dtsi and msm8956.dtsi, which use single-blob bindings, have been accepted for 6.2, dropping old bindings support depends on mutual consensuns of platform and thermal code maintainers). Corresponding patches are the last ones in the thermal part of the series, thus if they are declined, the reset of the series still can be applied without any problems. [1] https://pastebin.ubuntu.com/p/rfkZgy767K/ Changes since v5: - Reworked bindings to use patterns instead of enum, - Changed the order of items in msm8974/apq8084 bindings. If there will be any other platform using main & backup calibration values, it would be easier to reuse msm8974 bindings by using 's[0-9]+_p[12](_backup)?' patterns, rather than listing all the cases explicitly. Changes since v4: - Changed DT bindings to use HW sensor ids rather than bare indices. This follows the usage of hw_ids in thermal-sensors specifications (and corresponds to the ID visible in debugfs). Previously there was no correspondence, which resulted e.g. in usage of s0_p1/s0_p2 for sensor 0, but s4_p1/s4_p2 for the sensor 5 on the msm8916 platform). - Reworked msm8939 code to ignore the sensor10. It is available only on latest hw revision, it doesn't seem to be actually used and it also wasn't covered by the old single-blob bindings because of the parsing error. - Fixed missing include reported by testing robot. Changes since v3: - Added a patch to fix the tsens compatible string on msm8956 SoC, - Fixed num-sensors and slope coefficients for the msm8939 SoC, - Rewrote code supporting old bindings into the simple data-driven parser common to all legacy platforms which made dropping support for old bindings less demanding. Changes since v2: - Made init_8956 static, as pointed out by the testing robot and by AngeloGioacchino Del Regno. Changes since the RFC: - Sorted out the msm8976/msm8956, custom slopes are used only for msm8956, - Implemented proper support for msm8974/apq8084, - Added tsens_calibrate_common() and ops_v0_1 which can be used in common cases, - Removed superfluous identity hw_ids - Fixed calibration calculation in tsens_calibrate_nvmem() for ONE_PT_CALIB case Dmitry Baryshkov (20): dt-bindings: thermal: tsens: add msm8956 compat dt-bindings: thermal: tsens: support per-sensor calibration cells dt-bindings: thermal: tsens: add per-sensor cells for msm8974 thermal/drivers/tsens: Drop unnecessary hw_ids thermal/drivers/tsens: Drop msm8976-specific defines thermal/drivers/tsens: Sort out msm8976 vs msm8956 data thermal/drivers/tsens: fix slope values for msm8939 thermal/drivers/tsens: limit num_sensors to 9 for msm8939 thermal/drivers/tsens: Support using nvmem cells for calibration data thermal/drivers/tsens: Support using nvmem cells for msm8974 calibration thermal/drivers/tsens: Rework legacy calibration data parsers thermal/drivers/tsens: Drop single-cell code for mdm9607 thermal/drivers/tsens: Drop single-cell code for msm8939 thermal/drivers/tsens: Drop single-cell code for msm8976/msm8956 arm64: dts: qcom: msm8956: use SoC-specific compat for tsens arm64: dts: qcom: msm8916: specify per-sensor calibration cells arm64: dts: qcom: msm8976: specify per-sensor calibration cells arm64: dts: qcom: qcs404: specify per-sensor calibration cells ARM: dts: qcom-msm8974: specify per-sensor calibration cells ARM: dts: qcom-apq8084: specify per-sensor calibration cells .../bindings/thermal/qcom-tsens.yaml | 153 +++- arch/arm/boot/dts/qcom-apq8084.dtsi | 313 ++++++++- arch/arm/boot/dts/qcom-msm8974.dtsi | 313 ++++++++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 85 ++- arch/arm64/boot/dts/qcom/msm8956.dtsi | 4 + arch/arm64/boot/dts/qcom/msm8976.dtsi | 153 +++- arch/arm64/boot/dts/qcom/qcs404.dtsi | 145 +++- drivers/thermal/qcom/tsens-v0_1.c | 655 +++++------------- drivers/thermal/qcom/tsens-v1.c | 340 +++------ drivers/thermal/qcom/tsens.c | 168 +++++ drivers/thermal/qcom/tsens.h | 46 +- 11 files changed, 1610 insertions(+), 765 deletions(-)