[0/7] RPMPD cleanup + parent PD

Message

Konrad Dybcio Jan. 25, 2023, 3:27 a.m. UTC

This series provides a big and necessary cleanup for RPMPD..
Lots of redefined objects were trimmed as well as some stylistic
and maintainability fixes have been made. Also, support for parent
PD is added and put to use on SM6375 where VDDMX should be scaled
together with VDDGX.

Tested on SM6375.

Konrad Dybcio (7):
  soc: qcom: rpmpd: Add parent PD support
  soc: qcom: rpmpd: Expand #defines into structs
  soc: qcom: rpmpd: Hook up VDDMX as parent of SM6375 VDDGX
  soc: qcom: rpmpd: Remove SoC names from RPMPD names
  soc: qcom: rpmpd: Remove useless comments
  soc: qcom: rpmpd: Move all RPMPD definitions up and sort them by name
  soc: qcom: rpmpd: Make bindings assignments consistent

 drivers/soc/qcom/rpmpd.c | 790 ++++++++++++++++++++++++++-------------
 1 file changed, 522 insertions(+), 268 deletions(-)

Comments

Dmitry Baryshkov Jan. 25, 2023, 8:57 a.m. UTC | #1

Hello Konrad,

On 25/01/2023 05:27, Konrad Dybcio wrote:
> This series provides a big and necessary cleanup for RPMPD..
> Lots of redefined objects were trimmed as well as some stylistic
> and maintainability fixes have been made. Also, support for parent
> PD is added and put to use on SM6375 where VDDMX should be scaled
> together with VDDGX.

The idea is great, however the order of patches makes it a bit hard to 
review. Moving expanded macros causes git to match parts of the 
structures, making one wonder why _corner_ is suddenly changed to _lvl_.

I hate to suggest this, but it might be better to reorder the patches 
here (yes, I understand the pain it will cause).

I'd suggest the following order (based on my previous experience with 
clocks and icc cleanup):

- remove SoC names from PD defines
- sort RPMPD definitions
- make SoC arrays consistent
- expand the macros
- add parent PD support
- hook up VDDMX as a parent

> 
> Tested on SM6375.
> 
> Konrad Dybcio (7):
>    soc: qcom: rpmpd: Add parent PD support
>    soc: qcom: rpmpd: Expand #defines into structs
>    soc: qcom: rpmpd: Hook up VDDMX as parent of SM6375 VDDGX
>    soc: qcom: rpmpd: Remove SoC names from RPMPD names
>    soc: qcom: rpmpd: Remove useless comments
>    soc: qcom: rpmpd: Move all RPMPD definitions up and sort them by name
>    soc: qcom: rpmpd: Make bindings assignments consistent
> 
>   drivers/soc/qcom/rpmpd.c | 790 ++++++++++++++++++++++++++-------------
>   1 file changed, 522 insertions(+), 268 deletions(-)
>