| Message ID | 20230207024816.525938-1-dianders@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm: qcom: Fix touchscreen voltage for sc7280-herobrine boards | expand |
On Mon, 6 Feb 2023 18:48:09 -0800, Douglas Anderson wrote: > Trying to figure out how to talk to the touchscreen properly on > sc7280-herobrine boards was a long and difficult process. Many > Engineering hours were spent deciding how exactly one should talk over > i2c to a peripheral. In the end, a solution has been found and this > patch series attempts to implement it in a way that will work for all > herobrine-based boards. > > [...] Applied, thanks! [1/7] arm64: dts: qcom: sc7280: On QCard, regulator L3C should be 1.8V commit: 428df177013bad1a0a062878e3d5224122b7a5fe [2/7] arm64: dts: qcom: sc7280: Add 3ms ramp to herobrine's pp3300_left_in_mlb commit: 4261cea17a2f5e0ec78eb3ceebb68dddb918aee9 [3/7] arm64: dts: qcom: sc7280: Hook up the touchscreen IO rail on villager commit: d90b98f5702dccc41a5885b65361573654fcaabf [7/7] arm64: dts: qcom: sc7280: Hook up the touchscreen IO rail on evoker commit: ef29188fe0b4de5c04b833378db92d3a3e0709e8 Best regards,
On Mon, 06 Feb 2023 18:48:09 -0800, Douglas Anderson wrote: > Trying to figure out how to talk to the touchscreen properly on > sc7280-herobrine boards was a long and difficult process. Many > Engineering hours were spent deciding how exactly one should talk over > i2c to a peripheral. In the end, a solution has been found and this > patch series attempts to implement it in a way that will work for all > herobrine-based boards. > > [...] Applied to hid/hid.git (for-6.3/i2c-hid), thanks! [4/7] HID: i2c-hid: goodix: Stop tying the reset line to the regulator https://git.kernel.org/hid/hid/c/557e05fa9fdd [5/7] dt-bindings: HID: i2c-hid: goodix: Add mainboard-vddio-supply https://git.kernel.org/hid/hid/c/1d18c1f3b7d9 [6/7] HID: i2c-hid: goodix: Add mainboard-vddio-supply https://git.kernel.org/hid/hid/c/eb16f59e8e58 Cheers,
Trying to figure out how to talk to the touchscreen properly on sc7280-herobrine boards was a long and difficult process. Many Engineering hours were spent deciding how exactly one should talk over i2c to a peripheral. In the end, a solution has been found and this patch series attempts to implement it in a way that will work for all herobrine-based boards. Validation of this code has actually been done on sc7280-herobrine-villager. Those patches are device-tree only and are placed first. They shouldn't be super controversial, I hope. In order to make this work, we also need to support sc7280-herobrine-evoker. For evoker, things are a bit tricker, though (I think) the solution we ended up with is not terrible. See the "Goodix" bindings patch for the full details. Unfortunately, I haven't tested the final version of these patches on evoker hardware. Thus those patches are at the end of the series and marked as such. It still wouldn't hurt to land them, if people are OK with it, since nobody in the wild has this hardware and and the evoker-specific parts of the patch are very easy to validate. Douglas Anderson (7): arm64: dts: qcom: sc7280: On QCard, regulator L3C should be 1.8V arm64: dts: qcom: sc7280: Add 3ms ramp to herobrine's pp3300_left_in_mlb arm64: dts: qcom: sc7280: Hook up the touchscreen IO rail on villager HID: i2c-hid: goodix: Stop tying the reset line to the regulator dt-bindings: HID: i2c-hid: goodix: Add mainboard-vddio-supply HID: i2c-hid: goodix: Add mainboard-vddio-supply arm64: dts: qcom: sc7280: Hook up the touchscreen IO rail on evoker .../bindings/input/goodix,gt7375p.yaml | 7 ++ .../dts/qcom/sc7280-herobrine-evoker.dtsi | 1 + .../dts/qcom/sc7280-herobrine-villager.dtsi | 1 + .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 + arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 10 +- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 98 +++++-------------- 6 files changed, 42 insertions(+), 77 deletions(-)