| Message ID | 20230320221617.236323-1-ahalaney@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add EMAC3 support for sa8540p-ride | expand |
On Mon, 20 Mar 2023 17:16:05 -0500 Andrew Halaney wrote: > This is a forward port / upstream refactor of code delivered > downstream by Qualcomm over at [0] to enable the DWMAC5 based > implementation called EMAC3 on the sa8540p-ride dev board. > > From what I can tell with the board schematic in hand, > as well as the code delivered, the main changes needed are: > > 1. A new address space layout for /dwmac5/EMAC3 MTL/DMA regs > 2. A new programming sequence required for the EMAC3 base platforms > > This series makes those adaptations as well as other housekeeping items > such as converting dt-bindings to yaml, adding clock descriptions, etc. > > [0] https://git.codelinaro.org/clo/la/kernel/ark-5.14/-/commit/510235ad02d7f0df478146fb00d7a4ba74821b17 > > v1: https://lore.kernel.org/netdev/20230313165620.128463-1-ahalaney@redhat.com/ At a glance 1-4,8-12 need to go via networking, 5 via clock tree, and 6,7 via ARM/Qualcomm. AFAICT there are no strong (compile) dependencies so we can each merge our chunk and they will meet in Linus's tree? If so please repost just the networking stuff for net-next, and the other bits to respective trees, as separate series.
On Mon, Mar 20, 2023 at 08:28:02PM -0700, Jakub Kicinski wrote: > On Mon, 20 Mar 2023 17:16:05 -0500 Andrew Halaney wrote: > > This is a forward port / upstream refactor of code delivered > > downstream by Qualcomm over at [0] to enable the DWMAC5 based > > implementation called EMAC3 on the sa8540p-ride dev board. > > > > From what I can tell with the board schematic in hand, > > as well as the code delivered, the main changes needed are: > > > > 1. A new address space layout for /dwmac5/EMAC3 MTL/DMA regs > > 2. A new programming sequence required for the EMAC3 base platforms > > > > This series makes those adaptations as well as other housekeeping items > > such as converting dt-bindings to yaml, adding clock descriptions, etc. > > > > [0] https://git.codelinaro.org/clo/la/kernel/ark-5.14/-/commit/510235ad02d7f0df478146fb00d7a4ba74821b17 > > > > v1: https://lore.kernel.org/netdev/20230313165620.128463-1-ahalaney@redhat.com/ > > At a glance 1-4,8-12 need to go via networking, 5 via clock tree, > and 6,7 via ARM/Qualcomm. > > AFAICT there are no strong (compile) dependencies so we can each merge > our chunk and they will meet in Linus's tree? If so please repost just > the networking stuff for net-next, and the other bits to respective > trees, as separate series. > That makes sense to me, thanks for the advice. The only note is that 5 (the clk patch) is depended on by 6/7 to compile (they use the header value in 5)... So I'll keep those together! So all in all it will be the dt-binding changes + stmmac changes in one series for networking, and the clock + devicetree changes via ARM/Qualcomm if I am following properly. I'll go that route for v3 and link here (just to make finding the split easier) unless someone objects (got some time as I need to refactor based on series feedback)! Thanks, Andrew
On Tue, Mar 21, 2023 at 01:44:35PM -0500, Andrew Halaney wrote: > On Mon, Mar 20, 2023 at 08:28:02PM -0700, Jakub Kicinski wrote: > > On Mon, 20 Mar 2023 17:16:05 -0500 Andrew Halaney wrote: > > > This is a forward port / upstream refactor of code delivered > > > downstream by Qualcomm over at [0] to enable the DWMAC5 based > > > implementation called EMAC3 on the sa8540p-ride dev board. > > > > > > From what I can tell with the board schematic in hand, > > > as well as the code delivered, the main changes needed are: > > > > > > 1. A new address space layout for /dwmac5/EMAC3 MTL/DMA regs > > > 2. A new programming sequence required for the EMAC3 base platforms > > > > > > This series makes those adaptations as well as other housekeeping items > > > such as converting dt-bindings to yaml, adding clock descriptions, etc. > > > > > > [0] https://git.codelinaro.org/clo/la/kernel/ark-5.14/-/commit/510235ad02d7f0df478146fb00d7a4ba74821b17 > > > > > > v1: https://lore.kernel.org/netdev/20230313165620.128463-1-ahalaney@redhat.com/ > > > > At a glance 1-4,8-12 need to go via networking, 5 via clock tree, > > and 6,7 via ARM/Qualcomm. > > > > AFAICT there are no strong (compile) dependencies so we can each merge > > our chunk and they will meet in Linus's tree? If so please repost just > > the networking stuff for net-next, and the other bits to respective > > trees, as separate series. > > > > That makes sense to me, thanks for the advice. > > The only note is that 5 (the clk patch) is depended on by 6/7 to > compile (they use the header value in 5)... So I'll keep those together! > Sounds good to me! Regards, Bjorn > So all in all it will be the dt-binding changes + stmmac changes in one > series for networking, and the clock + devicetree changes via > ARM/Qualcomm if I am following properly. > > I'll go that route for v3 and link here (just to make finding the split > easier) unless someone objects (got some time as I need to refactor > based on series feedback)! > > Thanks, > Andrew >
This is a forward port / upstream refactor of code delivered downstream by Qualcomm over at [0] to enable the DWMAC5 based implementation called EMAC3 on the sa8540p-ride dev board. From what I can tell with the board schematic in hand, as well as the code delivered, the main changes needed are: 1. A new address space layout for /dwmac5/EMAC3 MTL/DMA regs 2. A new programming sequence required for the EMAC3 base platforms This series makes those adaptations as well as other housekeeping items such as converting dt-bindings to yaml, adding clock descriptions, etc. [0] https://git.codelinaro.org/clo/la/kernel/ark-5.14/-/commit/510235ad02d7f0df478146fb00d7a4ba74821b17 v1: https://lore.kernel.org/netdev/20230313165620.128463-1-ahalaney@redhat.com/ Thanks, Andrew Andrew Halaney (8): dt-bindings: net: qcom,ethqos: Add Qualcomm sc8280xp compatibles clk: qcom: gcc-sc8280xp: Add EMAC GDSCs arm64: dts: qcom: sc8280xp: Add ethernet nodes arm64: dts: qcom: sa8540p-ride: Add ethernet nodes net: stmmac: Remove unnecessary if statement brackets net: stmmac: dwmac-qcom-ethqos: Respect phy-mode and TX delay net: stmmac: dwmac-qcom-ethqos: Use loopback_en for all speeds net: stmmac: dwmac-qcom-ethqos: Add EMAC3 support Bhupesh Sharma (3): dt-bindings: net: snps,dwmac: Update interrupt-names dt-bindings: net: snps,dwmac: Add Qualcomm Ethernet ETHQOS compatibles dt-bindings: net: qcom,ethqos: Convert bindings to yaml Brian Masney (1): net: stmmac: Add EMAC3 variant of dwmac4 .../devicetree/bindings/net/qcom,ethqos.txt | 66 ---- .../devicetree/bindings/net/qcom,ethqos.yaml | 111 ++++++ .../devicetree/bindings/net/snps,dwmac.yaml | 9 +- MAINTAINERS | 2 +- arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 181 ++++++++++ arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 53 +++ drivers/clk/qcom/gcc-sc8280xp.c | 18 + .../stmicro/stmmac/dwmac-qcom-ethqos.c | 161 ++++++--- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 32 +- .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 235 ++++++++++-- .../net/ethernet/stmicro/stmmac/dwmac4_dma.c | 334 ++++++++++++++---- .../net/ethernet/stmicro/stmmac/dwmac4_dma.h | 38 ++ .../net/ethernet/stmicro/stmmac/dwmac4_lib.c | 144 ++++++-- drivers/net/ethernet/stmicro/stmmac/hwif.c | 29 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 2 + .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 6 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 17 +- .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 9 +- .../net/ethernet/stmicro/stmmac/stmmac_ptp.c | 4 +- include/dt-bindings/clock/qcom,gcc-sc8280xp.h | 2 + include/linux/stmmac.h | 1 + 21 files changed, 1196 insertions(+), 258 deletions(-) delete mode 100644 Documentation/devicetree/bindings/net/qcom,ethqos.txt create mode 100644 Documentation/devicetree/bindings/net/qcom,ethqos.yaml