From patchwork Mon Apr 17 23:14:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marijn Suijten X-Patchwork-Id: 13214858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD110C77B72 for ; Mon, 17 Apr 2023 23:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbjDQXOV (ORCPT ); Mon, 17 Apr 2023 19:14:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbjDQXOU (ORCPT ); Mon, 17 Apr 2023 19:14:20 -0400 Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [5.144.164.167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08B7D3C02; Mon, 17 Apr 2023 16:14:18 -0700 (PDT) Received: from Marijn-Arch-PC.localdomain (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id E6DF73F8AE; Tue, 18 Apr 2023 01:14:16 +0200 (CEST) From: Marijn Suijten Subject: [PATCH 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup Date: Tue, 18 Apr 2023 01:14:15 +0200 Message-Id: <20230418-dpu-drop-useless-for-lookup-v1-0-b9897ceb6f3e@somainline.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAMfSPWQC/x2NQQrDIBAAvxL23AWTSmP7lZKD0U2zVFR2sRRC/ l7pceYwc4CSMCk8hgOEPqxccofxMkDYfX4RcuwMk5muxo4OY20YpVRsSolUcSuCqZR3q2idm40 Js7e3O/TC6pVwFZ/D3hu5pdRlFdr4+18+l/P8AQRLlfiCAAAA To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Jordan Crouse , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marijn Suijten X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Doing a for loop in every DPU HW block driver init to find a catalog entry matching the given ID is rather useless if the init function called by RM already has that catalog entry pointer, and uses exactly its ID to drive this init and for loop. Remove all that machinery to drop quite some lines of unnecessarily-complicated code, and the fallibility that comes with it, by simply giving _init() the catalog entry pointers straight away. Also clean up some unused struct members, and assign a log_mask for WB. --- Marijn Suijten (3): drm/msm/dpu: Drop unused members from HW structs drm/msm/dpu: Assign missing writeback log_mask drm/msm/dpu: Pass catalog pointers directly from RM instead of IDs drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 30 +++-------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 32 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 11 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 38 ++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 12 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 41 ++++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 13 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 38 ++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_merge3d.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_merge3d.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 34 +++---------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 11 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 33 ++++-------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 16 +++------ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 17 +++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 18 +++++----- 23 files changed, 127 insertions(+), 376 deletions(-) --- base-commit: 4aa1da8d99724f6c0b762b58a71cee7c5e2e109b change-id: 20230418-dpu-drop-useless-for-lookup-488700c7a469 Best regards,