[0/8] clk: qcom: fix runtime PM bugs

Message

Johan Hovold July 18, 2023, 1:28 p.m. UTC

This series fixes a number of runtime PM related bugs found through
inspection.

Johan


Johan Hovold (8):
  clk: qcom: camcc-sc7180: fix async resume during probe
  clk: qcom: dispcc-sm8450: fix runtime PM imbalance on probe errors
  clk: qcom: dispcc-sm8550: fix runtime PM imbalance on probe errors
  clk: qcom: gcc-sc8280xp: fix runtime PM imbalance on probe errors
  clk: qcom: lpasscc-sc7280: fix missing resume during probe
  clk: qcom: q6sstop-qcs404: fix missing resume during probe
  clk: qcom: mss-sc7180: fix missing resume during probe
  clk: qcom: turingcc-qcs404: fix missing resume during probe

 drivers/clk/qcom/camcc-sc7180.c    |  2 +-
 drivers/clk/qcom/dispcc-sm8450.c   | 13 +++++++++++--
 drivers/clk/qcom/dispcc-sm8550.c   | 13 +++++++++++--
 drivers/clk/qcom/gcc-sc8280xp.c    | 14 +++++++++++---
 drivers/clk/qcom/lpasscc-sc7280.c  | 16 ++++++++++++----
 drivers/clk/qcom/mss-sc7180.c      | 13 ++++++++++++-
 drivers/clk/qcom/q6sstop-qcs404.c  | 15 +++++++++++++--
 drivers/clk/qcom/turingcc-qcs404.c | 13 ++++++++++++-
 8 files changed, 83 insertions(+), 16 deletions(-)

Comments

Konrad Dybcio July 18, 2023, 1:46 p.m. UTC | #1

On 18.07.2023 15:28, Johan Hovold wrote:
> This series fixes a number of runtime PM related bugs found through
> inspection.
> 
> Johan
I was thinking whether we should maybe incorporate RPM enablement
into qcom common functions.. The only issue I see is that some
clocks register pm clocks atop that, but I guess we could introduce
some sort of a pm_clks names array to solve that?

Konrad

Bjorn Andersson July 18, 2023, 7:10 p.m. UTC | #2

On Tue, 18 Jul 2023 15:28:54 +0200, Johan Hovold wrote:
> This series fixes a number of runtime PM related bugs found through
> inspection.
> 
> Johan
> 
> 
> Johan Hovold (8):
>   clk: qcom: camcc-sc7180: fix async resume during probe
>   clk: qcom: dispcc-sm8450: fix runtime PM imbalance on probe errors
>   clk: qcom: dispcc-sm8550: fix runtime PM imbalance on probe errors
>   clk: qcom: gcc-sc8280xp: fix runtime PM imbalance on probe errors
>   clk: qcom: lpasscc-sc7280: fix missing resume during probe
>   clk: qcom: q6sstop-qcs404: fix missing resume during probe
>   clk: qcom: mss-sc7180: fix missing resume during probe
>   clk: qcom: turingcc-qcs404: fix missing resume during probe
> 
> [...]

Applied, thanks!

[1/8] clk: qcom: camcc-sc7180: fix async resume during probe
      commit: c948ff727e25297f3a703eb5349dd66aabf004e4
[2/8] clk: qcom: dispcc-sm8450: fix runtime PM imbalance on probe errors
      commit: b0f3d01bda6c3f6f811e70f76d2040ae81f64565
[3/8] clk: qcom: dispcc-sm8550: fix runtime PM imbalance on probe errors
      commit: acaf1b3296a504d4a61b685f78baae771421608d
[4/8] clk: qcom: gcc-sc8280xp: fix runtime PM imbalance on probe errors
      commit: 10192ab375c39c58d39cba028d9685cefe1ca3c2
[5/8] clk: qcom: lpasscc-sc7280: fix missing resume during probe
      commit: 66af5339d4f8e20c6d89a490570bd94d40f1a7f6
[6/8] clk: qcom: q6sstop-qcs404: fix missing resume during probe
      commit: 97112c83f4671a4a722f99a53be4e91fac4091bc
[7/8] clk: qcom: mss-sc7180: fix missing resume during probe
      commit: e2349da0fa7ca822cda72f427345b95795358fe7
[8/8] clk: qcom: turingcc-qcs404: fix missing resume during probe
      commit: a9f71a033587c9074059132d34c74eabbe95ef26

Best regards,

Johan Hovold July 19, 2023, 7:23 a.m. UTC | #3

On Tue, Jul 18, 2023 at 03:46:03PM +0200, Konrad Dybcio wrote:
> On 18.07.2023 15:28, Johan Hovold wrote:
> > This series fixes a number of runtime PM related bugs found through
> > inspection.

> I was thinking whether we should maybe incorporate RPM enablement
> into qcom common functions.. The only issue I see is that some
> clocks register pm clocks atop that, but I guess we could introduce
> some sort of a pm_clks names array to solve that?

Possibly, but you currently also have the hardcoded clock enables and
some other variations.

Johan