mbox series

[0/3] USB: dwc3: qcom: fix wakeup after probe deferral

Message ID 20231120161607.7405-1-johan+linaro@kernel.org (mailing list archive)
Headers show
Series USB: dwc3: qcom: fix wakeup after probe deferral | expand

Message

Johan Hovold Nov. 20, 2023, 4:16 p.m. UTC 
When testing a recent series that addresses resource leaks on probe
deferral [1] I realised that probe deferral can break wakeup from
suspend due to how the wakeup interrupts are currently requested.

I'll send a separate series for the Qualcomm devicetrees that used
incorrect trigger types for the wakeup interrupts. Included here is just
a patch fixing the binding example which hopefully will make it less
likely that more of these gets introduced. Fortunately, there should be
no dependency between this series and the devicetree one.

Note also that I decided to include a related trivial cleanup patch.

Johan


[1] https://lore.kernel.org/lkml/20231117173650.21161-1-johan+linaro@kernel.org/


Johan Hovold (3):
  dt-bindings: usb: qcom,dwc3: fix example wakeup interrupt types
  USB: dwc3: qcom: fix wakeup after probe deferral
  USB: dwc3: qcom: simplify wakeup interrupt setup

 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml |  4 ++--
 drivers/usb/dwc3/dwc3-qcom.c                         | 12 ++++--------
 2 files changed, 6 insertions(+), 10 deletions(-)

Comments

Andrew Halaney Nov. 21, 2023, 2:04 p.m. UTC | #1 
On Mon, Nov 20, 2023 at 05:16:04PM +0100, Johan Hovold wrote:
> When testing a recent series that addresses resource leaks on probe
> deferral [1] I realised that probe deferral can break wakeup from
> suspend due to how the wakeup interrupts are currently requested.
> 
> I'll send a separate series for the Qualcomm devicetrees that used
> incorrect trigger types for the wakeup interrupts. Included here is just
> a patch fixing the binding example which hopefully will make it less
> likely that more of these gets introduced. Fortunately, there should be
> no dependency between this series and the devicetree one.
> 
> Note also that I decided to include a related trivial cleanup patch.
> 
> Johan
> 
> 
> [1] https://lore.kernel.org/lkml/20231117173650.21161-1-johan+linaro@kernel.org/
> 
> 
> Johan Hovold (3):
>   dt-bindings: usb: qcom,dwc3: fix example wakeup interrupt types
>   USB: dwc3: qcom: fix wakeup after probe deferral
>   USB: dwc3: qcom: simplify wakeup interrupt setup

For the series:

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>

> 
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml |  4 ++--
>  drivers/usb/dwc3/dwc3-qcom.c                         | 12 ++++--------
>  2 files changed, 6 insertions(+), 10 deletions(-)
> 
> -- 
> 2.41.0
> 
>