From patchwork Mon Nov 27 12:13:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Chaitanya Chundru X-Patchwork-Id: 13469467 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="J11STfDK" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18D5C101; Mon, 27 Nov 2023 04:14:29 -0800 (PST) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AR6smjJ008693; Mon, 27 Nov 2023 12:14:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : subject : date : message-id : mime-version : content-type : content-transfer-encoding : to : cc; s=qcppdkim1; bh=vClwkOHgG/gZmrqLMBX55wvjdeEUUTVIg+b1zvKB++s=; b=J11STfDKtBtqziczX0qn+/vh0llYGupbAzNauOlICO0M54RqyTa6x/yFvJnlITorlw3r VHnCbH/kTPPrDX6RzzeybasTfSgA/gtJnIfJhQgx+DAQc931WkWysN7EgjiD9OFLw4HD RrkUPP5qvCQ4hPHh9FDhpobJk56NQKuL8/LWSZ45CX7KNC2HU+wPAvFLLpbQ5VM8A0hO OQPcCO6euIm0gpEtjAXUHGh70ABNNXc56tujjgGSgZePNWZKwIJuxq88HnSPK2OmcTXx TklLjkd1uKq2rpd66Za+cSJ6KEWga8OgX4akXBcgg5iI4w9fRVSTu/hks41Rem7E8dJz KA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uk95cc40w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Nov 2023 12:14:23 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3ARCEMCD014861 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Nov 2023 12:14:22 GMT Received: from hu-krichai-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 27 Nov 2023 04:14:16 -0800 From: Krishna chaitanya chundru Subject: [PATCH v3 0/3] phy: qcom-qmp-pcie: Add support to keep refclk always on Date: Mon, 27 Nov 2023 17:43:48 +0530 Message-ID: <20231127-refclk_always_on-v3-0-26d969fa8f1d@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAP6HZGUC/33NwQ6CMAyA4VchOzvDOmXgyfcwhmxjSCNuuumUE N7dwUkT4/Fv2q8jCcajCWSXjcSbiAGdTcFXGdGdtCdDsUlNIAfOWF5Qb1rdn2vZP+UQamdppYw 0JVRCq5Kks2vawNdCHo6pOwx354flQ2Tz9A8WGc0pE1K0Tam2HNT+9kCNVq+1u5CZi/BJiB8EJ KIxwKsCWr1R/JuYpukNo4RcpvUAAAA= To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , , , , , , , , , "Krishna chaitanya chundru" , Dmitry Baryshkov X-Mailer: b4 0.13-dev-83828 X-Developer-Signature: v=1; a=ed25519-sha256; t=1701087256; l=2204; i=quic_krichai@quicinc.com; s=20230907; h=from:subject:message-id; bh=zwRcEn2JJMlI3K+aZ3E+nZH0JUyB40bJf8sdwp5BDSw=; b=Usb4J4AeWk89oDnNxCSO/cdVUIrdxete6ptYyTeN/BoO2w68zTUe37ja+2GgOwTNBfizKAOnl tGbIqNewu65AWSTsnTVULKnNdtsMZ7OQLcX7C/LX6zfvnbYUTAVZ5G3 X-Developer-Key: i=quic_krichai@quicinc.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: e2WlklcLz_SUTI1LgI-FzxXa7P8uAXWz X-Proofpoint-ORIG-GUID: e2WlklcLz_SUTI1LgI-FzxXa7P8uAXWz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-27_09,2023-11-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 mlxlogscore=673 spamscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311270083 This series adds support to provide refclk to endpoint even in low power states. Due to some platform specific issues with CLKREQ signal, it is not being propagated to the host and as host doesn't know the clkreq signal host is not sending refclk. Due to this endpoint is seeing linkdown and going to bad state. To avoid those ref clk should be provided always to the endpoint. The issue is coming only when ep intiates the L1.1 or L1.2 exit and clkreq is not being propagated properly to the host. Signed-off-by: Krishna chaitanya chundru --- Changes in v3: - Updated the dt-binding description as suggested by Dmitry. - Added the new macros for v5_20 and v6_20 as suggested by Dmitry. - Link to v2: https://lore.kernel.org/r/20231107-refclk_always_on-v2-0-de23962fc4b3@quicinc.com Changes in v2: - Added refclk cntrl registers to the applicable phy versions & added reg layout where - refclk cntrl offset needs to be updated (Dmitry) - Error out if refclk_always_on is set and there is no refclk control register to enable it (Dmitry) - updated the dt-binding description & some nit's as suggested by (Bjorn) - Link to v1: https://lore.kernel.org/r/20231106-refclk_always_on-v1-0-17a7fd8b532b@quicinc.com --- Krishna chaitanya chundru (3): dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property phy: qcom-qmp-pcie: Add endpoint refclk control register offset phy: qcom-qmp-pcie: Add support for keeping refclk always on .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 ++++ drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 40 ++++++++++++++++++++-- drivers/phy/qualcomm/phy-qcom-qmp-pcs-pcie-v5.h | 1 + drivers/phy/qualcomm/phy-qcom-qmp-pcs-pcie-v5_20.h | 1 + drivers/phy/qualcomm/phy-qcom-qmp-pcs-pcie-v6_20.h | 1 + drivers/phy/qualcomm/phy-qcom-qmp-pcs-v5_20.h | 4 +++ drivers/phy/qualcomm/phy-qcom-qmp-pcs-v6_20.h | 4 +++ 7 files changed, 55 insertions(+), 3 deletions(-) --- base-commit: 71e68e182e382e951d6248bccc3c960dcec5a718 change-id: 20231106-refclk_always_on-9beae8297cb8 Best regards,