| Message ID | 20240205145606.16936-1-quic_okukatla@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for QoS configuration | expand |
On 2/5/24 15:56, Odelu Kukatla wrote: > This series adds QoS support for QNOC type device which can be found on > SC7280 platform. It adds support for programming priority, > priority forward disable and urgency forwarding. This helps in > priortizing the traffic originating from different interconnect masters > at NOC(Network On Chip). > > Changes in v2: > - Updated regmap_update to make use GENMASK and FIELD_PREP. > - Removed the regmap structure from qcom_icc_node. > - Made qcom_icc_rpmh_configure_qos() static > - Removed qcom_icc_rpmh_map() API, inlined the code in probe > function. > - Updated declarations to reverse christmas tree fashion. You ignored some of my previous review comments without a response. Konrad
On 2/6/2024 2:37 PM, Konrad Dybcio wrote: > > > On 2/5/24 15:56, Odelu Kukatla wrote: >> This series adds QoS support for QNOC type device which can be found on >> SC7280 platform. It adds support for programming priority, >> priority forward disable and urgency forwarding. This helps in >> priortizing the traffic originating from different interconnect masters >> at NOC(Network On Chip). >> >> Changes in v2: >> - Updated regmap_update to make use GENMASK and FIELD_PREP. >> - Removed the regmap structure from qcom_icc_node. >> - Made qcom_icc_rpmh_configure_qos() static >> - Removed qcom_icc_rpmh_map() API, inlined the code in probe >> function. >> - Updated declarations to reverse christmas tree fashion. > > You ignored some of my previous review comments without a response. > > Konrad Thanks Konrad! i replied to all of your comments. I will send V3 with all the comments addressed. Thanks, Odelu
This series adds QoS support for QNOC type device which can be found on SC7280 platform. It adds support for programming priority, priority forward disable and urgency forwarding. This helps in priortizing the traffic originating from different interconnect masters at NOC(Network On Chip). Changes in v2: - Updated regmap_update to make use GENMASK and FIELD_PREP. - Removed the regmap structure from qcom_icc_node. - Made qcom_icc_rpmh_configure_qos() static - Removed qcom_icc_rpmh_map() API, inlined the code in probe function. - Updated declarations to reverse christmas tree fashion. Odelu Kukatla (4): interconnect: qcom: icc-rpmh: Add QoS configuration support interconnect: qcom: sc7280: enable QoS configuration dt-bindings: interconnect: add clock property to configure QoS on SC7280 arm64: dts: qcom: sc7280: Add clocks for QoS configuration .../interconnect/qcom,sc7280-rpmh.yaml | 49 +++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 + drivers/interconnect/qcom/icc-rpmh.c | 161 ++++++++- drivers/interconnect/qcom/icc-rpmh.h | 32 ++ drivers/interconnect/qcom/sc7280.c | 332 ++++++++++++++++++ 5 files changed, 573 insertions(+), 4 deletions(-)