[v2,0/2] arm64: add minimal boot support for TP-Link Archer AX55 v1

Message

Gabor Juhos Feb. 26, 2024, 5:12 p.m. UTC

The purpose of this series to add minimal boot support for the
TP-Link Archer AX55 v1 dual-band wireless router.

There are two patches:
  - the first one adds the compatible for the board into the dt-bindings
    documentation,
  - the second patch introduces a minimal device tree source which can be
    used for booting initramfs images

---
Changes in v2:
  - reorder pin configuration properties in patch 2/2
  - add 'Acked-by' tag to patch 1/2
  - Link to v1: https://lore.kernel.org/r/[e-mail]

---
Gabor Juhos (2):
      dt-bindings: arm: qcom: add TP-Link Archer AX55 v1
      arm64: dts: qcom: add TP-Link Archer AX55 v1

 Documentation/devicetree/bindings/arm/qcom.yaml    |   1 +
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 .../dts/qcom/ipq5018-tplink-archer-ax55-v1.dts     | 133 +++++++++++++++++++++
 3 files changed, 135 insertions(+)
---
base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
change-id: 20240221-archer-ax55-v1-73ed91a97c6e

Best regards,

Comments

Rob Herring (Arm) Feb. 27, 2024, 1:45 p.m. UTC | #1

On Mon, 26 Feb 2024 18:12:38 +0100, Gabor Juhos wrote:
> The purpose of this series to add minimal boot support for the
> TP-Link Archer AX55 v1 dual-band wireless router.
> 
> There are two patches:
>   - the first one adds the compatible for the board into the dt-bindings
>     documentation,
>   - the second patch introduces a minimal device tree source which can be
>     used for booting initramfs images
> 
> ---
> Changes in v2:
>   - reorder pin configuration properties in patch 2/2
>   - add 'Acked-by' tag to patch 1/2
>   - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Gabor Juhos (2):
>       dt-bindings: arm: qcom: add TP-Link Archer AX55 v1
>       arm64: dts: qcom: add TP-Link Archer AX55 v1
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml    |   1 +
>  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>  .../dts/qcom/ipq5018-tplink-archer-ax55-v1.dts     | 133 +++++++++++++++++++++
>  3 files changed, 135 insertions(+)
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240221-archer-ax55-v1-73ed91a97c6e
> 
> Best regards,
> --
> Gabor Juhos <[e-mail]>
> 
> 
> 


My bot found new DT warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/ipq5018-tplink-archer-ax55-v1.dtb' for [e-mail]:

arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#

Gabor Juhos Feb. 27, 2024, 2:51 p.m. UTC | #2

Hello Rob,

2024. 02. 27. 14:45 keltezéssel, Rob Herring írta:

> My bot found new DT warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y qcom/ipq5018-tplink-archer-ax55-v1.dtb' for [e-mail]:
> 
> arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
> 	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
> arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
> 	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
> arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
> 	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
> arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
> 	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
> arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
> 	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
> 

These are caused by the 'usb@8af8800' defined in the SoC .dtsi
(arch/arm64/boot/dts/qcom/ipq5018.dtsi) file. I saw the warnings, and I have
indicated that in the previous version of the patch [1].

Sorry, I should have kept that note in the current version as well.

Regards,
Gabor

1. https://lore.kernel.org/r/[e-mail]