| Message ID | 20240314-msm8916-drop-compats-v2-0-5a4b40f832d3@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: msm8916: drop dtbTool compatibles | expand |
rOn Thu, Mar 14, 2024 at 03:42:47AM +0200, Dmitry Baryshkov wrote: > Only two boards ever has adopted the dtbTool-specific compatibles. > However the dtbTool should not be used anymore. It was required only for > the old, broken lk1st bootloader. All users of those boards should have > updated to use lk2nd instead. Otherwise several important features > (secondary CPU cores, WiFi, BT) will not work with the upstream kernel. Nitpick: The term "the old, broken lk1st bootloader" is a bit misleading here. I believe you are referring to Qualcomm's original LK bootloader. "lk1st" is actually the name of an alternative configuration in the lk2nd project that can be used to replace the first-stage bootloader on devices without secure boot, e.g. DB410c and a few smartphones. lk1st has exactly the same functionality as lk2nd and is therefore definitely not old and broken. Both support DTB selection, secondary CPU cores etc. :-) I don't think we put the cover letter into a merge commit message in the qcom tree, so there is no need to resend. I just wanted to clarify this. Thanks for cleaning this up! Stephan
On Thu, 14 Mar 2024 03:42:47 +0200, Dmitry Baryshkov wrote: > Only two boards ever has adopted the dtbTool-specific compatibles. > However the dtbTool should not be used anymore. It was required only for > the old, broken lk1st bootloader. All users of those boards should have > updated to use lk2nd instead. Otherwise several important features > (secondary CPU cores, WiFi, BT) will not work with the upstream kernel. > > Drop these extra compatibles, merging these two boards into the common > bindings case for msm8916. > > [...] Applied, thanks! [1/2] dt-bindings: arm: qcom: drop dtbTool-specific compatibles commit: 88d0e4e10d77bb4e575b74ac0f6dd3140ecc3bcd [2/2] arm64: dts: qcom: msm8916: drop dtbTool-specific compatibles commit: 3867ad6d39cd97875aca7e5f1b17ea6dd5b1107a Best regards,
Only two boards ever has adopted the dtbTool-specific compatibles. However the dtbTool should not be used anymore. It was required only for the old, broken lk1st bootloader. All users of those boards should have updated to use lk2nd instead. Otherwise several important features (secondary CPU cores, WiFi, BT) will not work with the upstream kernel. Drop these extra compatibles, merging these two boards into the common bindings case for msm8916. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v2: - Drop the compatibles from bindings too (Krzysztof) - Add cover letter, describing why everybody has switched to lk2nd. - Link to v1: https://lore.kernel.org/r/20240221-msm8916-drop-compats-v1-1-71acdab14738@linaro.org --- Dmitry Baryshkov (2): dt-bindings: arm: qcom: drop dtbTool-specific compatibles arm64: dts: qcom: msm8916: drop dtbTool-specific compatibles Documentation/devicetree/bindings/arm/qcom.yaml | 12 ++---------- arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 2 +- arch/arm64/boot/dts/qcom/msm8916-mtp.dts | 2 +- 3 files changed, 4 insertions(+), 12 deletions(-) --- base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd change-id: 20240221-msm8916-drop-compats-7f608aa48948 Best regards,