| Message ID | 20240329-llcc-broadcast-and-v4-0-107c76fd8ceb@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | LLCC: Support for Broadcast_AND region | expand |
On 29/03/2024 22:53, Unnathi Chalicheemala wrote: > This series adds: > 1. Device tree register mapping for Broadcast_AND region in SM8450, > SM8550, SM8650. > 2. LLCC driver updates to reflect addition of Broadcast_AND regmap. > > To support CSR programming, a broadcast interface is used to program all > channels in a single command. Until SM8450 there was only one broadcast > region (Broadcast_OR) used to broadcast write and check for status bit > 0. From SM8450 onwards another broadcast region (Broadcast_AND) has been > added which checks for status bit 1. > > This series updates the device trees from SM8450 onwards to have a > mapping to this Broadcast_AND region. It also updates the llcc_drv_data > structure with a regmap for Broadcast_AND region and corrects the > broadcast region used to check for status bit 1. Your way of sending patches makes it difficult for us to review them. b4 diff -C '<20240329-llcc-broadcast-and-v4-0-107c76fd8ceb@quicinc.com>' Grabbing thread from lore.kernel.org/all/20240329-llcc-broadcast-and-v4-0-107c76fd8ceb@quicinc.com/t.mbox.gz Checking for older revisions Added from v3: 5 patches --- Analyzing 39 messages in the thread Preparing fake-am for v3: dt-bindings: arm: msm: Add llcc Broadcast_AND register ERROR: v3 series incomplete; unable to create a fake-am range --- Could not create fake-am range for lower series v3 Please reach internally within Qualcomm to get some guidance how to properly set up your work environment. Best regards, Krzysztof
This series adds: 1. Device tree register mapping for Broadcast_AND region in SM8450, SM8550, SM8650. 2. LLCC driver updates to reflect addition of Broadcast_AND regmap. To support CSR programming, a broadcast interface is used to program all channels in a single command. Until SM8450 there was only one broadcast region (Broadcast_OR) used to broadcast write and check for status bit 0. From SM8450 onwards another broadcast region (Broadcast_AND) has been added which checks for status bit 1. This series updates the device trees from SM8450 onwards to have a mapping to this Broadcast_AND region. It also updates the llcc_drv_data structure with a regmap for Broadcast_AND region and corrects the broadcast region used to check for status bit 1. Changes in v4: - Updated Devicetree patches' commit messages to make problem statement clearer - Resolved Konrad's comments on driver code patch - Updated v3 changelog to include dropped R-b tag Changes in v3: - Removed new example in dt-bindings patch and ran 'make DT_CHECKER_FLAGS=-m dt_binding_check' - Dropped Krzysztof's R-b tag on dt-bindings patch - Use of ternary operator in llcc_update_act_ctrl() - Add comment before initialization of Broadcast_AND regmap in probe function - Move DeviceTree patches to the end Changes in v2: - Added an additional check in the case old DT files are used for above mentioned chipsets for backwards compatibility - Moved addition of if check in llcc_update_act_ctrl() to a separate "Fixes" patch; not part of this series Link to v3: https://lore.kernel.org/all/cover.1708551850.git.quic_uchalich@quicinc.com/ Link to v2: https://lore.kernel.org/all/cover.1707202761.git.quic_uchalich@quicinc.com/ Link to v1: https://lore.kernel.org/all/cover.1706296015.git.quic_uchalich@quicinc.com/ Unnathi Chalicheemala (5): dt-bindings: arm: msm: Add llcc Broadcast_AND register soc: qcom: llcc: Add regmap for Broadcast_AND region arm64: dts: qcom: sm8450: Add mapping to llcc Broadcast_AND region arm64: dts: qcom: sm8550: Add mapping to llcc Broadcast_AND region arm64: dts: qcom: sm8650: Add mapping to llcc Broadcast_AND region .../devicetree/bindings/cache/qcom,llcc.yaml | 27 ++++++++++++++++++- arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 ++-- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++-- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++-- drivers/soc/qcom/llcc-qcom.c | 15 ++++++++++- include/linux/soc/qcom/llcc-qcom.h | 4 ++- 6 files changed, 54 insertions(+), 9 deletions(-) -- 2.25.1 --- Unnathi Chalicheemala (5): dt-bindings: arm: msm: Add llcc Broadcast_AND register soc: qcom: llcc: Add regmap for Broadcast_AND region arm64: dts: qcom: sm8450: Add mapping to llcc Broadcast_AND region arm64: dts: qcom: sm8550: Add Broadcast_AND register in LLCC block arm64: dts: qcom: sm8650: Add Broadcast_AND register in LLCC block .../devicetree/bindings/cache/qcom,llcc.yaml | 27 +++++++++++++++++++++- arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 ++-- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++-- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++-- drivers/soc/qcom/llcc-qcom.c | 14 ++++++++++- include/linux/soc/qcom/llcc-qcom.h | 4 +++- 6 files changed, 53 insertions(+), 9 deletions(-) --- base-commit: 4535e1a4174c4111d92c5a9a21e542d232e0fcaa change-id: 20240329-llcc-broadcast-and-eec0838308d6 Best regards,