| Message ID | 20240331-typec-fix-sm8250-v2-0-857acb6bd88e@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: fix description of the Type-C signals | expand |
On Sun, 31 Mar 2024 06:48:50 +0300, Dmitry Baryshkov wrote: > Rename the HS link between usb-c-connector and the DWC3 USB controller. > Add missing graph connection between the QMP PHY and DWC3 USB > controller. > > Reported-by: Luca Weiss <luca.weiss@fairphone.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes in v2: > - Fixed other platforms in addition to sm8250 (Bryan) > - Link to v1: https://lore.kernel.org/r/20240322-typec-fix-sm8250-v1-0-1ac22b333ea9@linaro.org > > --- > Dmitry Baryshkov (7): > arm64: dts: qcom: sm8250: describe HS signals properly > arm64: dts: qcom: sm8250: add a link between DWC3 and QMP PHY > arm64: dts: qcom: sc8180x: switch USB+DP QMP PHYs to new bindings > arm64: dts: qcom: sc8180x: describe USB signals properly > arm64: dts: qcom: sc8280xp: describe USB signals properly > arm64: dts: qcom: x1e80100: describe USB signals properly > arm64: dts: qcom: sm8150-hdk: rename Type-C HS endpoints > > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 +- > .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 16 +- > arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 20 +-- > arch/arm64/boot/dts/qcom/sc8180x.dtsi | 164 ++++++++++----------- > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 20 +-- > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 20 +-- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 54 ++++++- > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 4 +- > .../boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 8 +- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 24 ++- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 149 ++++++++++++++++++- > 11 files changed, 340 insertions(+), 147 deletions(-) > --- > base-commit: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 > change-id: 20240322-typec-fix-sm8250-33c47a03a056 > > Best regards, > -- > Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/qrb5165-rb5.dtb qcom/sc8180x-lenovo-flex-5g.dtb qcom/sc8180x-primus.dtb qcom/sc8280xp-crd.dtb qcom/sc8280xp-lenovo-thinkpad-x13s.dtb qcom/sm8150-hdk.dtb' for 20240331-typec-fix-sm8250-v2-0-857acb6bd88e@linaro.org: arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dtb: clock-controller@af00000: clocks: [[41, 0], [42], [95, 1], [95, 2], [99, 1], [99, 2], [125, 0], [125, 1]] is too long from schema $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml# arch/arm64/boot/dts/qcom/sc8180x-primus.dtb: clock-controller@af00000: clocks: [[41, 0], [42], [97, 1], [97, 2], [101, 1], [101, 2], [127, 0], [127, 1]] is too long from schema $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml#
On Mon, 1 Apr 2024 at 19:36, Rob Herring <robh@kernel.org> wrote: > > > On Sun, 31 Mar 2024 06:48:50 +0300, Dmitry Baryshkov wrote: > > Rename the HS link between usb-c-connector and the DWC3 USB controller. > > Add missing graph connection between the QMP PHY and DWC3 USB > > controller. > > > > Reported-by: Luca Weiss <luca.weiss@fairphone.com> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > Changes in v2: > > - Fixed other platforms in addition to sm8250 (Bryan) > > - Link to v1: https://lore.kernel.org/r/20240322-typec-fix-sm8250-v1-0-1ac22b333ea9@linaro.org > > > > --- > > Dmitry Baryshkov (7): > > arm64: dts: qcom: sm8250: describe HS signals properly > > arm64: dts: qcom: sm8250: add a link between DWC3 and QMP PHY > > arm64: dts: qcom: sc8180x: switch USB+DP QMP PHYs to new bindings > > arm64: dts: qcom: sc8180x: describe USB signals properly > > arm64: dts: qcom: sc8280xp: describe USB signals properly > > arm64: dts: qcom: x1e80100: describe USB signals properly > > arm64: dts: qcom: sm8150-hdk: rename Type-C HS endpoints > > > > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 +- > > .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 16 +- > > arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 20 +-- > > arch/arm64/boot/dts/qcom/sc8180x.dtsi | 164 ++++++++++----------- > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 20 +-- > > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 20 +-- > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 54 ++++++- > > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 4 +- > > .../boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 8 +- > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 24 ++- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 149 ++++++++++++++++++- > > 11 files changed, 340 insertions(+), 147 deletions(-) > > --- > > base-commit: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 > > change-id: 20240322-typec-fix-sm8250-33c47a03a056 > > > > Best regards, > > -- > > Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y qcom/qrb5165-rb5.dtb qcom/sc8180x-lenovo-flex-5g.dtb qcom/sc8180x-primus.dtb qcom/sc8280xp-crd.dtb qcom/sc8280xp-lenovo-thinkpad-x13s.dtb qcom/sm8150-hdk.dtb' for 20240331-typec-fix-sm8250-v2-0-857acb6bd88e@linaro.org: > > arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dtb: clock-controller@af00000: clocks: [[41, 0], [42], [95, 1], [95, 2], [99, 1], [99, 2], [125, 0], [125, 1]] is too long > from schema $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml# > arch/arm64/boot/dts/qcom/sc8180x-primus.dtb: clock-controller@af00000: clocks: [[41, 0], [42], [97, 1], [97, 2], [101, 1], [101, 2], [127, 0], [127, 1]] is too long > from schema $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml# I don' t think it's new, it just had PHY indices changed. But let's fix it anyway. > > > > >
Rename the HS link between usb-c-connector and the DWC3 USB controller. Add missing graph connection between the QMP PHY and DWC3 USB controller. Reported-by: Luca Weiss <luca.weiss@fairphone.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v2: - Fixed other platforms in addition to sm8250 (Bryan) - Link to v1: https://lore.kernel.org/r/20240322-typec-fix-sm8250-v1-0-1ac22b333ea9@linaro.org --- Dmitry Baryshkov (7): arm64: dts: qcom: sm8250: describe HS signals properly arm64: dts: qcom: sm8250: add a link between DWC3 and QMP PHY arm64: dts: qcom: sc8180x: switch USB+DP QMP PHYs to new bindings arm64: dts: qcom: sc8180x: describe USB signals properly arm64: dts: qcom: sc8280xp: describe USB signals properly arm64: dts: qcom: x1e80100: describe USB signals properly arm64: dts: qcom: sm8150-hdk: rename Type-C HS endpoints arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 +- .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 16 +- arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 20 +-- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 164 ++++++++++----------- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 20 +-- .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 20 +-- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 54 ++++++- arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 4 +- .../boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 8 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 24 ++- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 149 ++++++++++++++++++- 11 files changed, 340 insertions(+), 147 deletions(-) --- base-commit: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 change-id: 20240322-typec-fix-sm8250-33c47a03a056 Best regards,