mbox series

[v1,0/8] spi: Rework DMA mapped flag

Message ID 20240531194723.1761567-1-andriy.shevchenko@linux.intel.com (mailing list archive)
Headers show
Series spi: Rework DMA mapped flag | expand

Message

Andy Shevchenko May 31, 2024, 7:42 p.m. UTC
The first part of the series (patches 1 to 7) is an introduction
of a new helper followed by the user conversion.

This consolidates the same code and also makes patch 8 (last one)
be localised to the SPI core part.

The last patch is the main rework to get rid of a recently introduced
hack with a dummy SG list and move to the transfer-based DMA mapped
flag. 

That said, the patches 1 to 7 may be applied right away since they
have no functional change intended, while the last one needs more
testing and reviewing.

Andy Shevchenko (8):
  spi: Introduce internal spi_xfer_is_dma_mapped() helper
  spi: dw: Use new spi_xfer_is_dma_mapped() helper
  spi: ingenic: Use new spi_xfer_is_dma_mapped() helper
  spi: omap2-mcspi: Use new spi_xfer_is_dma_mapped() helper
  spi: pxa2xx: Use new spi_xfer_is_dma_mapped() helper
  spi: pci1xxxx: Use new spi_xfer_is_dma_mapped() helper
  spi: qup: Use new spi_xfer_is_dma_mapped() helper
  spi: Rework per message DMA mapped flag to be per transfer

 drivers/spi/internals.h       |  8 ++++
 drivers/spi/spi-dw-core.c     |  4 +-
 drivers/spi/spi-ingenic.c     |  4 +-
 drivers/spi/spi-omap2-mcspi.c |  8 ++--
 drivers/spi/spi-pci1xxxx.c    |  5 ++-
 drivers/spi/spi-pxa2xx.c      |  6 +--
 drivers/spi/spi-qup.c         |  9 ++---
 drivers/spi/spi.c             | 73 +++++++++++++----------------------
 include/linux/spi/spi.h       | 11 ++++--
 9 files changed, 59 insertions(+), 69 deletions(-)

Comments

Neil Armstrong June 3, 2024, 9:10 a.m. UTC | #1
On 31/05/2024 21:42, Andy Shevchenko wrote:
> The first part of the series (patches 1 to 7) is an introduction
> of a new helper followed by the user conversion.
> 
> This consolidates the same code and also makes patch 8 (last one)
> be localised to the SPI core part.
> 
> The last patch is the main rework to get rid of a recently introduced
> hack with a dummy SG list and move to the transfer-based DMA mapped
> flag.
> 
> That said, the patches 1 to 7 may be applied right away since they
> have no functional change intended, while the last one needs more
> testing and reviewing.
> 
> Andy Shevchenko (8):
>    spi: Introduce internal spi_xfer_is_dma_mapped() helper
>    spi: dw: Use new spi_xfer_is_dma_mapped() helper
>    spi: ingenic: Use new spi_xfer_is_dma_mapped() helper
>    spi: omap2-mcspi: Use new spi_xfer_is_dma_mapped() helper
>    spi: pxa2xx: Use new spi_xfer_is_dma_mapped() helper
>    spi: pci1xxxx: Use new spi_xfer_is_dma_mapped() helper
>    spi: qup: Use new spi_xfer_is_dma_mapped() helper
>    spi: Rework per message DMA mapped flag to be per transfer
> 
>   drivers/spi/internals.h       |  8 ++++
>   drivers/spi/spi-dw-core.c     |  4 +-
>   drivers/spi/spi-ingenic.c     |  4 +-
>   drivers/spi/spi-omap2-mcspi.c |  8 ++--
>   drivers/spi/spi-pci1xxxx.c    |  5 ++-
>   drivers/spi/spi-pxa2xx.c      |  6 +--
>   drivers/spi/spi-qup.c         |  9 ++---
>   drivers/spi/spi.c             | 73 +++++++++++++----------------------
>   include/linux/spi/spi.h       | 11 ++++--
>   9 files changed, 59 insertions(+), 69 deletions(-)
> 

I applied the serie on next-20240603, it worked fine:

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD

Thanks,
Neil
Nícolas F. R. A. Prado June 3, 2024, 7:49 p.m. UTC | #2
On Fri, May 31, 2024 at 10:42:32PM +0300, Andy Shevchenko wrote:
> The first part of the series (patches 1 to 7) is an introduction
> of a new helper followed by the user conversion.
> 
> This consolidates the same code and also makes patch 8 (last one)
> be localised to the SPI core part.
> 
> The last patch is the main rework to get rid of a recently introduced
> hack with a dummy SG list and move to the transfer-based DMA mapped
> flag. 
> 
> That said, the patches 1 to 7 may be applied right away since they
> have no functional change intended, while the last one needs more
> testing and reviewing.
> 
> Andy Shevchenko (8):
>   spi: Introduce internal spi_xfer_is_dma_mapped() helper
>   spi: dw: Use new spi_xfer_is_dma_mapped() helper
>   spi: ingenic: Use new spi_xfer_is_dma_mapped() helper
>   spi: omap2-mcspi: Use new spi_xfer_is_dma_mapped() helper
>   spi: pxa2xx: Use new spi_xfer_is_dma_mapped() helper
>   spi: pci1xxxx: Use new spi_xfer_is_dma_mapped() helper
>   spi: qup: Use new spi_xfer_is_dma_mapped() helper
>   spi: Rework per message DMA mapped flag to be per transfer

Tested on next-20240603. No issue noticed on sc7180-trogdor-kingoftown and
sc7180-trogdor-lazor-limozeen. So,

Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Although patch 5 (pxa2xx) didn't apply, so I skipped it (but it's not used on
my platforms).

Thanks,
Nícolas
Andy Shevchenko June 3, 2024, 7:53 p.m. UTC | #3
On Mon, Jun 03, 2024 at 03:49:04PM -0400, Nícolas F. R. A. Prado wrote:
> On Fri, May 31, 2024 at 10:42:32PM +0300, Andy Shevchenko wrote:

...

> Tested on next-20240603. No issue noticed on sc7180-trogdor-kingoftown and
> sc7180-trogdor-lazor-limozeen. So,
> 
> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thank you!

> Although patch 5 (pxa2xx) didn't apply, so I skipped it (but it's not used on
> my platforms).

Yeah, I just commented on that, it appears that I have based this on the
previous driver cleanups (it was published a week ago).
Andy Shevchenko June 3, 2024, 7:54 p.m. UTC | #4
On Mon, Jun 03, 2024 at 11:10:54AM +0200, Neil Armstrong wrote:
> On 31/05/2024 21:42, Andy Shevchenko wrote:

...

> I applied the serie on next-20240603, it worked fine:
> 
> Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD

Thank you!