| Message ID | 20240606-pci-deinit-v1-0-4395534520dc@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: endpoint: Add EPC 'deinit' event and dw_pcie_ep_linkdown() API | expand |
On Thu, Jun 06, 2024 at 12:56:33PM +0530, Manivannan Sadhasivam wrote: > Hi, > > This series includes patches that were left over from previous series [1] for > making the host reboot handling robust in endpoint framework. > > When the above mentioned series got merged to pci/endpoint, we got a bug report > from LKP bot [2] and due to that the offending patches were dropped. > > This series addressed the issue reported by the bot by adding the stub APIs in > include/pci/pci-epc.h and also removed the unused dwc wrapper as concluded in > [3]. > > Testing > ======= > > This series is tested on Qcom SM8450 based development board with 2 SM8450 SoCs > connected over PCIe. > > - Mani > > [1] https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-0-22832d0d456f@linaro.org/ > [2] https://lore.kernel.org/linux-pci/202405130815.BwBrIepL-lkp@intel.com/ > [3] https://lore.kernel.org/linux-pci/20240529141614.GA3293@thinkpad/ > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Manivannan Sadhasivam (5): > PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper > PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers > PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event > PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event > PCI: layerscape-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event > > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > drivers/pci/controller/dwc/pci-imx6.c | 2 +- > drivers/pci/controller/dwc/pci-keystone.c | 2 +- > drivers/pci/controller/dwc/pci-layerscape-ep.c | 4 +- > drivers/pci/controller/dwc/pcie-artpec6.c | 2 +- > drivers/pci/controller/dwc/pcie-designware-ep.c | 116 +++++++++++++--------- > drivers/pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 10 +- > drivers/pci/controller/dwc/pcie-keembay.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 5 +- > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 +- > drivers/pci/controller/dwc/pcie-tegra194.c | 3 +- > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +- > drivers/pci/endpoint/functions/pci-epf-mhi.c | 19 ++++ > drivers/pci/endpoint/functions/pci-epf-test.c | 17 +++- > drivers/pci/endpoint/pci-epc-core.c | 25 +++++ > include/linux/pci-epc.h | 13 +++ > include/linux/pci-epf.h | 2 + > 18 files changed, 162 insertions(+), 68 deletions(-) > --- > base-commit: 7d96527bc16e46545739c6fe0ab6e4c915e9910e > change-id: 20240606-pci-deinit-2e6cdf1bd69f > > Best regards, > -- > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Considering certain dependency patches have been merged to pci/endpoint and other dependency patches have been merged to pci/controller/dwc, perhaps it is best if you split this series: Series 1 based on pci/endpoint: with patch 1/5 and 2/5. Series 2 based on pci/controller/dwc: with patch 5/5. Just a friendly suggestion to make Bjorn's life easier (and grease the path of your patch) ;) [0] Kind regards, Niklas [0]: https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/ (I still have this in my bookmarks :P)
On Fri, Jun 07, 2024 at 11:31:28AM +0200, Niklas Cassel wrote: > On Thu, Jun 06, 2024 at 12:56:33PM +0530, Manivannan Sadhasivam wrote: > > Hi, > > > > This series includes patches that were left over from previous series [1] for > > making the host reboot handling robust in endpoint framework. > > > > When the above mentioned series got merged to pci/endpoint, we got a bug report > > from LKP bot [2] and due to that the offending patches were dropped. > > > > This series addressed the issue reported by the bot by adding the stub APIs in > > include/pci/pci-epc.h and also removed the unused dwc wrapper as concluded in > > [3]. > > > > Testing > > ======= > > > > This series is tested on Qcom SM8450 based development board with 2 SM8450 SoCs > > connected over PCIe. > > > > - Mani > > > > [1] https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-0-22832d0d456f@linaro.org/ > > [2] https://lore.kernel.org/linux-pci/202405130815.BwBrIepL-lkp@intel.com/ > > [3] https://lore.kernel.org/linux-pci/20240529141614.GA3293@thinkpad/ > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > Manivannan Sadhasivam (5): > > PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper > > PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers > > PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event > > PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event > > PCI: layerscape-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > > drivers/pci/controller/dwc/pci-imx6.c | 2 +- > > drivers/pci/controller/dwc/pci-keystone.c | 2 +- > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 4 +- > > drivers/pci/controller/dwc/pcie-artpec6.c | 2 +- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 116 +++++++++++++--------- > > drivers/pci/controller/dwc/pcie-designware-plat.c | 2 +- > > drivers/pci/controller/dwc/pcie-designware.h | 10 +- > > drivers/pci/controller/dwc/pcie-keembay.c | 2 +- > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 5 +- > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 +- > > drivers/pci/controller/dwc/pcie-tegra194.c | 3 +- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +- > > drivers/pci/endpoint/functions/pci-epf-mhi.c | 19 ++++ > > drivers/pci/endpoint/functions/pci-epf-test.c | 17 +++- > > drivers/pci/endpoint/pci-epc-core.c | 25 +++++ > > include/linux/pci-epc.h | 13 +++ > > include/linux/pci-epf.h | 2 + > > 18 files changed, 162 insertions(+), 68 deletions(-) > > --- > > base-commit: 7d96527bc16e46545739c6fe0ab6e4c915e9910e > > change-id: 20240606-pci-deinit-2e6cdf1bd69f > > > > Best regards, > > -- > > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > Considering certain dependency patches have been merged to > pci/endpoint and other dependency patches have been merged to > pci/controller/dwc, perhaps it is best if you split this series: > > Series 1 based on pci/endpoint: with patch 1/5 and 2/5. > Series 2 based on pci/controller/dwc: with patch 5/5. > Thanks Niklas! I didn't check the 'dwc' branch, so ended up posting patches 3/5 and 4/5 again. Bjorn, if you are OK with this series, I can go ahead and apply patches 1/5 and 2/5 to 'pci/endpoint' and bank on Krzysztof to handle 5/5. - Mani
On Thu, Jun 06, 2024 at 12:56:33PM +0530, Manivannan Sadhasivam wrote: > Hi, > > This series includes patches that were left over from previous series [1] for > making the host reboot handling robust in endpoint framework. > > When the above mentioned series got merged to pci/endpoint, we got a bug report > from LKP bot [2] and due to that the offending patches were dropped. > > This series addressed the issue reported by the bot by adding the stub APIs in > include/pci/pci-epc.h and also removed the unused dwc wrapper as concluded in > [3]. > > Testing > ======= > > This series is tested on Qcom SM8450 based development board with 2 SM8450 SoCs > connected over PCIe. > > - Mani > Applied patch 2/5 to pci/endpoint! Krzysztof, please apply patches 1/5 and 5/5 to controller/dwc (patches 3/5 and 4/5 are already applied by you). - Mani > [1] https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-0-22832d0d456f@linaro.org/ > [2] https://lore.kernel.org/linux-pci/202405130815.BwBrIepL-lkp@intel.com/ > [3] https://lore.kernel.org/linux-pci/20240529141614.GA3293@thinkpad/ > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Manivannan Sadhasivam (5): > PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper > PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers > PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event > PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event > PCI: layerscape-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event > > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > drivers/pci/controller/dwc/pci-imx6.c | 2 +- > drivers/pci/controller/dwc/pci-keystone.c | 2 +- > drivers/pci/controller/dwc/pci-layerscape-ep.c | 4 +- > drivers/pci/controller/dwc/pcie-artpec6.c | 2 +- > drivers/pci/controller/dwc/pcie-designware-ep.c | 116 +++++++++++++--------- > drivers/pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 10 +- > drivers/pci/controller/dwc/pcie-keembay.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 5 +- > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 +- > drivers/pci/controller/dwc/pcie-tegra194.c | 3 +- > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +- > drivers/pci/endpoint/functions/pci-epf-mhi.c | 19 ++++ > drivers/pci/endpoint/functions/pci-epf-test.c | 17 +++- > drivers/pci/endpoint/pci-epc-core.c | 25 +++++ > include/linux/pci-epc.h | 13 +++ > include/linux/pci-epf.h | 2 + > 18 files changed, 162 insertions(+), 68 deletions(-) > --- > base-commit: 7d96527bc16e46545739c6fe0ab6e4c915e9910e > change-id: 20240606-pci-deinit-2e6cdf1bd69f > > Best regards, > -- > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >
Hello, > Applied patch 2/5 to pci/endpoint! Krzysztof, please apply patches 1/5 and 5/5 > to controller/dwc (patches 3/5 and 4/5 are already applied by you). Applied to controller/dwc, thank you! [01/02] PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper https://git.kernel.org/pci/pci/c/9eba2f70362f [02/02] PCI: layerscape-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event https://git.kernel.org/pci/pci/c/14638af66309 Krzysztof
Hi, This series includes patches that were left over from previous series [1] for making the host reboot handling robust in endpoint framework. When the above mentioned series got merged to pci/endpoint, we got a bug report from LKP bot [2] and due to that the offending patches were dropped. This series addressed the issue reported by the bot by adding the stub APIs in include/pci/pci-epc.h and also removed the unused dwc wrapper as concluded in [3]. Testing ======= This series is tested on Qcom SM8450 based development board with 2 SM8450 SoCs connected over PCIe. - Mani [1] https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-0-22832d0d456f@linaro.org/ [2] https://lore.kernel.org/linux-pci/202405130815.BwBrIepL-lkp@intel.com/ [3] https://lore.kernel.org/linux-pci/20240529141614.GA3293@thinkpad/ Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Manivannan Sadhasivam (5): PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event PCI: layerscape-ep: Use the generic dw_pcie_ep_linkdown() API to handle Link Down event drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- drivers/pci/controller/dwc/pci-imx6.c | 2 +- drivers/pci/controller/dwc/pci-keystone.c | 2 +- drivers/pci/controller/dwc/pci-layerscape-ep.c | 4 +- drivers/pci/controller/dwc/pcie-artpec6.c | 2 +- drivers/pci/controller/dwc/pcie-designware-ep.c | 116 +++++++++++++--------- drivers/pci/controller/dwc/pcie-designware-plat.c | 2 +- drivers/pci/controller/dwc/pcie-designware.h | 10 +- drivers/pci/controller/dwc/pcie-keembay.c | 2 +- drivers/pci/controller/dwc/pcie-qcom-ep.c | 5 +- drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 +- drivers/pci/controller/dwc/pcie-tegra194.c | 3 +- drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +- drivers/pci/endpoint/functions/pci-epf-mhi.c | 19 ++++ drivers/pci/endpoint/functions/pci-epf-test.c | 17 +++- drivers/pci/endpoint/pci-epc-core.c | 25 +++++ include/linux/pci-epc.h | 13 +++ include/linux/pci-epf.h | 2 + 18 files changed, 162 insertions(+), 68 deletions(-) --- base-commit: 7d96527bc16e46545739c6fe0ab6e4c915e9910e change-id: 20240606-pci-deinit-2e6cdf1bd69f Best regards,