mbox series

[v6,0/2] Fix user PD inimem requirements

Message ID 20240722080200.3530850-1-quic_ekangupt@quicinc.com (mailing list archive)
Headers show
Series Fix user PD inimem requirements | expand

Message

Ekansh Gupta July 22, 2024, 8:01 a.m. UTC
This patch series fixes the incorrect initmem size assumptions for
signed and unsigned user PD.
Previous single patch[v4]: https://lore.kernel.org/all/20240719085708.1764952-1-quic_ekangupt@quicinc.com/

Changes in v2:
  - Modified commit text.
  - Removed size check instead of updating max file size.
Changes in v3:
  - Added bound check again with a higher max size definition.
  - Modified commit text accordingly.
Changes in v4:
  - Defined new initmem specific MACROs.
  - Adding extra memory for unsigned PD.
  - Added comment suggesting the reason for this change.
  - Modified commit text.
Changes in v5:
  - Splitted the change into separate patches.
Changes in v6:
  - Changed Unsigned extra length macro name.
  - Add comment in proper format.

Ekansh Gupta (2):
  misc: fastrpc: Define a new initmem size for user PD
  misc: fastrpc: Increase unsigned PD initmem size

 drivers/misc/fastrpc.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Dmitry Baryshkov July 22, 2024, 8:26 a.m. UTC | #1
On Mon, Jul 22, 2024 at 01:31:58PM GMT, Ekansh Gupta wrote:
> This patch series fixes the incorrect initmem size assumptions for
> signed and unsigned user PD.
> Previous single patch[v4]: https://lore.kernel.org/all/20240719085708.1764952-1-quic_ekangupt@quicinc.com/
> 
> Changes in v2:
>   - Modified commit text.
>   - Removed size check instead of updating max file size.
> Changes in v3:
>   - Added bound check again with a higher max size definition.
>   - Modified commit text accordingly.
> Changes in v4:
>   - Defined new initmem specific MACROs.
>   - Adding extra memory for unsigned PD.
>   - Added comment suggesting the reason for this change.
>   - Modified commit text.
> Changes in v5:
>   - Splitted the change into separate patches.
> Changes in v6:
>   - Changed Unsigned extra length macro name.
>   - Add comment in proper format.

Please allow reviewers to finish with the previous iteration first. The
usual recommendation is to send new iteration once per 24h timeframe.

> 
> Ekansh Gupta (2):
>   misc: fastrpc: Define a new initmem size for user PD
>   misc: fastrpc: Increase unsigned PD initmem size
> 
>  drivers/misc/fastrpc.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> -- 
> 2.34.1
>
Ekansh Gupta July 23, 2024, 4:37 a.m. UTC | #2
On 7/22/2024 1:56 PM, Dmitry Baryshkov wrote:
> On Mon, Jul 22, 2024 at 01:31:58PM GMT, Ekansh Gupta wrote:
>> This patch series fixes the incorrect initmem size assumptions for
>> signed and unsigned user PD.
>> Previous single patch[v4]: https://lore.kernel.org/all/20240719085708.1764952-1-quic_ekangupt@quicinc.com/
>>
>> Changes in v2:
>>   - Modified commit text.
>>   - Removed size check instead of updating max file size.
>> Changes in v3:
>>   - Added bound check again with a higher max size definition.
>>   - Modified commit text accordingly.
>> Changes in v4:
>>   - Defined new initmem specific MACROs.
>>   - Adding extra memory for unsigned PD.
>>   - Added comment suggesting the reason for this change.
>>   - Modified commit text.
>> Changes in v5:
>>   - Splitted the change into separate patches.
>> Changes in v6:
>>   - Changed Unsigned extra length macro name.
>>   - Add comment in proper format.
> Please allow reviewers to finish with the previous iteration first. The
> usual recommendation is to send new iteration once per 24h timeframe.
Noted.

Thanks,
Ekansh
>
>> Ekansh Gupta (2):
>>   misc: fastrpc: Define a new initmem size for user PD
>>   misc: fastrpc: Increase unsigned PD initmem size
>>
>>  drivers/misc/fastrpc.c | 11 ++++++++++-
>>  1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> -- 
>> 2.34.1
>>